mbox series

[0/1,SRU,OEM-5.10] Intel e1000e blocks the system to enter PC10 on TGL platform

Message ID 20210315065328.54680-1-acelan.kao@canonical.com
Headers show
Series Intel e1000e blocks the system to enter PC10 on TGL platform | expand

Message

AceLan Kao March 15, 2021, 6:53 a.m. UTC
From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>

BugLink: https://bugs.launchpad.net/bugs/1919116

[Impact]
The deepest package cstate is PC9 and fails to enter low power mode during
s2i on Tiger Lake platform.

[Fix]
Intel provides a fix for TGL platform
https://patchwork.kernel.org/project/platform-driver-x86/patch/20210305190608.1834164-1-david.e.box@linux.intel.com/

[Test]
Verified on Dell TGL platforms and it works as expected.

[Where problem could occur]
It actually adds a quirk for tgl platform to ignore Latency Tolerance
Reporting (LTR) in pmc_core driver, that makes GBE on TGL won't block the
system to enter deeper PC state. It should be safe for all TGL platforms.

[Misc]
Currently, this commit is not accepted and a v2 is expected. So, submit
this commit to oem kernel only and will revert it and submit final version
of this patch to ubuntu kernels later.

David E. Box (1):
  UBUNTU: SAUCE: platform/x86: intel_pmc: Ignore GBE LTR on Tiger Lake
    platforms

 drivers/platform/x86/intel_pmc_core.c | 55 ++++++++++++++++++++-------
 1 file changed, 42 insertions(+), 13 deletions(-)

Comments

Timo Aaltonen March 18, 2021, 7:35 p.m. UTC | #1
On 15.3.2021 8.53, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1919116
> 
> [Impact]
> The deepest package cstate is PC9 and fails to enter low power mode during
> s2i on Tiger Lake platform.
> 
> [Fix]
> Intel provides a fix for TGL platform
> https://patchwork.kernel.org/project/platform-driver-x86/patch/20210305190608.1834164-1-david.e.box@linux.intel.com/
> 
> [Test]
> Verified on Dell TGL platforms and it works as expected.
> 
> [Where problem could occur]
> It actually adds a quirk for tgl platform to ignore Latency Tolerance
> Reporting (LTR) in pmc_core driver, that makes GBE on TGL won't block the
> system to enter deeper PC state. It should be safe for all TGL platforms.
> 
> [Misc]
> Currently, this commit is not accepted and a v2 is expected. So, submit
> this commit to oem kernel only and will revert it and submit final version
> of this patch to ubuntu kernels later.
> 
> David E. Box (1):
>    UBUNTU: SAUCE: platform/x86: intel_pmc: Ignore GBE LTR on Tiger Lake
>      platforms
> 
>   drivers/platform/x86/intel_pmc_core.c | 55 ++++++++++++++++++++-------
>   1 file changed, 42 insertions(+), 13 deletions(-)
> 

applied to oem-5.10, thanks