From patchwork Mon Feb 8 13:40:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Bader X-Patchwork-Id: 1437659 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DZ6c55sR6z9sRf; Tue, 9 Feb 2021 00:40:52 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1l96mV-00086Z-RA; Mon, 08 Feb 2021 13:40:47 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1l96mU-00086T-Dy for kernel-team@lists.ubuntu.com; Mon, 08 Feb 2021 13:40:46 +0000 Received: from 1.general.smb.uk.vpn ([10.172.193.28] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1l96mU-00041z-2D for kernel-team@lists.ubuntu.com; Mon, 08 Feb 2021 13:40:46 +0000 From: Stefan Bader To: kernel-team@lists.ubuntu.com Subject: [SRU G][PATCH 0/1] Fix geneve overlay network on vlan interface broken with offload enabled Date: Mon, 8 Feb 2021 14:40:44 +0100 Message-Id: <20210208134045.18387-1-stefan.bader@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" [SRU Justification] Impact: In upstream v5.2 geneve tunnel stateless offload support was added to the mlx5 driver. This had some issue with VLANs where the VLAN ID was set by the driver even when offload support was enabled. Fix: Upstream (v5.11-rc3) commit 378d3783412e38dc3a2b9d524f551c0008ea314a "net/mlx5e: Fix SWP offsets when vlan inserted by driver" was backported (dropping some code because it did not yet exist in 5.8) and verified to address the problem. Testcase: Enable geneve tunnel offload support on a mlx5(e) card over VLAN. Regression potential: The modified code path is sending packets tagged for VLAN(s), so outgoing traffic into VLAN(s) would most likely be impacted. Moshe Shemesh (1): net/mlx5e: Fix SWP offsets when vlan inserted by driver drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h | 9 +++++++++ .../net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h | 4 +++- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 2 +- 3 files changed, 13 insertions(+), 2 deletions(-)