mbox series

[SRU,G,0/1] Fix geneve overlay network on vlan interface broken with offload enabled

Message ID 20210208134045.18387-1-stefan.bader@canonical.com
Headers show
Series Fix geneve overlay network on vlan interface broken with offload enabled | expand

Message

Stefan Bader Feb. 8, 2021, 1:40 p.m. UTC
[SRU Justification]

Impact: In upstream v5.2 geneve tunnel stateless offload support was added
to the mlx5 driver. This had some issue with VLANs where the VLAN ID was set
by the driver even when offload support was enabled.

Fix: Upstream (v5.11-rc3) commit 378d3783412e38dc3a2b9d524f551c0008ea314a
"net/mlx5e: Fix SWP offsets when vlan inserted by driver" was backported
(dropping some code because it did not yet exist in 5.8) and verified to
address the problem.

Testcase: Enable geneve tunnel offload support on a mlx5(e) card over VLAN.

Regression potential: The modified code path is sending packets tagged for
VLAN(s), so outgoing traffic into VLAN(s) would most likely be impacted.

Moshe Shemesh (1):
  net/mlx5e: Fix SWP offsets when vlan inserted by driver

 drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h        | 9 +++++++++
 .../net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h  | 4 +++-
 drivers/net/ethernet/mellanox/mlx5/core/en_tx.c          | 2 +-
 3 files changed, 13 insertions(+), 2 deletions(-)

Comments

Kelsey Skunberg Feb. 13, 2021, 12:17 a.m. UTC | #1
Applied to G/master-next. thank you! 

-Kelsey

On 2021-02-08 14:40:44 , Stefan Bader wrote:
> [SRU Justification]
> 
> Impact: In upstream v5.2 geneve tunnel stateless offload support was added
> to the mlx5 driver. This had some issue with VLANs where the VLAN ID was set
> by the driver even when offload support was enabled.
> 
> Fix: Upstream (v5.11-rc3) commit 378d3783412e38dc3a2b9d524f551c0008ea314a
> "net/mlx5e: Fix SWP offsets when vlan inserted by driver" was backported
> (dropping some code because it did not yet exist in 5.8) and verified to
> address the problem.
> 
> Testcase: Enable geneve tunnel offload support on a mlx5(e) card over VLAN.
> 
> Regression potential: The modified code path is sending packets tagged for
> VLAN(s), so outgoing traffic into VLAN(s) would most likely be impacted.
> 
> Moshe Shemesh (1):
>   net/mlx5e: Fix SWP offsets when vlan inserted by driver
> 
>  drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h        | 9 +++++++++
>  .../net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h  | 4 +++-
>  drivers/net/ethernet/mellanox/mlx5/core/en_tx.c          | 2 +-
>  3 files changed, 13 insertions(+), 2 deletions(-)
> 
> -- 
> 2.25.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team