mbox series

[SRU,Unstable/OEM-5.10,0/1] Use INTx for Pericom USB controllers

Message ID 20201204142155.2244959-1-kai.heng.feng@canonical.com
Headers show
Series Use INTx for Pericom USB controllers | expand

Message

Kai-Heng Feng Dec. 4, 2020, 2:21 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1906839

[Impact]
Pericom EHCI/OHCI controller cannot detect USB hotplug after using MSI.

[Fix]
Disable MSI and fallback to INTx.

[Test]
Hotplug any USB device and nothing gets detected.
With the fix applied the issue is gone.

[Where problems could occur]
Nothing wrong can happen. It was already using INTx before 306c54d0edb6
("usb: hcd: Try MSI interrupts on PCI devices"), and now it goes back to
use INTx again.

Andy Shevchenko (1):
  PCI: Disable MSI for Pericom PCIe-USB adapter

 drivers/pci/quirks.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

Comments

Timo Aaltonen Dec. 8, 2020, 2:17 p.m. UTC | #1 
On 4.12.2020 16.21, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1906839
> 
> [Impact]
> Pericom EHCI/OHCI controller cannot detect USB hotplug after using MSI.
> 
> [Fix]
> Disable MSI and fallback to INTx.
> 
> [Test]
> Hotplug any USB device and nothing gets detected.
> With the fix applied the issue is gone.
> 
> [Where problems could occur]
> Nothing wrong can happen. It was already using INTx before 306c54d0edb6
> ("usb: hcd: Try MSI interrupts on PCI devices"), and now it goes back to
> use INTx again.
> 
> Andy Shevchenko (1):
>    PCI: Disable MSI for Pericom PCIe-USB adapter
> 
>   drivers/pci/quirks.c | 17 +++++++++++++----
>   1 file changed, 13 insertions(+), 4 deletions(-)
> 

applied to oem-5.10, thanks
Andrea Righi Dec. 15, 2020, 8:36 a.m. UTC | #2 
On Fri, Dec 04, 2020 at 10:21:54PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1906839
> 
> [Impact]
> Pericom EHCI/OHCI controller cannot detect USB hotplug after using MSI.
> 
> [Fix]
> Disable MSI and fallback to INTx.
> 
> [Test]
> Hotplug any USB device and nothing gets detected.
> With the fix applied the issue is gone.
> 
> [Where problems could occur]
> Nothing wrong can happen. It was already using INTx before 306c54d0edb6
> ("usb: hcd: Try MSI interrupts on PCI devices"), and now it goes back to
> use INTx again.
> 
> Andy Shevchenko (1):
>   PCI: Disable MSI for Pericom PCIe-USB adapter
> 
>  drivers/pci/quirks.c | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)

Applied to unstable, thanks.

-Andrea