mbox series

[F/G/Unstable/OEM-5.6,0/1] Use ACPI S5 for reboot

Message ID 20201113170159.1044893-1-kai.heng.feng@canonical.com
Headers show
Series Use ACPI S5 for reboot | expand

Message

Kai-Heng Feng Nov. 13, 2020, 5:01 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1904225

[Impact]
On some HP laptops, BIOS hotkeys don't work right after reboot, becuase
OS doesn't call _PTS to indicate ACPI it's rebooting.

[Fix]
Follow Windows and use S5 for reboot.

[Test case]
Reboot and see if hotkeys like F10/F11 can trigger BIOS functions.
Hotkeys work great with the patch applied.

[Where problems could occur]
If there are platforms don't expect S5 for reboot then there could be
unexpected result.
However Windows uses S5 so that's rather unlikely.

Kai-Heng Feng (1):
  PM: ACPI: reboot: Use S5 for reboot

 kernel/reboot.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

William Breathitt Gray Nov. 20, 2020, 4:36 p.m. UTC | #1 
On Sat, Nov 14, 2020 at 01:01:58AM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1904225
> 
> [Impact]
> On some HP laptops, BIOS hotkeys don't work right after reboot, becuase
> OS doesn't call _PTS to indicate ACPI it's rebooting.
> 
> [Fix]
> Follow Windows and use S5 for reboot.
> 
> [Test case]
> Reboot and see if hotkeys like F10/F11 can trigger BIOS functions.
> Hotkeys work great with the patch applied.
> 
> [Where problems could occur]
> If there are platforms don't expect S5 for reboot then there could be
> unexpected result.
> However Windows uses S5 so that's rather unlikely.
> 
> Kai-Heng Feng (1):
>   PM: ACPI: reboot: Use S5 for reboot
> 
>  kernel/reboot.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> -- 
> 2.28.0

Applied to Focal:linux and Groovy:linux.

William Breathitt Gray
Timo Aaltonen Dec. 1, 2020, 9:01 a.m. UTC | #2 
On 13.11.2020 19.01, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1904225
> 
> [Impact]
> On some HP laptops, BIOS hotkeys don't work right after reboot, becuase
> OS doesn't call _PTS to indicate ACPI it's rebooting.
> 
> [Fix]
> Follow Windows and use S5 for reboot.
> 
> [Test case]
> Reboot and see if hotkeys like F10/F11 can trigger BIOS functions.
> Hotkeys work great with the patch applied.
> 
> [Where problems could occur]
> If there are platforms don't expect S5 for reboot then there could be
> unexpected result.
> However Windows uses S5 so that's rather unlikely.
> 
> Kai-Heng Feng (1):
>    PM: ACPI: reboot: Use S5 for reboot
> 
>   kernel/reboot.c | 2 ++
>   1 file changed, 2 insertions(+)
> 

applied to oem-5.6, thanks
Seth Forshee Dec. 18, 2020, 11:06 p.m. UTC | #3 
On Sat, Nov 14, 2020 at 01:01:58AM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1904225
> 
> [Impact]
> On some HP laptops, BIOS hotkeys don't work right after reboot, becuase
> OS doesn't call _PTS to indicate ACPI it's rebooting.
> 
> [Fix]
> Follow Windows and use S5 for reboot.
> 
> [Test case]
> Reboot and see if hotkeys like F10/F11 can trigger BIOS functions.
> Hotkeys work great with the patch applied.
> 
> [Where problems could occur]
> If there are platforms don't expect S5 for reboot then there could be
> unexpected result.
> However Windows uses S5 so that's rather unlikely.

Applied to unstable/master, thanks!