From patchwork Tue Sep 15 18:56:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: patricia.domingues@canonical.com X-Patchwork-Id: 1364591 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BrXYj4Kslz9sTt; Wed, 16 Sep 2020 04:58:16 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1kIG9Z-0000Lx-6l; Tue, 15 Sep 2020 18:58:09 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kIG9X-0000Lr-8y for kernel-team@lists.ubuntu.com; Tue, 15 Sep 2020 18:58:07 +0000 Received: from 1.general.patriciasd.us.vpn ([10.172.64.192] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kIG9W-0001Qu-E1 for kernel-team@lists.ubuntu.com; Tue, 15 Sep 2020 18:58:07 +0000 From: patricia.domingues@canonical.com To: kernel-team@lists.ubuntu.com Subject: [SRU][X][B][F][G][PATCH 0/1] Don't NULL tty->driver_data until hvcs_cleanup() (LP: 1892546) Date: Tue, 15 Sep 2020 15:56:48 -0300 Message-Id: <20200915185649.24706-1-patricia.domingues@canonical.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1892546 SRU Justification: [Impact] * drmgr command is failing while trying to open console for IBMi on PowerVM LPAR [Fix] * 63ffcbdad738 "tty: hvcs: Don't NULL tty->driver_data until hvcs_cleanup()" [Test Case] * Create a VM from PowerVC on a Novalink managed host. * Unmanage and manage the VM, this problem gets reproduced. * grep the logs for "drmgr" [Regression Potential] The regression can be considered as very low, since: * limited to the IBM Hypervisor Virtual Console Server. * patched kernel where shared and successfully tested by IBM. * the worse case, if the cleanup is broken a new opened connection might break. [Other] * The patch got upstream accepted. Tyrel Datwyler (1): tty: hvcs: Don't NULL tty->driver_data until hvcs_cleanup() drivers/tty/hvc/hvcs.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) Acked-by: Paolo Pisati