From patchwork Mon Sep 14 15:05:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: patricia.domingues@canonical.com X-Patchwork-Id: 1363703 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BqqS25dLWz9sVW; Tue, 15 Sep 2020 01:05:53 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1kHq37-0008BT-RC; Mon, 14 Sep 2020 15:05:45 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kHq36-0008BN-NI for kernel-team@lists.ubuntu.com; Mon, 14 Sep 2020 15:05:44 +0000 Received: from 1.general.patriciasd.us.vpn ([10.172.64.192] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kHq35-0002uf-S6 for kernel-team@lists.ubuntu.com; Mon, 14 Sep 2020 15:05:44 +0000 From: patricia.domingues@canonical.com To: kernel-team@lists.ubuntu.com Subject: [SRU][X][B][F][PATCH 0/1] Do not initiate shutdown for EPOW_SHUTDOWN_ON_UPS event (LP: 1893897) Date: Mon, 14 Sep 2020 12:05:20 -0300 Message-Id: <20200914150521.30869-1-patricia.domingues@canonical.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1893897 SRU Justification: [Impact] * With commit 79872e35469b "powerpc/pseries: All events of EPOW_SYSTEM_SHUTDOWN must initiate shutdown" it was introduced that all EPOW_SYSTEM_SHUTDOWN events cause immediate shutdowns. * But on LPARs there is a user space tool (rtas_errd) that monitor for EPOW_SHUTDOWN_ON_UPS events. * Once rtas_errd gets an event it initiates a shutdown after predefined time. * Therefore immediate shutdowns must not be triggered if the system is running on UPS (means for EPOW_SHUTDOWN_ON_UPS events). [Fix] * 90a9b102eddf6a3f987d15f4454e26a2532c1c98 90a9b102eddf "powerpc/pseries: Do not initiate shutdown when system is running on UPS" [Test Case] * Setup a Power system on (D)LPAR and run it on UPS with Ubuntu 16.04 or higher (kernel 4.x is needed). * Verify that the user space tool (rtas_errd) is active and running. * Define a time for a potential shutdown in case an EPOW_SHUTDOWN_ON_UPS event occurs. * Trigger an EPOW_SHUTDOWN_ON_UPS event. * Verify if the system got shutdown immediately - or after the pre-defined time. [Regression Potential] * The regression risk is very low, because of the very limited modification in a case statement for EPOW_SHUTDOWN_ON_UPS events. * What may happen is that the system doesn't power off anymore if running on UPS due to the EPOW_SHUTDOWN_ON_UPS case changes - especially if there is a potential problem with rtas_errd that should monitor for these events and should initiate the delayed shutdown. * Other than that I cannot see much potential harm. [Other] * The patch got upstream accepted in v5.9-rc2 and already landed in groovy's kernel 'Ubuntu-5.8.0-18.19', based on the v5.8.4 upstream stable release ticket LP 1893048. Vasant Hegde (1): powerpc/pseries: Do not initiate shutdown when system is running on UPS arch/powerpc/platforms/pseries/ras.c | 1 - 1 file changed, 1 deletion(-)