mbox series

[SRU,F/E,0/2] Reverts to fix overlayfs regression

Message ID 20200521111210.3568-1-kleber.souza@canonical.com
Headers show
Series Reverts to fix overlayfs regression | expand

Message

Kleber Sacilotto de Souza May 21, 2020, 11:12 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1879690

[Impact]
The change applied for bug 1857257 and its followup fix bug 1876645, which were
released on focal and eoan -updates, introduced a regression on overlayfs,
breaking docker snap.

[Test case]
See original bug report.

[Fix]
While we don't have a final fix the solution for now is to revert the following
commits:

UBUNTU: SAUCE: overlayfs: fix shitfs special-casing
UBUNTU: SAUCE: overlayfs: use shiftfs hacks only with shiftfs as underlay

[Regression potential]
Low. Reverting these two commits will introduce back the issue reported on bug
1857257, but will fix the other use cases which was broken by the latest
release.

Kleber Sacilotto de Souza (2):
  Revert "UBUNTU: SAUCE: overlayfs: fix shitfs special-casing"
  Revert "UBUNTU: SAUCE: overlayfs: use shiftfs hacks only with shiftfs
    as underlay"

 fs/overlayfs/file.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

Comments

Khalid Elmously May 21, 2020, 11:24 a.m. UTC | #1 
On 2020-05-21 13:12:06 , Kleber Souza wrote:
> BugLink: https://bugs.launchpad.net/bugs/1879690
> 
> [Impact]
> The change applied for bug 1857257 and its followup fix bug 1876645, which were
> released on focal and eoan -updates, introduced a regression on overlayfs,
> breaking docker snap.
> 
> [Test case]
> See original bug report.
> 
> [Fix]
> While we don't have a final fix the solution for now is to revert the following
> commits:
> 
> UBUNTU: SAUCE: overlayfs: fix shitfs special-casing
> UBUNTU: SAUCE: overlayfs: use shiftfs hacks only with shiftfs as underlay
> 
> [Regression potential]
> Low. Reverting these two commits will introduce back the issue reported on bug
> 1857257, but will fix the other use cases which was broken by the latest
> release.
> 
> Kleber Sacilotto de Souza (2):
>   Revert "UBUNTU: SAUCE: overlayfs: fix shitfs special-casing"
>   Revert "UBUNTU: SAUCE: overlayfs: use shiftfs hacks only with shiftfs
>     as underlay"
> 
>  fs/overlayfs/file.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> -- 
> 2.20.1
> 
> 

Seems like we've had a lot of trouble with these patches.
Thanks for fixing it
Kleber Sacilotto de Souza May 21, 2020, 1:33 p.m. UTC | #2 
On 2020-05-21 13:12, Kleber Sacilotto de Souza wrote:
> BugLink: https://bugs.launchpad.net/bugs/1879690
> 
> [Impact]
> The change applied for bug 1857257 and its followup fix bug 1876645, which were
> released on focal and eoan -updates, introduced a regression on overlayfs,
> breaking docker snap.
> 
> [Test case]
> See original bug report.
> 
> [Fix]
> While we don't have a final fix the solution for now is to revert the following
> commits:
> 
> UBUNTU: SAUCE: overlayfs: fix shitfs special-casing
> UBUNTU: SAUCE: overlayfs: use shiftfs hacks only with shiftfs as underlay
> 
> [Regression potential]
> Low. Reverting these two commits will introduce back the issue reported on bug
> 1857257, but will fix the other use cases which was broken by the latest
> release.
> 
> Kleber Sacilotto de Souza (2):
>   Revert "UBUNTU: SAUCE: overlayfs: fix shitfs special-casing"
>   Revert "UBUNTU: SAUCE: overlayfs: use shiftfs hacks only with shiftfs
>     as underlay"
> 
>  fs/overlayfs/file.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 

Applied to eoan/linux and focal/linux.

Thanks,
Kleber