From patchwork Fri May 8 21:04:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kelsey Skunberg X-Patchwork-Id: 1286453 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49JjWx5gxCz9sSd; Sat, 9 May 2020 07:05:01 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1jXAAy-00059U-V9; Fri, 08 May 2020 21:04:56 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jXAAx-000586-BA for kernel-team@lists.ubuntu.com; Fri, 08 May 2020 21:04:55 +0000 Received: from mail-io1-f69.google.com ([209.85.166.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jXAAx-0001im-0F for kernel-team@lists.ubuntu.com; Fri, 08 May 2020 21:04:55 +0000 Received: by mail-io1-f69.google.com with SMTP id w4so3133347iol.0 for ; Fri, 08 May 2020 14:04:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=XsvsPtPCg6ircvnEl1kt3viT0pVyQ/pMYVEPy2uvxVg=; b=GdzcnatiYgjmZy/TCLCsHlls1vsKFAPPqK5/IIDMNXvZcQs6ud01A/Y7qPnwfGvQY+ 3jONpK88woPNu1+5mIdWZfuORK9kowYmh02dwYbRRoFRpuA4CN6quMTvXQ+ry8KQwNcc 9xp29giHmeK4Z4VVFEF/hIDDTC89SyYiTo0G27FWgv4c1GoFi98hEUHo6JjAiOOONRaa zxUHYBiWy3Pi/5FhpCxN9IDjzpbChip5KymMVOOuc+VBYW6Jud3pTPAgICZljiEKcISr nrnMGuqmx/U1gleqyYEnrMPeep7MgWYZWT1aHCV/FMqF1AVWtLFj1P1dQ5TDTnuAMLeQ NaQg== X-Gm-Message-State: AGi0PublAOezrZnRX6EmEpofG4B4Lsm+PHdc4JwQLJvZkjNV9cXjb5ed Nkcz7fvMTYyxa55bhv73xMCazNSMvkhJDzGOf7lswQ+U/I45Z8sX6mamaqAtxXP/VhNs23bG3kn mSg1DPPBXIp2ROa78vJIWMLnexixhUEVpOeyChnL0mQ== X-Received: by 2002:a5e:9705:: with SMTP id w5mr4542979ioj.86.1588971893816; Fri, 08 May 2020 14:04:53 -0700 (PDT) X-Google-Smtp-Source: APiQypILL733XnsQr4TbWo6H42sLMMemV8F2bBEE8YYoiwPU85TSAwqteADWPrhIIiDnZ6NBFCz7Sg== X-Received: by 2002:a5e:9705:: with SMTP id w5mr4542961ioj.86.1588971893565; Fri, 08 May 2020 14:04:53 -0700 (PDT) Received: from localhost.localdomain (c-73-243-191-173.hsd1.co.comcast.net. [73.243.191.173]) by smtp.gmail.com with ESMTPSA id r18sm1148170ioj.15.2020.05.08.14.04.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 14:04:53 -0700 (PDT) From: Kelsey Skunberg To: kernel-team@lists.ubuntu.com Subject: [B][PATCH v2 0/2] Revert drm/msm patches that cause certification testing failure Date: Fri, 8 May 2020 15:04:35 -0600 Message-Id: <20200508210437.31193-1-kelsey.skunberg@canonical.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1877657 [SRU Justification] [Impact] snap certification testing failed with bionic/linux-snapdragon https://bugs.launchpad.net/bugs/1874763 After investigations by Kleber, failure was found to be from a drm driver which is compiled when CONFIG_DRM_MSM is set. Information reported from Paul Larson [1]: We have a cold reboot test in checkbox that seems to be failing with this kernel. The test runs the following commands to try to trigger a cold reboot: rtcwake --mode no -s 120 sleep 5 rtcwake -m show sleep 5 dbus-send --system --print-reply --dest=org.freedesktop.login1 /org/freedesktop/login1 "org.freedesktop.login1.Manager.PowerOff" boolean:true However, the system never fully reboots. On the serial console, I just see: ... Press enter to configure. [ 137.402465] systemd-shutdown[1]: Failed to wait for process: Protocol error [ 137.406163] systemd-shutdown[1]: Failed to wait for process: Protocol error I do have the ability to remotely remove power from the device and restore it, however after doing that, I get an oops on the serial console and the system never comes up. [1] https://bugs.launchpad.net/kernel-sru-workflow/+bug/1874763/comments/1 [Test] Run Certification Testing The tests are ran only with UC18, so a kernel snap is needed to either build a new image or promote it to edge. [Fix] Revert upstream commits on Bionic/linux: 0519bad6f34f drm/msm: Use the correct dma_sync calls in msm_gem 7318c5ef642b drm/msm: stop abusing dma_map/unmap for cache [Risk of Regression] Alternative solutions would need to be found for dma_sync calls in msm_gem and to avoid abusing dma_map/unmap for cache. The commits both came from upstream stable. Changes since v1: fixed cover letter title that was cut off Kelsey Skunberg (2): Revert "drm/msm: Use the correct dma_sync calls in msm_gem" Revert "drm/msm: stop abusing dma_map/unmap for cache" drivers/gpu/drm/msm/msm_gem.c | 47 ++++------------------------------- 1 file changed, 5 insertions(+), 42 deletions(-) Acked-by: Khalid Elmously Acked-by: Thadeu Lima de Souza Cascardo