| Message ID | 20200430131753.7381-1-hui.wang@canonical.com |
|---|---|
| Headers | show |
| Series | alsa/sof: kernel oops on the machine without Intel hdmi audio codec (a regression in the asoc machine driver) | expand |
On Thu, Apr 30, 2020 at 09:17:52PM +0800, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1874359 > > In the RESEND: > fix the bug number, and this SRU already applied to OEM-B-OSP1 and > OEM-5.6 kernel, so remove them form title. > > > Please apply the fix for #1872569 first, then apply this patch. > > [Impact] > The fix for #1872569 introduces a regression, the driver access a > NULL pointer on the machiens without Intel hdmi audio codec. > > [Fix] > pick a fixing patch from alsa/asoc repo, the patch doesn't assume > the first rtd is for hda codec, it will look for that rtd through > strstr() > > [Test Case] > Boot the kenrel on those 2 Dell and 2 Lenovo machines which uses > this driver, the audio could work. disable the intel hdmi audio codec > through bios, the analogue audio still works > > > [Regression Risk] > Low, I have tested this patch Lenovo / Dell machines, they all worked well. Acked-by: Seth Forshee <seth.forshee@canonical.com> Applied to unstable/master, thanks!
On 2020-04-30 21:17:52 , Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1874359 > > In the RESEND: > fix the bug number, and this SRU already applied to OEM-B-OSP1 and > OEM-5.6 kernel, so remove them form title. > > > Please apply the fix for #1872569 first, then apply this patch. > > [Impact] > The fix for #1872569 introduces a regression, the driver access a > NULL pointer on the machiens without Intel hdmi audio codec. > > [Fix] > pick a fixing patch from alsa/asoc repo, the patch doesn't assume > the first rtd is for hda codec, it will look for that rtd through > strstr() > > [Test Case] > Boot the kenrel on those 2 Dell and 2 Lenovo machines which uses > this driver, the audio could work. disable the intel hdmi audio codec > through bios, the analogue audio still works > > > [Regression Risk] > Low, I have tested this patch Lenovo / Dell machines, they all worked well. > > > Kai Vehmanen (1): > UBUNTU: SAUCE: ASoC: intel/skl/hda - fix oops on systems without i915 > audio codec > > sound/soc/intel/boards/skl_hda_dsp_generic.c | 34 +++++++++++--------- > 1 file changed, 18 insertions(+), 16 deletions(-) > > -- > 2.17.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
BugLink: https://bugs.launchpad.net/bugs/1874359 In the RESEND: fix the bug number, and this SRU already applied to OEM-B-OSP1 and OEM-5.6 kernel, so remove them form title. Please apply the fix for #1872569 first, then apply this patch. [Impact] The fix for #1872569 introduces a regression, the driver access a NULL pointer on the machiens without Intel hdmi audio codec. [Fix] pick a fixing patch from alsa/asoc repo, the patch doesn't assume the first rtd is for hda codec, it will look for that rtd through strstr() [Test Case] Boot the kenrel on those 2 Dell and 2 Lenovo machines which uses this driver, the audio could work. disable the intel hdmi audio codec through bios, the analogue audio still works [Regression Risk] Low, I have tested this patch Lenovo / Dell machines, they all worked well. Kai Vehmanen (1): UBUNTU: SAUCE: ASoC: intel/skl/hda - fix oops on systems without i915 audio codec sound/soc/intel/boards/skl_hda_dsp_generic.c | 34 +++++++++++--------- 1 file changed, 18 insertions(+), 16 deletions(-)