mbox series

[SRU,F/OEM-F/unstable,0/1] a fake headset key event will be triggered when plugging the headset on Lenovo x1c7

Message ID 20200414033122.4913-1-hui.wang@canonical.com
Headers show
Series a fake headset key event will be triggered when plugging the headset on Lenovo x1c7 | expand

Message

Hui Wang April 14, 2020, 3:31 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1872583

[Impact]
When users plug a headset into the audio jack on Lenovo x1c7, the
audio driver can't stay in the rt_suspend state anymore

[Fix]
don't let the driver trigger the fake key event

[Test Case]
boot the kenrel, enable the dyndbg on the codec driver,
plug/unplug the headset, check the runime pm status in the dmesg

[Regression Risk]
Low, I have tested this patch Lenovo machines, they all worked well.


Hui Wang (1):
  ALSA: hda/realtek - a fake key event is triggered by running shutup

 sound/pci/hda/patch_realtek.c | 170 +++++++++++++++++++++-------------
 1 file changed, 107 insertions(+), 63 deletions(-)

Comments

Timo Aaltonen April 23, 2020, 7:16 a.m. UTC | #1
On 14.4.2020 6.31, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1872583
> 
> [Impact]
> When users plug a headset into the audio jack on Lenovo x1c7, the
> audio driver can't stay in the rt_suspend state anymore
> 
> [Fix]
> don't let the driver trigger the fake key event

applied to oem-5.6-next, thanks
Timo Aaltonen April 23, 2020, 7:48 a.m. UTC | #2
On 23.4.2020 10.16, Timo Aaltonen wrote:
> On 14.4.2020 6.31, Hui Wang wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1872583
>>
>> [Impact]
>> When users plug a headset into the audio jack on Lenovo x1c7, the
>> audio driver can't stay in the rt_suspend state anymore
>>
>> [Fix]
>> don't let the driver trigger the fake key event
> 
> applied to oem-5.6-next, thanks

actually, this came via stable, so I'll use that instead
Kleber Sacilotto de Souza April 23, 2020, 1:52 p.m. UTC | #3
On 14.04.20 05:31, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1872583
> 
> [Impact]
> When users plug a headset into the audio jack on Lenovo x1c7, the
> audio driver can't stay in the rt_suspend state anymore
> 
> [Fix]
> don't let the driver trigger the fake key event
> 
> [Test Case]
> boot the kenrel, enable the dyndbg on the codec driver,
> plug/unplug the headset, check the runime pm status in the dmesg
> 
> [Regression Risk]
> Low, I have tested this patch Lenovo machines, they all worked well.
> 
> 
> Hui Wang (1):
>   ALSA: hda/realtek - a fake key event is triggered by running shutup
> 
>  sound/pci/hda/patch_realtek.c | 170 +++++++++++++++++++++-------------
>  1 file changed, 107 insertions(+), 63 deletions(-)
> 

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Kamal Mostafa April 23, 2020, 5:01 p.m. UTC | #4
Acked-by: Kamal Mostafa <kamal@canonical.com>

 -Kamal

On Tue, Apr 14, 2020 at 11:31:21AM +0800, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1872583
> 
> [Impact]
> When users plug a headset into the audio jack on Lenovo x1c7, the
> audio driver can't stay in the rt_suspend state anymore
> 
> [Fix]
> don't let the driver trigger the fake key event
> 
> [Test Case]
> boot the kenrel, enable the dyndbg on the codec driver,
> plug/unplug the headset, check the runime pm status in the dmesg
> 
> [Regression Risk]
> Low, I have tested this patch Lenovo machines, they all worked well.
> 
> 
> Hui Wang (1):
>   ALSA: hda/realtek - a fake key event is triggered by running shutup
> 
>  sound/pci/hda/patch_realtek.c | 170 +++++++++++++++++++++-------------
>  1 file changed, 107 insertions(+), 63 deletions(-)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Kelsey Skunberg April 24, 2020, 6:28 p.m. UTC | #5
On 2020-04-14 11:31:21 , Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1872583
> 
> [Impact]
> When users plug a headset into the audio jack on Lenovo x1c7, the
> audio driver can't stay in the rt_suspend state anymore
> 
> [Fix]
> don't let the driver trigger the fake key event
> 
> [Test Case]
> boot the kenrel, enable the dyndbg on the codec driver,
> plug/unplug the headset, check the runime pm status in the dmesg
> 
> [Regression Risk]
> Low, I have tested this patch Lenovo machines, they all worked well.
> 
> 
> Hui Wang (1):
>   ALSA: hda/realtek - a fake key event is triggered by running shutup
> 
>  sound/pci/hda/patch_realtek.c | 170 +++++++++++++++++++++-------------
>  1 file changed, 107 insertions(+), 63 deletions(-)
>

This was applied through a stable patch set. Verified in Focal/master-next.
Thank you! 

-Kelsey
 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Seth Forshee April 30, 2020, 9 p.m. UTC | #6
On Tue, Apr 14, 2020 at 11:31:21AM +0800, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1872583
> 
> [Impact]
> When users plug a headset into the audio jack on Lenovo x1c7, the
> audio driver can't stay in the rt_suspend state anymore
> 
> [Fix]
> don't let the driver trigger the fake key event
> 
> [Test Case]
> boot the kenrel, enable the dyndbg on the codec driver,
> plug/unplug the headset, check the runime pm status in the dmesg
> 
> [Regression Risk]
> Low, I have tested this patch Lenovo machines, they all worked well.

Unstable already has this patch from upstream.