mbox series

[SRU,Focal,0/4] alsa/sof: let sof driver work with topology with volume and led control (focal)

Message ID 20200224011311.7178-1-hui.wang@canonical.com
Headers show
Series alsa/sof: let sof driver work with topology with volume and led control (focal) | expand

Message

Hui Wang Feb. 24, 2020, 1:13 a.m. UTC 
BugLink: http://bugs.launchpad.net/bugs/1864398

[Impact]
In the ubuntu 20.04, we plan to integrate sof-firmware v1.4.2, the
topology of this version contains volume and led control, we need
to add this support in the sof driver, otherwise the sof will crash
when parsing the topology of v1.4.2.  After adding these patches,
the sof still coudl work with topology without volume and led control.

[Fix]
Backported the patches from mainline kernel v5.5-c1

[Test Case]
Install the sof-firmware v1.4.2
boot the kernel with these patches, sof driver initializes successfully,
and we could get a working sound card after booting up.

Install the sof-firmware v1.3.1
boot the kernel with these patches, sof driver initializes successfully,
and we could get a working sound card after booting up.

[Regression Risk]
Low, the patches are backported from upstream kernel, and I tested
this patch on Lenovo and Dell dmic machines.


Jaska Uimonen (3):
  ASoC: SOF: enable dual control for pga
  AsoC: SOF: refactor control load code
  ASoC: SOF: acpi led support for switch controls

Pierre-Louis Bossart (1):
  ASoC: SOF: topology: check errors when parsing LED tokens

 include/uapi/sound/sof/tokens.h |   4 +
 sound/soc/sof/control.c         |  32 +++
 sound/soc/sof/sof-priv.h        |   9 +
 sound/soc/sof/topology.c        | 338 +++++++++++++++++---------------
 4 files changed, 223 insertions(+), 160 deletions(-)

Comments

Seth Forshee Feb. 26, 2020, 2:38 a.m. UTC | #1 
On Mon, Feb 24, 2020 at 09:13:07AM +0800, Hui Wang wrote:
> BugLink: http://bugs.launchpad.net/bugs/1864398
> 
> [Impact]
> In the ubuntu 20.04, we plan to integrate sof-firmware v1.4.2, the
> topology of this version contains volume and led control, we need
> to add this support in the sof driver, otherwise the sof will crash
> when parsing the topology of v1.4.2.  After adding these patches,
> the sof still coudl work with topology without volume and led control.
> 
> [Fix]
> Backported the patches from mainline kernel v5.5-c1
> 
> [Test Case]
> Install the sof-firmware v1.4.2
> boot the kernel with these patches, sof driver initializes successfully,
> and we could get a working sound card after booting up.
> 
> Install the sof-firmware v1.3.1
> boot the kernel with these patches, sof driver initializes successfully,
> and we could get a working sound card after booting up.
> 
> [Regression Risk]
> Low, the patches are backported from upstream kernel, and I tested
> this patch on Lenovo and Dell dmic machines.

Applied to focal/master-next, thanks!