| Message ID | 20200210031341.14684-1-hui.wang@canonical.com |
|---|---|
| Headers | show |
| Series | volume control doesn't work (it's just on/off) on Lenovo ThinkPad X1 Carbon 7th gen | expand |
On Mon, Feb 10, 2020 at 11:13:39AM +0800, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1845677 > > The 1st patch is already in the oem-b-osp1 kernel, only needs to > merge the 2nd patch. > > For focal and eoan kernels, they need to merge 2 patches. > > For bionic and oem-b kernels, because they don't support sof driver > and these 2 machines are dmic machines, so no need to merge these 2 > patches. > > [Impact] > There are 2 physical speakers on the X1 7th, and one is Bass speaker > and connect to a DAC which doesn't have volume control on it. > > [Fix] > adjust that speaker to connect to a DAC which has volume control > capability. > > > [Test Case] > adjust the output volume from UI and play sound from speaker. > > > [Regression Risk] > Low, these change is specific to 2 lenovo machines. > > > Jaroslav Kysela (1): > ALSA: hda - fixup for the bass speaker on Lenovo Carbon X1 7th gen > > Kailang Yang (1): > ALSA: hda/realtek - Add quirk for the bass speaker on Lenovo Yoga X1 > 7th gen > > sound/pci/hda/patch_realtek.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > -- > 2.17.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team Acked-by: Sultan Alsawaf <sultan.alsawaf@canonical.com>
On 10.02.20 04:13, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1845677 > > The 1st patch is already in the oem-b-osp1 kernel, only needs to > merge the 2nd patch. > > For focal and eoan kernels, they need to merge 2 patches. > > For bionic and oem-b kernels, because they don't support sof driver > and these 2 machines are dmic machines, so no need to merge these 2 > patches. > > [Impact] > There are 2 physical speakers on the X1 7th, and one is Bass speaker > and connect to a DAC which doesn't have volume control on it. > > [Fix] > adjust that speaker to connect to a DAC which has volume control > capability. > > > [Test Case] > adjust the output volume from UI and play sound from speaker. > > > [Regression Risk] > Low, these change is specific to 2 lenovo machines. > > > Jaroslav Kysela (1): > ALSA: hda - fixup for the bass speaker on Lenovo Carbon X1 7th gen > > Kailang Yang (1): > ALSA: hda/realtek - Add quirk for the bass speaker on Lenovo Yoga X1 > 7th gen > > sound/pci/hda/patch_realtek.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > Clean cherry-picks. Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com> Hui, can you please fix the nominations on the bug report? Thank you.
On 2020/2/14 上午1:49, Kleber Souza wrote: > On 10.02.20 04:13, Hui Wang wrote: >> BugLink: https://bugs.launchpad.net/bugs/1845677 >> >> The 1st patch is already in the oem-b-osp1 kernel, only needs to >> merge the 2nd patch. >> >> For focal and eoan kernels, they need to merge 2 patches. >> >> For bionic and oem-b kernels, because they don't support sof driver >> and these 2 machines are dmic machines, so no need to merge these 2 >> patches. >> >> [Impact] >> There are 2 physical speakers on the X1 7th, and one is Bass speaker >> and connect to a DAC which doesn't have volume control on it. >> >> [Fix] >> adjust that speaker to connect to a DAC which has volume control >> capability. >> >> >> [Test Case] >> adjust the output volume from UI and play sound from speaker. >> >> >> [Regression Risk] >> Low, these change is specific to 2 lenovo machines. >> >> >> Jaroslav Kysela (1): >> ALSA: hda - fixup for the bass speaker on Lenovo Carbon X1 7th gen >> >> Kailang Yang (1): >> ALSA: hda/realtek - Add quirk for the bass speaker on Lenovo Yoga X1 >> 7th gen >> >> sound/pci/hda/patch_realtek.c | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> > Clean cherry-picks. > > Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com> > > > Hui, can you please fix the nominations on the bug report? Done. Thanks, Hui. > Thank you. >
On 14.02.20 01:41, Hui Wang wrote: > > On 2020/2/14 上午1:49, Kleber Souza wrote: >> On 10.02.20 04:13, Hui Wang wrote: >>> BugLink: https://bugs.launchpad.net/bugs/1845677 >>> >>> The 1st patch is already in the oem-b-osp1 kernel, only needs to >>> merge the 2nd patch. >>> >>> For focal and eoan kernels, they need to merge 2 patches. >>> >>> For bionic and oem-b kernels, because they don't support sof driver >>> and these 2 machines are dmic machines, so no need to merge these 2 >>> patches. >>> >>> [Impact] >>> There are 2 physical speakers on the X1 7th, and one is Bass speaker >>> and connect to a DAC which doesn't have volume control on it. >>> >>> [Fix] >>> adjust that speaker to connect to a DAC which has volume control >>> capability. >>> >>> >>> [Test Case] >>> adjust the output volume from UI and play sound from speaker. >>> >>> >>> [Regression Risk] >>> Low, these change is specific to 2 lenovo machines. >>> >>> >>> Jaroslav Kysela (1): >>> ALSA: hda - fixup for the bass speaker on Lenovo Carbon X1 7th gen >>> >>> Kailang Yang (1): >>> ALSA: hda/realtek - Add quirk for the bass speaker on Lenovo Yoga X1 >>> 7th gen >>> >>> sound/pci/hda/patch_realtek.c | 18 ++++++++++++++++++ >>> 1 file changed, 18 insertions(+) >>> >> Clean cherry-picks. >> >> Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com> >> >> >> Hui, can you please fix the nominations on the bug report? > > Done. > > Thanks, > > Hui. Hi Hui, By nominations we mean setting which packages are affected and target them to the relevant series. I have done that now based on the tags on the subject of this patch. Thanks, Kleber
On 10.02.20 04:13, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1845677 > > The 1st patch is already in the oem-b-osp1 kernel, only needs to > merge the 2nd patch. > > For focal and eoan kernels, they need to merge 2 patches. > > For bionic and oem-b kernels, because they don't support sof driver > and these 2 machines are dmic machines, so no need to merge these 2 > patches. > > [Impact] > There are 2 physical speakers on the X1 7th, and one is Bass speaker > and connect to a DAC which doesn't have volume control on it. > > [Fix] > adjust that speaker to connect to a DAC which has volume control > capability. > > > [Test Case] > adjust the output volume from UI and play sound from speaker. > > > [Regression Risk] > Low, these change is specific to 2 lenovo machines. > > > Jaroslav Kysela (1): > ALSA: hda - fixup for the bass speaker on Lenovo Carbon X1 7th gen > > Kailang Yang (1): > ALSA: hda/realtek - Add quirk for the bass speaker on Lenovo Yoga X1 > 7th gen > > sound/pci/hda/patch_realtek.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > These patches have been applied as part of EOAN upstream stable updates (LP: #1861710 and LP: #1862227) and I'm NAK'ing it for Eoan. Thanks, Kleber
On Mon, Feb 10, 2020 at 11:13:39AM +0800, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1845677 > > The 1st patch is already in the oem-b-osp1 kernel, only needs to > merge the 2nd patch. > > For focal and eoan kernels, they need to merge 2 patches. > > For bionic and oem-b kernels, because they don't support sof driver > and these 2 machines are dmic machines, so no need to merge these 2 > patches. > > [Impact] > There are 2 physical speakers on the X1 7th, and one is Bass speaker > and connect to a DAC which doesn't have volume control on it. > > [Fix] > adjust that speaker to connect to a DAC which has volume control > capability. > > > [Test Case] > adjust the output volume from UI and play sound from speaker. > > > [Regression Risk] > Low, these change is specific to 2 lenovo machines. > > > Jaroslav Kysela (1): > ALSA: hda - fixup for the bass speaker on Lenovo Carbon X1 7th gen > > Kailang Yang (1): > ALSA: hda/realtek - Add quirk for the bass speaker on Lenovo Yoga X1 > 7th gen Both patches were applied as part of Focal upstream stable updates(LP: #1860125 and LP: #1860131), so i'm NAK'ing this for Focal.
On 2020/2/18 下午6:48, Paolo Pisati wrote: > On Mon, Feb 10, 2020 at 11:13:39AM +0800, Hui Wang wrote: >> BugLink: https://bugs.launchpad.net/bugs/1845677 >> >> The 1st patch is already in the oem-b-osp1 kernel, only needs to >> merge the 2nd patch. >> >> For focal and eoan kernels, they need to merge 2 patches. >> >> For bionic and oem-b kernels, because they don't support sof driver >> and these 2 machines are dmic machines, so no need to merge these 2 >> patches. >> >> [Impact] >> There are 2 physical speakers on the X1 7th, and one is Bass speaker >> and connect to a DAC which doesn't have volume control on it. >> >> [Fix] >> adjust that speaker to connect to a DAC which has volume control >> capability. >> >> >> [Test Case] >> adjust the output volume from UI and play sound from speaker. >> >> >> [Regression Risk] >> Low, these change is specific to 2 lenovo machines. >> >> >> Jaroslav Kysela (1): >> ALSA: hda - fixup for the bass speaker on Lenovo Carbon X1 7th gen >> >> Kailang Yang (1): >> ALSA: hda/realtek - Add quirk for the bass speaker on Lenovo Yoga X1 >> 7th gen > Both patches were applied as part of Focal upstream stable updates(LP: #1860125 > and LP: #1860131), so i'm NAK'ing this for Focal. OK, got it.
On 10.2.2020 5.13, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1845677 > > The 1st patch is already in the oem-b-osp1 kernel, only needs to > merge the 2nd patch. > > For focal and eoan kernels, they need to merge 2 patches. > > For bionic and oem-b kernels, because they don't support sof driver > and these 2 machines are dmic machines, so no need to merge these 2 > patches. > > [Impact] > There are 2 physical speakers on the X1 7th, and one is Bass speaker > and connect to a DAC which doesn't have volume control on it. > > [Fix] > adjust that speaker to connect to a DAC which has volume control > capability. > > > [Test Case] > adjust the output volume from UI and play sound from speaker. > > > [Regression Risk] > Low, these change is specific to 2 lenovo machines. > > > Jaroslav Kysela (1): > ALSA: hda - fixup for the bass speaker on Lenovo Carbon X1 7th gen > > Kailang Yang (1): > ALSA: hda/realtek - Add quirk for the bass speaker on Lenovo Yoga X1 > 7th gen > > sound/pci/hda/patch_realtek.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > already applied to osp1 via upstream stable https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1862059
BugLink: https://bugs.launchpad.net/bugs/1845677 The 1st patch is already in the oem-b-osp1 kernel, only needs to merge the 2nd patch. For focal and eoan kernels, they need to merge 2 patches. For bionic and oem-b kernels, because they don't support sof driver and these 2 machines are dmic machines, so no need to merge these 2 patches. [Impact] There are 2 physical speakers on the X1 7th, and one is Bass speaker and connect to a DAC which doesn't have volume control on it. [Fix] adjust that speaker to connect to a DAC which has volume control capability. [Test Case] adjust the output volume from UI and play sound from speaker. [Regression Risk] Low, these change is specific to 2 lenovo machines. Jaroslav Kysela (1): ALSA: hda - fixup for the bass speaker on Lenovo Carbon X1 7th gen Kailang Yang (1): ALSA: hda/realtek - Add quirk for the bass speaker on Lenovo Yoga X1 7th gen sound/pci/hda/patch_realtek.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)