mbox series

[SRU,D/OEM-B-OSP1/E/unstable,0/2] drm/i915: Fix the issue of "azx_get_response timeout" for hdmi audio on ICL platforms

Message ID 20191008115552.10791-1-hui.wang@canonical.com
Headers show
Series drm/i915: Fix the issue of "azx_get_response timeout" for hdmi audio on ICL platforms | expand

Message

Hui Wang Oct. 8, 2019, 11:55 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1847192

Since Bionic kernel doesn't support ICL platforms (i915), so these two
patches will not be sent to Bionic kernel.

[Impact]
On the ICL platforms, the hdmi can't work well, the audio driver
will print "azx_get_response timeout" randomly, then the whole
audio doesn't work anymore.

[Fix]
Intel provide these two fixes to us, and we tested these two
patches, it really fixed the issue.

[Test Case]
Boot and check the hdmi audio, then suspend and resume, check
the hdmi audio, all work well.

[Regression Risk]
Low, Only enable the audio PIN and enable the clock for ICL. we
tested on both ICL and non-ICL, all worked well as before.


Kai Vehmanen (2):
  UBUNTU: SAUCE: drm/i915: Fix audio power up sequence for gen10+
    display
  UBUNTU: SAUCE: drm/i915: extend audio CDCLK>=2*BCLK constraint to more
    platforms

 drivers/gpu/drm/i915/i915_reg.h    |  3 +++
 drivers/gpu/drm/i915/intel_audio.c | 11 ++++++++---
 2 files changed, 11 insertions(+), 3 deletions(-)

Comments

Stefan Bader Oct. 9, 2019, 7:26 a.m. UTC | #1
On 08.10.19 13:55, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1847192
> 
> Since Bionic kernel doesn't support ICL platforms (i915), so these two
> patches will not be sent to Bionic kernel.
> 
> [Impact]
> On the ICL platforms, the hdmi can't work well, the audio driver
> will print "azx_get_response timeout" randomly, then the whole
> audio doesn't work anymore.
> 
> [Fix]
> Intel provide these two fixes to us, and we tested these two
> patches, it really fixed the issue.
> 
> [Test Case]
> Boot and check the hdmi audio, then suspend and resume, check
> the hdmi audio, all work well.
> 
> [Regression Risk]
> Low, Only enable the audio PIN and enable the clock for ICL. we
> tested on both ICL and non-ICL, all worked well as before.
> 
> 
> Kai Vehmanen (2):
>   UBUNTU: SAUCE: drm/i915: Fix audio power up sequence for gen10+
>     display
>   UBUNTU: SAUCE: drm/i915: extend audio CDCLK>=2*BCLK constraint to more
>     platforms
> 
>  drivers/gpu/drm/i915/i915_reg.h    |  3 +++
>  drivers/gpu/drm/i915/intel_audio.c | 11 ++++++++---
>  2 files changed, 11 insertions(+), 3 deletions(-)
> 
Both changes are closely related and mostly (with additional explanation that
Canonlake is gen 10) replacements without real change. Only the additional part
which is as described.


Acked-by: Stefan Bader <stefan.bader@canonical.com>
Hui Wang Oct. 9, 2019, 7:52 a.m. UTC | #2
On 2019/10/9 下午3:26, Stefan Bader wrote:
> On 08.10.19 13:55, Hui Wang wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1847192
>>
>> Since Bionic kernel doesn't support ICL platforms (i915), so these two
>> patches will not be sent to Bionic kernel.
>>
>> [Impact]
>> On the ICL platforms, the hdmi can't work well, the audio driver
>> will print "azx_get_response timeout" randomly, then the whole
>> audio doesn't work anymore.
>>
>> [Fix]
>> Intel provide these two fixes to us, and we tested these two
>> patches, it really fixed the issue.
>>
>> [Test Case]
>> Boot and check the hdmi audio, then suspend and resume, check
>> the hdmi audio, all work well.
>>
>> [Regression Risk]
>> Low, Only enable the audio PIN and enable the clock for ICL. we
>> tested on both ICL and non-ICL, all worked well as before.
>>
>>
>> Kai Vehmanen (2):
>>    UBUNTU: SAUCE: drm/i915: Fix audio power up sequence for gen10+
>>      display
>>    UBUNTU: SAUCE: drm/i915: extend audio CDCLK>=2*BCLK constraint to more
>>      platforms
>>
>>   drivers/gpu/drm/i915/i915_reg.h    |  3 +++
>>   drivers/gpu/drm/i915/intel_audio.c | 11 ++++++++---
>>   2 files changed, 11 insertions(+), 3 deletions(-)
>>
> Both changes are closely related and mostly (with additional explanation that
> Canonlake is gen 10) replacements without real change. Only the additional part
> which is as described.
>
>
> Acked-by: Stefan Bader <stefan.bader@canonical.com>
Sorry, I need to resend the patches for V2, since these patches will not 
be applied to Disco.
>
Hui Wang Oct. 9, 2019, 7:53 a.m. UTC | #3
Will resend the patches for V2, in the V2, the Disco will be dropped.

On 2019/10/8 下午7:55, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1847192
>
> Since Bionic kernel doesn't support ICL platforms (i915), so these two
> patches will not be sent to Bionic kernel.
>
> [Impact]
> On the ICL platforms, the hdmi can't work well, the audio driver
> will print "azx_get_response timeout" randomly, then the whole
> audio doesn't work anymore.
>
> [Fix]
> Intel provide these two fixes to us, and we tested these two
> patches, it really fixed the issue.
>
> [Test Case]
> Boot and check the hdmi audio, then suspend and resume, check
> the hdmi audio, all work well.
>
> [Regression Risk]
> Low, Only enable the audio PIN and enable the clock for ICL. we
> tested on both ICL and non-ICL, all worked well as before.
>
>
> Kai Vehmanen (2):
>    UBUNTU: SAUCE: drm/i915: Fix audio power up sequence for gen10+
>      display
>    UBUNTU: SAUCE: drm/i915: extend audio CDCLK>=2*BCLK constraint to more
>      platforms
>
>   drivers/gpu/drm/i915/i915_reg.h    |  3 +++
>   drivers/gpu/drm/i915/intel_audio.c | 11 ++++++++---
>   2 files changed, 11 insertions(+), 3 deletions(-)
>