From patchwork Wed Sep 25 08:07:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juerg Haefliger X-Patchwork-Id: 1167034 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46dW0S1S1lz9sPf; Wed, 25 Sep 2019 18:08:38 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1iD2Lh-0000UY-PD; Wed, 25 Sep 2019 08:08:33 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iD2Lf-0000Tv-65 for kernel-team@lists.ubuntu.com; Wed, 25 Sep 2019 08:08:31 +0000 Received: from mail-wm1-f72.google.com ([209.85.128.72]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iD2Lf-0003LB-0s for kernel-team@lists.ubuntu.com; Wed, 25 Sep 2019 08:08:31 +0000 Received: by mail-wm1-f72.google.com with SMTP id l3so1617402wmf.8 for ; Wed, 25 Sep 2019 01:08:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=rk6/EUJLi0BfHolfer1kmznNIvzzP1mW2+WVWWntMEM=; b=dF0Hx+nC0Bezcym+EQhKYuj8p+vFclCJ1zvDYrXIQLbCAH4jhSHodF1EaQ4Dzeeree b7Yr8xc/Ydici8dGbDn17aSBzYZDEj6ttN2++pyyFBWlPtam2ZmcEhf/kBNAN9PiHAH/ 56pmh0ioRLwquvelvUfE/POxAZCy+QMEtYkc7t1udqFFYVZmTKsdd7hcea1rqIFjTejW ZBNgwcwm/YvIma+Y5/ye/I1hwI3Jk1/MZVxUhvkYUXF9ETt+VWcLC2BtpLjNBR0eXoaJ idA1y/m6VgiMzXHq5J8eUQLvliysJ4739Lv2iIkVY851Dqm6MQlanx5/niBoBqYaXBX4 Snow== X-Gm-Message-State: APjAAAWop9pUffRS0d3HSEyv4BQLHMWMV0zEiV25Vw2FaWfrTWL5E0PG efVgouA7cPPktZo4vLs6bYRP0JD24wkHxGFq8n+MDbfKwQiqj8J/JPhncQGijpzrF7z6ZF3AjRq ahNBupjcqFDqk6JiVkrOWlQp4c6z3bIqKEuwZXRJ8LA== X-Received: by 2002:adf:828d:: with SMTP id 13mr7904223wrc.115.1569398910283; Wed, 25 Sep 2019 01:08:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqzPED2cdZAdR3V3Fwe3xKw+vDaBo8BZgUGGV9a4pSSVT99KDKKhUaPCVWxKHoThEmsf/dBIdA== X-Received: by 2002:adf:828d:: with SMTP id 13mr7903846wrc.115.1569398906315; Wed, 25 Sep 2019 01:08:26 -0700 (PDT) Received: from localhost.localdomain ([194.191.228.147]) by smtp.gmail.com with ESMTPSA id e44sm856507ede.34.2019.09.25.01.08.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2019 01:08:25 -0700 (PDT) From: Juerg Haefliger X-Google-Original-From: Juerg Haefliger To: kernel-team@lists.ubuntu.com Subject: [SRU][Bionic][PATCH 0/5] TC filters are broken on Mellanox after upstream stable updates (LP: #1842502) Date: Wed, 25 Sep 2019 10:07:47 +0200 Message-Id: <20190925080752.10996-1-juergh@canonical.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" [Impact] Mellanox TC filters don't work for some key rules after the Bionic 4.15 stable patchset 2019-07-12 update (LP: #1836426). The offending commit is ("net/mlx5e: Set vlan masks for all offloaded TC rules"). This causes fatal network connectivity issues for projects that use the Mellanox ConnectX 5 NIC. [Test Case] TBD. [Fix] Backport the following upstream commit (which fixes the offending commit) and its prerequisites: d3a80bb5a3ea ("net/mlx5e: Don't match on vlan non-existence if ethertype is wildcarded") [Regression Potential] Low. Changes are isolated and limited to the mlx5_core driver and all commits are in upstream stable v4.19.y. [Original description] The following upstream fix was missing from the latest upstream stable update (LP: # and LP1839376: #1839213): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d3a80bb5a3eac311ddf28387402593977574460d Or Gerlitz (4): net/mlx5e: Properly order min inline mode setup while parsing TC matches net/mlx5e: Get the required HW match level while parsing TC flow matches net/mlx5e: Always use the match level enum when parsing TC rule match net/mlx5e: Don't match on vlan non-existence if ethertype is wildcarded Saeed Mahameed (1): net/mlx5e: Remove redundant vport context vlan update .../net/ethernet/mellanox/mlx5/core/en_fs.c | 1 - .../net/ethernet/mellanox/mlx5/core/en_tc.c | 146 ++++++++++-------- .../net/ethernet/mellanox/mlx5/core/eswitch.h | 7 + 3 files changed, 92 insertions(+), 62 deletions(-) Acked-by: Sultan Alsawaf Acked-by: Connor Kuehl