| Message ID | 20190813100856.4232-1-hui.wang@canonical.com |
|---|---|
| Headers | show |
| Series | drm/i915: revert the patch of "set disable_power_well=0 for icl temporarily" | expand |
On Tue, Aug 13, 2019 at 06:08:55PM +0800, Hui Wang wrote: > BugLink: http://bugs.launchpad.net/bugs/1839950 > > [Impact] > Two weeks ago, we sent the patch to set disable_power_well=0, this is > because we found sometimes the hdmi audio driver printed out the timeout > errors when accessing the codec. But recently the ODM told us those > machines had some HW or BIOS issues, we can't reproduce the timeout > errors on the new machines anymore even without this patch. And moreover > we need put the CPU into PC10 power state to meet the E-star starndard, > we need to revert this patch. > > [Fix] > Revert the patch. > > [Test Case] > Tested on the new icl laptops, we have not reproduce the timeout errors, > and The PC can enter PC10. > > [Regression Risk] > Low. We have done many tests. > > > Hui Wang (1): > Revert "UBUNTU: SAUCE: i915: set disable_power_well=0 for icl > temporarily" > > drivers/gpu/drm/i915/intel_runtime_pm.c | 5 ----- > 1 file changed, 5 deletions(-) > Acked-by: Anthony Wong <anthony.wong@canonical.com>
On 13.8.2019 13.08, Hui Wang wrote: > BugLink: http://bugs.launchpad.net/bugs/1839950 > > [Impact] > Two weeks ago, we sent the patch to set disable_power_well=0, this is > because we found sometimes the hdmi audio driver printed out the timeout > errors when accessing the codec. But recently the ODM told us those > machines had some HW or BIOS issues, we can't reproduce the timeout > errors on the new machines anymore even without this patch. And moreover > we need put the CPU into PC10 power state to meet the E-star starndard, > we need to revert this patch. > > [Fix] > Revert the patch. > > [Test Case] > Tested on the new icl laptops, we have not reproduce the timeout errors, > and The PC can enter PC10. > > [Regression Risk] > Low. We have done many tests. > > > Hui Wang (1): > Revert "UBUNTU: SAUCE: i915: set disable_power_well=0 for icl > temporarily" > > drivers/gpu/drm/i915/intel_runtime_pm.c | 5 ----- > 1 file changed, 5 deletions(-) > apparently the workaround is still needed
Timo & Acelan, Don't forget to merge this one to osp1 if it is possible. On 2019/8/13 下午6:08, Hui Wang wrote: > BugLink: http://bugs.launchpad.net/bugs/1839950 > > [Impact] > Two weeks ago, we sent the patch to set disable_power_well=0, this is > because we found sometimes the hdmi audio driver printed out the timeout > errors when accessing the codec. But recently the ODM told us those > machines had some HW or BIOS issues, we can't reproduce the timeout > errors on the new machines anymore even without this patch. And moreover > we need put the CPU into PC10 power state to meet the E-star starndard, > we need to revert this patch. > > [Fix] > Revert the patch. > > [Test Case] > Tested on the new icl laptops, we have not reproduce the timeout errors, > and The PC can enter PC10. > > [Regression Risk] > Low. We have done many tests. > > > Hui Wang (1): > Revert "UBUNTU: SAUCE: i915: set disable_power_well=0 for icl > temporarily" > > drivers/gpu/drm/i915/intel_runtime_pm.c | 5 ----- > 1 file changed, 5 deletions(-) >
On 10.10.2019 3.55, Hui Wang wrote: > Timo & Acelan, > > Don't forget to merge this one to osp1 if it is possible. You need to resend it, this was NAKed seven weeks ago.
OK, will resend it. thx. On 2019/10/10 上午11:40, Timo Aaltonen wrote: > On 10.10.2019 3.55, Hui Wang wrote: >> Timo & Acelan, >> >> Don't forget to merge this one to osp1 if it is possible. > You need to resend it, this was NAKed seven weeks ago. > >
BugLink: http://bugs.launchpad.net/bugs/1839950 [Impact] Two weeks ago, we sent the patch to set disable_power_well=0, this is because we found sometimes the hdmi audio driver printed out the timeout errors when accessing the codec. But recently the ODM told us those machines had some HW or BIOS issues, we can't reproduce the timeout errors on the new machines anymore even without this patch. And moreover we need put the CPU into PC10 power state to meet the E-star starndard, we need to revert this patch. [Fix] Revert the patch. [Test Case] Tested on the new icl laptops, we have not reproduce the timeout errors, and The PC can enter PC10. [Regression Risk] Low. We have done many tests. Hui Wang (1): Revert "UBUNTU: SAUCE: i915: set disable_power_well=0 for icl temporarily" drivers/gpu/drm/i915/intel_runtime_pm.c | 5 ----- 1 file changed, 5 deletions(-)