| Message ID | 20190719143917.11230-1-hui.wang@canonical.com |
|---|---|
| Headers | show |
| Series | input/mouse: alps trackpoint-only device doesn't work | expand |
On Fri, Jul 19, 2019 at 10:39:15PM +0800, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1836752 > > In the V2: > I added one more patch (0002) to fix the problem of condition checking > of 0x20~0x2f (apw found this problem in the v1) > > Since the OEM-OSP1-B already merged 0001, it only needs to merge 0002 > this time, for the rest of kernel version, need to merge 0001 and 0002. > > [Impact] > On one of the latest Lenovo laptops, the trackpoint doesn't work, we > consulted apls guys, they said this trackpoint is different from others, > it is a trackpoint-only device, so the current alps.c doesn't support it > well, while the trackpoint.c can drive it well. > > [Fix] > Check if it is trakcpoint-only device, if it yes, let trackpoint.c > handle it. > > [Test Case] > apply this patch and boot with the kernel, the trackpoint can work > well. > > [Regression Risk] > Low. the way of detect trackpoint-only alps device is provided by > alps. so it is pretty safe. and I have tested the patch on two > lenovo machines with alsp touchpad+trackpoint device, they worked > well. Patches from a maintainer tree are sauce patches. With the commit description fixed to reflect this: Acked-by: Seth Forshee <seth.forshee@canonical.com> Applied to eoan/master-next, with the subject changed to add "UBUNTU: SAUCE:", thanks!
On 19.07.19 16:39, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1836752 > > In the V2: > I added one more patch (0002) to fix the problem of condition checking > of 0x20~0x2f (apw found this problem in the v1) > > Since the OEM-OSP1-B already merged 0001, it only needs to merge 0002 > this time, for the rest of kernel version, need to merge 0001 and 0002. > > [Impact] > On one of the latest Lenovo laptops, the trackpoint doesn't work, we > consulted apls guys, they said this trackpoint is different from others, > it is a trackpoint-only device, so the current alps.c doesn't support it > well, while the trackpoint.c can drive it well. > > [Fix] > Check if it is trakcpoint-only device, if it yes, let trackpoint.c > handle it. > > [Test Case] > apply this patch and boot with the kernel, the trackpoint can work > well. > > [Regression Risk] > Low. the way of detect trackpoint-only alps device is provided by > alps. so it is pretty safe. and I have tested the patch on two > lenovo machines with alsp touchpad+trackpoint device, they worked > well. > > > Hui Wang (2): commit 7e4935ccc3236751e5fe4bd6846f86e46bb2e427 > Input: alps - don't handle ALPS cs19 trackpoint-only device commit 771a081e44a9baa1991ef011cc453ef425591740 > Input: alps - fix a mismatch between a condition check and its comment > Patches are now upstream, so with updated sha1 reference: Acked-by: Stefan Bader <stefan.bader@canonical.com> > drivers/input/mouse/alps.c | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) >
Applied to Disco only, after updating the SHA references as Stefan said. Bug wasn't targeted for D so I targeted it. Both patches were already present in Bionic via stable-updates, so marking the thread as applied to B as well. On 2019-07-19 22:39:15 , Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1836752 > > In the V2: > I added one more patch (0002) to fix the problem of condition checking > of 0x20~0x2f (apw found this problem in the v1) > > Since the OEM-OSP1-B already merged 0001, it only needs to merge 0002 > this time, for the rest of kernel version, need to merge 0001 and 0002. > > [Impact] > On one of the latest Lenovo laptops, the trackpoint doesn't work, we > consulted apls guys, they said this trackpoint is different from others, > it is a trackpoint-only device, so the current alps.c doesn't support it > well, while the trackpoint.c can drive it well. > > [Fix] > Check if it is trakcpoint-only device, if it yes, let trackpoint.c > handle it. > > [Test Case] > apply this patch and boot with the kernel, the trackpoint can work > well. > > [Regression Risk] > Low. the way of detect trackpoint-only alps device is provided by > alps. so it is pretty safe. and I have tested the patch on two > lenovo machines with alsp touchpad+trackpoint device, they worked > well. > > > Hui Wang (2): > Input: alps - don't handle ALPS cs19 trackpoint-only device > Input: alps - fix a mismatch between a condition check and its comment > > drivers/input/mouse/alps.c | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > -- > 2.17.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team