mbox series

[SRU,B/OEM-B/C/D,0/2] Eletrical noise occurred when externalheadset enter powersaving mode on a DEll machine

Message ID 20190513114814.14838-1-hui.wang@canonical.com
Headers show
Series Eletrical noise occurred when externalheadset enter powersaving mode on a DEll machine | expand

Message

Hui Wang May 13, 2019, 11:48 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1828798

[Impact]
Eletrical noise occurred when external headset enter powersaving mode (around 7 seconds)

[Fix]
Don't clear pinctl when runtime suspend.

[Test Case]
Plug headset and wait for the codec to enter runtime suspend, there is no any noise from headphone.

[Regression Risk]
Low. the 1st patch is specific to a Dell machine and the 2nd patch is specific to the machine with the codec alc298


Kailang Yang (1):
  ALSA: hda/realtek - Fixup headphone noise via runtime suspend

Takashi Iwai (1):
  ALSA: hda/realtek - Reduce click noise on Dell Precision 5820
    headphone

 sound/pci/hda/patch_realtek.c | 107 ++++++++++++++++++++--------------
 1 file changed, 64 insertions(+), 43 deletions(-)

Comments

AceLan Kao May 19, 2019, 6:40 a.m. UTC | #1
Applied on Ubuntu-oem-4.15.0-1039.44

Acked-By: AceLan Kao <acelan.kao@canonical.com>
Stefan Bader May 29, 2019, 2:26 p.m. UTC | #2
On 13.05.19 13:48, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1828798
> 
> [Impact]
> Eletrical noise occurred when external headset enter powersaving mode (around 7 seconds)
> 
> [Fix]
> Don't clear pinctl when runtime suspend.
> 
> [Test Case]
> Plug headset and wait for the codec to enter runtime suspend, there is no any noise from headphone.
> 
> [Regression Risk]
> Low. the 1st patch is specific to a Dell machine and the 2nd patch is specific to the machine with the codec alc298
> 
> 
> Kailang Yang (1):
>   ALSA: hda/realtek - Fixup headphone noise via runtime suspend
> 
> Takashi Iwai (1):
>   ALSA: hda/realtek - Reduce click noise on Dell Precision 5820
>     headphone
> 
>  sound/pci/hda/patch_realtek.c | 107 ++++++++++++++++++++--------------
>  1 file changed, 64 insertions(+), 43 deletions(-)
> 
The patch "ALSA: hda/realtek - Fixup headphone noise via runtime suspend" now is
upstream with the same SHA1. So can be adjusted when applying.

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Kleber Sacilotto de Souza June 3, 2019, 2:25 p.m. UTC | #3
On 5/13/19 1:48 PM, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1828798
> 
> [Impact]
> Eletrical noise occurred when external headset enter powersaving mode (around 7 seconds)
> 
> [Fix]
> Don't clear pinctl when runtime suspend.
> 
> [Test Case]
> Plug headset and wait for the codec to enter runtime suspend, there is no any noise from headphone.
> 
> [Regression Risk]
> Low. the 1st patch is specific to a Dell machine and the 2nd patch is specific to the machine with the codec alc298
> 
> 
> Kailang Yang (1):
>   ALSA: hda/realtek - Fixup headphone noise via runtime suspend
> 
> Takashi Iwai (1):
>   ALSA: hda/realtek - Reduce click noise on Dell Precision 5820
>     headphone
> 
>  sound/pci/hda/patch_realtek.c | 107 ++++++++++++++++++++--------------
>  1 file changed, 64 insertions(+), 43 deletions(-)
> 

Applied to {bionic,cosmic,disco}/master-next branches, changing
patch "ALSA: hda/realtek - Fixup headphone noise via runtime suspend"
to remove the url from the provenance as pointed out by Stefan.

Thanks,
Kleber