| Message ID | 20180530093539.11917-1-juergh@canonical.com |
|---|---|
| Headers | show |
| Series | rfi-flush: Switch to new linear fallback flush (LP #1744173) | expand |
Ping. Can I get a second review, please? On 05/30/2018 11:35 AM, Juerg Haefliger wrote: > BugLink: https://bugs.launchpad.net/bugs/1744173 > > [Impact] > Change flush method from "congruence-first with dependencies" to "linear with no dependencies", which increases flush performance by 8x on P8, and > 3x on P9. Measured with null syscall loop, which will have the flush area in the L2 cache. > > The flush also becomes simpler and more adaptable to different cache > geometries. > > [Test Case] > TBD. > > [Regression Potential] > The risk is deemed low since the changes are confined to POWER only and the provided test kernels have been tested by IBM. > > Signed-off-by: Juerg Haefliger <juergh@canonical.com> > > > Michael Ellerman (1): > UBUNTU: SAUCE: rfi-flush: Make it possible to call setup_rfi_flush() > again > > Nicholas Piggin (1): > powerpc/64s: Improve RFI L1-D cache flush fallback > > arch/powerpc/include/asm/paca.h | 3 +- > arch/powerpc/kernel/asm-offsets.c | 3 +- > arch/powerpc/kernel/exceptions-64s.S | 76 +++++++++++++--------------- > arch/powerpc/kernel/setup_64.c | 35 +++++++------ > 4 files changed, 57 insertions(+), 60 deletions(-) >
On 2018-05-30 11:35:37 , Juerg Haefliger wrote: > BugLink: https://bugs.launchpad.net/bugs/1744173 > > [Impact] > Change flush method from "congruence-first with dependencies" to "linear with no dependencies", which increases flush performance by 8x on P8, and > 3x on P9. Measured with null syscall loop, which will have the flush area in the L2 cache. > > The flush also becomes simpler and more adaptable to different cache > geometries. > > [Test Case] > TBD. > > [Regression Potential] > The risk is deemed low since the changes are confined to POWER only and the provided test kernels have been tested by IBM. > > Signed-off-by: Juerg Haefliger <juergh@canonical.com> > > > Michael Ellerman (1): > UBUNTU: SAUCE: rfi-flush: Make it possible to call setup_rfi_flush() > again > > Nicholas Piggin (1): > powerpc/64s: Improve RFI L1-D cache flush fallback > > arch/powerpc/include/asm/paca.h | 3 +- > arch/powerpc/kernel/asm-offsets.c | 3 +- > arch/powerpc/kernel/exceptions-64s.S | 76 +++++++++++++--------------- > arch/powerpc/kernel/setup_64.c | 35 +++++++------ > 4 files changed, 57 insertions(+), 60 deletions(-) > Acked-by: Khalid Elmously <khalid.elmously@canonical.com>
Applied to xenial/master-next. ...Juerg On 05/30/2018 11:35 AM, Juerg Haefliger wrote: > BugLink: https://bugs.launchpad.net/bugs/1744173 > > [Impact] > Change flush method from "congruence-first with dependencies" to "linear with no dependencies", which increases flush performance by 8x on P8, and > 3x on P9. Measured with null syscall loop, which will have the flush area in the L2 cache. > > The flush also becomes simpler and more adaptable to different cache > geometries. > > [Test Case] > TBD. > > [Regression Potential] > The risk is deemed low since the changes are confined to POWER only and the provided test kernels have been tested by IBM. > > Signed-off-by: Juerg Haefliger <juergh@canonical.com> > > > Michael Ellerman (1): > UBUNTU: SAUCE: rfi-flush: Make it possible to call setup_rfi_flush() > again > > Nicholas Piggin (1): > powerpc/64s: Improve RFI L1-D cache flush fallback > > arch/powerpc/include/asm/paca.h | 3 +- > arch/powerpc/kernel/asm-offsets.c | 3 +- > arch/powerpc/kernel/exceptions-64s.S | 76 +++++++++++++--------------- > arch/powerpc/kernel/setup_64.c | 35 +++++++------ > 4 files changed, 57 insertions(+), 60 deletions(-) >
BugLink: https://bugs.launchpad.net/bugs/1744173 [Impact] Change flush method from "congruence-first with dependencies" to "linear with no dependencies", which increases flush performance by 8x on P8, and 3x on P9. Measured with null syscall loop, which will have the flush area in the L2 cache. The flush also becomes simpler and more adaptable to different cache geometries. [Test Case] TBD. [Regression Potential] The risk is deemed low since the changes are confined to POWER only and the provided test kernels have been tested by IBM. Signed-off-by: Juerg Haefliger <juergh@canonical.com> Michael Ellerman (1): UBUNTU: SAUCE: rfi-flush: Make it possible to call setup_rfi_flush() again Nicholas Piggin (1): powerpc/64s: Improve RFI L1-D cache flush fallback arch/powerpc/include/asm/paca.h | 3 +- arch/powerpc/kernel/asm-offsets.c | 3 +- arch/powerpc/kernel/exceptions-64s.S | 76 +++++++++++++--------------- arch/powerpc/kernel/setup_64.c | 35 +++++++------ 4 files changed, 57 insertions(+), 60 deletions(-)