mbox series

[SRU,Xenial,00/11] i915_bpo: Fix flickering issue after panel change

Message ID 20180511062101.27495-1-tjaalton@ubuntu.com
Headers show
Series i915_bpo: Fix flickering issue after panel change | expand

Message

Timo Aaltonen May 11, 2018, 6:20 a.m. UTC
BugLink: http://bugs.launchpad.net/bugs/1770565

This set of patches fixes flickering issues on a machine that changed the panel
vendor after it was certified.


Rodrigo Vivi (1):
  drm/i915: KBL - Recommended buffer translation programming for
    DisplayPort

Ville Syrjälä (10):
  drm/i915: Fix iboost setting for DDI with 4 lanes on SKL
  drm/i915: Name the "iboost bit"
  drm/i915: Program iboost settings for HDMI/DVI on SKL
  drm/i915: Move bxt_ddi_vswing_sequence() call into
    intel_ddi_pre_enable() for HDMI
  drm/i915: Explicitly use ddi buf trans entry 9 for hdmi
  drm/i915: Split DP/eDP/FDI and HDMI/DVI DDI buffer programming apart
  drm/i915: Get the iboost setting based on the port type
  drm/i915: Simplify intel_ddi_get_encoder_port()
  drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation
    entry 2
  drm/i915: Ignore OpRegion panel type except on select machines

 ubuntu/i915/i915_reg.h       |   2 +
 ubuntu/i915/intel_ddi.c      | 308 +++++++++++++++++++++++------------
 ubuntu/i915/intel_dp_mst.c   |   4 +-
 ubuntu/i915/intel_drv.h      |   2 +-
 ubuntu/i915/intel_opregion.c |  27 +++
 5 files changed, 234 insertions(+), 109 deletions(-)

Comments

Kleber Sacilotto de Souza May 14, 2018, 4:18 p.m. UTC | #1
On 05/11/18 08:20, Timo Aaltonen wrote:
> BugLink: http://bugs.launchpad.net/bugs/1770565
> 
> This set of patches fixes flickering issues on a machine that changed the panel
> vendor after it was certified.
> 
> 
> Rodrigo Vivi (1):
>   drm/i915: KBL - Recommended buffer translation programming for
>     DisplayPort
> 
> Ville Syrjälä (10):
>   drm/i915: Fix iboost setting for DDI with 4 lanes on SKL
>   drm/i915: Name the "iboost bit"
>   drm/i915: Program iboost settings for HDMI/DVI on SKL
>   drm/i915: Move bxt_ddi_vswing_sequence() call into
>     intel_ddi_pre_enable() for HDMI
>   drm/i915: Explicitly use ddi buf trans entry 9 for hdmi
>   drm/i915: Split DP/eDP/FDI and HDMI/DVI DDI buffer programming apart
>   drm/i915: Get the iboost setting based on the port type
>   drm/i915: Simplify intel_ddi_get_encoder_port()
>   drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation
>     entry 2
>   drm/i915: Ignore OpRegion panel type except on select machines
> 
>  ubuntu/i915/i915_reg.h       |   2 +
>  ubuntu/i915/intel_ddi.c      | 308 +++++++++++++++++++++++------------
>  ubuntu/i915/intel_dp_mst.c   |   4 +-
>  ubuntu/i915/intel_drv.h      |   2 +-
>  ubuntu/i915/intel_opregion.c |  27 +++
>  5 files changed, 234 insertions(+), 109 deletions(-)
> 

Hi Timo,

Have these patches been tested in any other system with i915 apart from
the affected OEM laptop?


Thanks,
Kleber
Anthony Wong May 18, 2018, 3:12 p.m. UTC | #2
On Mon, May 14, 2018 at 06:18:28PM +0200, Kleber Souza wrote:
> On 05/11/18 08:20, Timo Aaltonen wrote:
> > BugLink: http://bugs.launchpad.net/bugs/1770565
> > 
> > This set of patches fixes flickering issues on a machine that changed the panel
> > vendor after it was certified.
> > 
> > 
> > Rodrigo Vivi (1):
> >   drm/i915: KBL - Recommended buffer translation programming for
> >     DisplayPort
> > 
> > Ville Syrjälä (10):
> >   drm/i915: Fix iboost setting for DDI with 4 lanes on SKL
> >   drm/i915: Name the "iboost bit"
> >   drm/i915: Program iboost settings for HDMI/DVI on SKL
> >   drm/i915: Move bxt_ddi_vswing_sequence() call into
> >     intel_ddi_pre_enable() for HDMI
> >   drm/i915: Explicitly use ddi buf trans entry 9 for hdmi
> >   drm/i915: Split DP/eDP/FDI and HDMI/DVI DDI buffer programming apart
> >   drm/i915: Get the iboost setting based on the port type
> >   drm/i915: Simplify intel_ddi_get_encoder_port()
> >   drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation
> >     entry 2
> >   drm/i915: Ignore OpRegion panel type except on select machines
> > 
> >  ubuntu/i915/i915_reg.h       |   2 +
> >  ubuntu/i915/intel_ddi.c      | 308 +++++++++++++++++++++++------------
> >  ubuntu/i915/intel_dp_mst.c   |   4 +-
> >  ubuntu/i915/intel_drv.h      |   2 +-
> >  ubuntu/i915/intel_opregion.c |  27 +++
> >  5 files changed, 234 insertions(+), 109 deletions(-)
> > 
> 
> Hi Timo,
> 
> Have these patches been tested in any other system with i915 apart from
> the affected OEM laptop?

The original laptop is a KBL-R. We have also verified on two Skylake
(8086:1916) and one Kaby Lake (8086:591e) laptops.

Thanks,
Anthony

> 
> 
> Thanks,
> Kleber
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Kleber Sacilotto de Souza May 18, 2018, 3:31 p.m. UTC | #3
On 05/18/18 17:12, Anthony Wong wrote:
> On Mon, May 14, 2018 at 06:18:28PM +0200, Kleber Souza wrote:
>> On 05/11/18 08:20, Timo Aaltonen wrote:
>>> BugLink: http://bugs.launchpad.net/bugs/1770565
>>>
>>> This set of patches fixes flickering issues on a machine that changed the panel
>>> vendor after it was certified.
>>>
>>>
>>> Rodrigo Vivi (1):
>>>   drm/i915: KBL - Recommended buffer translation programming for
>>>     DisplayPort
>>>
>>> Ville Syrjälä (10):
>>>   drm/i915: Fix iboost setting for DDI with 4 lanes on SKL
>>>   drm/i915: Name the "iboost bit"
>>>   drm/i915: Program iboost settings for HDMI/DVI on SKL
>>>   drm/i915: Move bxt_ddi_vswing_sequence() call into
>>>     intel_ddi_pre_enable() for HDMI
>>>   drm/i915: Explicitly use ddi buf trans entry 9 for hdmi
>>>   drm/i915: Split DP/eDP/FDI and HDMI/DVI DDI buffer programming apart
>>>   drm/i915: Get the iboost setting based on the port type
>>>   drm/i915: Simplify intel_ddi_get_encoder_port()
>>>   drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation
>>>     entry 2
>>>   drm/i915: Ignore OpRegion panel type except on select machines
>>>
>>>  ubuntu/i915/i915_reg.h       |   2 +
>>>  ubuntu/i915/intel_ddi.c      | 308 +++++++++++++++++++++++------------
>>>  ubuntu/i915/intel_dp_mst.c   |   4 +-
>>>  ubuntu/i915/intel_drv.h      |   2 +-
>>>  ubuntu/i915/intel_opregion.c |  27 +++
>>>  5 files changed, 234 insertions(+), 109 deletions(-)
>>>
>>
>> Hi Timo,
>>
>> Have these patches been tested in any other system with i915 apart from
>> the affected OEM laptop?
> 
> The original laptop is a KBL-R. We have also verified on two Skylake
> (8086:1916) and one Kaby Lake (8086:591e) laptops.

Hi Anthony,

Thank you for providing further testing feedback. I'm fine with the
changes given that. I'll reply with my ACK.


Thanks,
Kleber

> 
> Thanks,
> Anthony
> 
>>
>>
>> Thanks,
>> Kleber
>>
>> -- 
>> kernel-team mailing list
>> kernel-team@lists.ubuntu.com
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Kleber Sacilotto de Souza May 18, 2018, 3:34 p.m. UTC | #4
On 05/11/18 08:20, Timo Aaltonen wrote:
> BugLink: http://bugs.launchpad.net/bugs/1770565
> 
> This set of patches fixes flickering issues on a machine that changed the panel
> vendor after it was certified.
> 
> 
> Rodrigo Vivi (1):
>   drm/i915: KBL - Recommended buffer translation programming for
>     DisplayPort
> 
> Ville Syrjälä (10):
>   drm/i915: Fix iboost setting for DDI with 4 lanes on SKL
>   drm/i915: Name the "iboost bit"
>   drm/i915: Program iboost settings for HDMI/DVI on SKL
>   drm/i915: Move bxt_ddi_vswing_sequence() call into
>     intel_ddi_pre_enable() for HDMI
>   drm/i915: Explicitly use ddi buf trans entry 9 for hdmi
>   drm/i915: Split DP/eDP/FDI and HDMI/DVI DDI buffer programming apart
>   drm/i915: Get the iboost setting based on the port type
>   drm/i915: Simplify intel_ddi_get_encoder_port()
>   drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation
>     entry 2
>   drm/i915: Ignore OpRegion panel type except on select machines
> 
>  ubuntu/i915/i915_reg.h       |   2 +
>  ubuntu/i915/intel_ddi.c      | 308 +++++++++++++++++++++++------------
>  ubuntu/i915/intel_dp_mst.c   |   4 +-
>  ubuntu/i915/intel_drv.h      |   2 +-
>  ubuntu/i915/intel_opregion.c |  27 +++
>  5 files changed, 234 insertions(+), 109 deletions(-)
> 

As stated on the bug report, it fixes several issues to match the HW
spec and they have been tested on other platforms showing no regression.

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Stefan Bader May 23, 2018, 2:47 p.m. UTC | #5
On 11.05.2018 08:20, Timo Aaltonen wrote:
> BugLink: http://bugs.launchpad.net/bugs/1770565
> 
> This set of patches fixes flickering issues on a machine that changed the panel
> vendor after it was certified.
> 
> 
> Rodrigo Vivi (1):
>   drm/i915: KBL - Recommended buffer translation programming for
>     DisplayPort
> 
> Ville Syrjälä (10):
>   drm/i915: Fix iboost setting for DDI with 4 lanes on SKL
>   drm/i915: Name the "iboost bit"
>   drm/i915: Program iboost settings for HDMI/DVI on SKL
>   drm/i915: Move bxt_ddi_vswing_sequence() call into
>     intel_ddi_pre_enable() for HDMI
>   drm/i915: Explicitly use ddi buf trans entry 9 for hdmi
>   drm/i915: Split DP/eDP/FDI and HDMI/DVI DDI buffer programming apart
>   drm/i915: Get the iboost setting based on the port type
>   drm/i915: Simplify intel_ddi_get_encoder_port()
>   drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation
>     entry 2
>   drm/i915: Ignore OpRegion panel type except on select machines
> 
>  ubuntu/i915/i915_reg.h       |   2 +
>  ubuntu/i915/intel_ddi.c      | 308 +++++++++++++++++++++++------------
>  ubuntu/i915/intel_dp_mst.c   |   4 +-
>  ubuntu/i915/intel_drv.h      |   2 +-
>  ubuntu/i915/intel_opregion.c |  27 +++
>  5 files changed, 234 insertions(+), 109 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>

this is for the driver backport, which is limited to specific gpu vatiants
Stefan Bader May 23, 2018, 4:02 p.m. UTC | #6
On 11.05.2018 08:20, Timo Aaltonen wrote:
> BugLink: http://bugs.launchpad.net/bugs/1770565
> 
> This set of patches fixes flickering issues on a machine that changed the panel
> vendor after it was certified.
> 
> 
> Rodrigo Vivi (1):
>   drm/i915: KBL - Recommended buffer translation programming for
>     DisplayPort
> 
> Ville Syrjälä (10):
>   drm/i915: Fix iboost setting for DDI with 4 lanes on SKL
>   drm/i915: Name the "iboost bit"
>   drm/i915: Program iboost settings for HDMI/DVI on SKL
>   drm/i915: Move bxt_ddi_vswing_sequence() call into
>     intel_ddi_pre_enable() for HDMI
>   drm/i915: Explicitly use ddi buf trans entry 9 for hdmi
>   drm/i915: Split DP/eDP/FDI and HDMI/DVI DDI buffer programming apart
>   drm/i915: Get the iboost setting based on the port type
>   drm/i915: Simplify intel_ddi_get_encoder_port()
>   drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation
>     entry 2
>   drm/i915: Ignore OpRegion panel type except on select machines
> 
>  ubuntu/i915/i915_reg.h       |   2 +
>  ubuntu/i915/intel_ddi.c      | 308 +++++++++++++++++++++++------------
>  ubuntu/i915/intel_dp_mst.c   |   4 +-
>  ubuntu/i915/intel_drv.h      |   2 +-
>  ubuntu/i915/intel_opregion.c |  27 +++
>  5 files changed, 234 insertions(+), 109 deletions(-)
> 
Applied to xenial master-next

-Stefan