From patchwork Fri Apr 2 21:40:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Asmaa Mnebhi X-Patchwork-Id: 1461896 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FBtlj0vjWz9sW0; Sat, 3 Apr 2021 08:41:03 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1lSRXE-0001Xc-NW; Fri, 02 Apr 2021 21:40:56 +0000 Received: from mail-il-dmz.mellanox.com ([193.47.165.129] helo=mellanox.co.il) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1lSRXC-0001XU-E8 for kernel-team@lists.ubuntu.com; Fri, 02 Apr 2021 21:40:54 +0000 Received: from Internal Mail-Server by MTLPINE1 (envelope-from asmaa@mellanox.com) with SMTP; 3 Apr 2021 00:40:52 +0300 Received: from farm-0002.mtbu.labs.mlnx (farm-0002.mtbu.labs.mlnx [10.15.2.32]) by mtbu-labmailer.labs.mlnx (8.14.4/8.14.4) with ESMTP id 132Lepl2023808; Fri, 2 Apr 2021 17:40:51 -0400 Received: (from asmaa@localhost) by farm-0002.mtbu.labs.mlnx (8.14.7/8.13.8/Submit) id 132Lep5c028969; Fri, 2 Apr 2021 17:40:51 -0400 From: Asmaa Mnebhi To: kernel-team@lists.ubuntu.com Subject: [SRU][F:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: ipmb_host.c: Fix slow transactions Date: Fri, 2 Apr 2021 17:40:49 -0400 Message-Id: <1617399650-28927-1-git-send-email-asmaa@nvidia.com> X-Mailer: git-send-email 2.1.2 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: asmaa@nvidia.com MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1922393 SRU Justification: [Impact] * The previous ipmb_host patch broke the customer tests. They requested to make the ipmb_host response time as long as before. In the case where the I2C bus is made very busy, the ipmb_host driver just drops slow/delayed responses. This fix elongates the timeout of the response. * Fixes a crash which occurs after powercycling certain BlueField-2 systems. * The crash is due to the handshake which takes too long to wait for a response at boot time. [Fix] * Before executing the IPMB handshake which loads the ipmb_host driver, detect if there is a slave detected and make sure that the slave can respond. * Free current_msg pointer right after sending the message so that sent transactions are independent of the response transactions. [Test Case] * soft reset * powercycle * run ipmitool commands * remove and load module manually [Regression Potential] * The regression can be considered as low, since: * it restores previous stable code for the customer * and fixes a crash occurring after powercycling certain BlueField-2 systems.