From patchwork Fri Jan 25 15:21:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Pisati X-Patchwork-Id: 1031153 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43mN6D12Nzz9sBQ; Sat, 26 Jan 2019 02:21:40 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1gn3IQ-0006Nm-76; Fri, 25 Jan 2019 15:21:30 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1gn3IO-0006NB-Hc for kernel-team@lists.ubuntu.com; Fri, 25 Jan 2019 15:21:28 +0000 Received: from 1.general.ppisati.uk.vpn ([10.172.193.134] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1gn3IO-0003bg-6Y for kernel-team@lists.ubuntu.com; Fri, 25 Jan 2019 15:21:28 +0000 From: Paolo Pisati To: kernel-team@lists.ubuntu.com Subject: [PATCH 0/1] [SRU] [B/master] perf report can't annotate Date: Fri, 25 Jan 2019 16:21:26 +0100 Message-Id: <1548429687-17539-1-git-send-email-paolo.pisati@canonical.com> X-Mailer: git-send-email 2.7.4 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1675949 Impact: Under some condition, 'perf report' is unable to show the assembly code of a kernel function (perf report -> select a kernel function -> annotate). This is not an issue of the kernel itself or the perf tool, instead it's the environment that is missing the objdump binary (and perf, unfortunately, doesn't print any error about it). Make sure binutils is not installed, or move away the objdump binary: # mv /usr/bin/objdump /usr/bin/objdump.foo Run a perf session and write down all events: # perf record -a -- sleep 10 # perf report select a kernel function, press 'Annotate', a blank screen will appear (instead of the assembly code). Now put the objdump binary back (or install binutils): # mv /usr/bin/objdump.foo /usr/bin/objdump and run again perf report: # perf report select a kernel function, annotate, the disassembly will show up. Reproduced on Xenial/x86-64 and Bionic/arm64, but it probably affects all series where linux-tools/perf is shipped, and all arches - the original LP bug mentioned Xenial, Zesty, Artful and Bionic. Fix: Make binutils a Depends in SRCPKGNAME-tools-PKGVER-ABINUM - see the attached patch. How to test: Install a patched linux-tools-PKGVER-ABINUM.deb package: it will require binutils. Regression: We are adding a new dependency on a package, so code wise there's no regression potential - on the other hand, image creation, or development environments will experience a slight increase in size (1.8MB on x86-64 and 2.1M on arm64) if they didn't install binutils already. The patch applies cleanly on Bionic/master, but it requires some trivial contextual adaption on other series. Paolo Pisati (1): UBUNTU: [Packaging] SRCPKGNAME-tools-PKGVER-ABINUM: add binutils to Depends debian.master/control.stub.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)