| Message ID | e2aa97d7-bd82-ba11-c881-5eb6861a12cc@baylibre.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,PULL,u-boot] Please pull u-boot-amlogic-20190128 | expand |
Hi Neil, On Mon, 28 Jan 2019 14:09:13 +0100 Neil Armstrong narmstrong@baylibre.com wrote: ... > ---------------------------------------------------------------- > Adds pinconf support for the Amlogic pinctrl driver > > ---------------------------------------------------------------- > Jerome Brunet (1): > pinctrl: meson: add pinconf support > > drivers/pinctrl/meson/Kconfig | 1 + > drivers/pinctrl/meson/pinctrl-meson-axg-pmx.c | 10 +++ This change breaks building, please see error log here [1]. I think, a comma is missing after .pinconf_params = meson_axg_pinconf_params Please fix. [1] https://travis-ci.org/trini/u-boot/jobs/485695412#L1033 -- Anatolij
Hi, On 29/01/2019 11:14, Anatolij Gustschin wrote: > Hi Neil, > > On Mon, 28 Jan 2019 14:09:13 +0100 > Neil Armstrong narmstrong@baylibre.com wrote: > ... >> ---------------------------------------------------------------- >> Adds pinconf support for the Amlogic pinctrl driver >> >> ---------------------------------------------------------------- >> Jerome Brunet (1): >> pinctrl: meson: add pinconf support >> >> drivers/pinctrl/meson/Kconfig | 1 + >> drivers/pinctrl/meson/pinctrl-meson-axg-pmx.c | 10 +++ > > This change breaks building, please see error log here [1]. > I think, a comma is missing after > > .pinconf_params = meson_axg_pinconf_params > > Please fix. Thanks for reporting, I'm fixing it and I'll push another PR. Thanks, Neil > > [1] https://travis-ci.org/trini/u-boot/jobs/485695412#L1033 > > -- > Anatolij >
Hi Tom, First of all, greetings from BayLibre for the new year (a bit late) ! Here is single patch adding support for pinconf on the amlogic pinctrl driver. Thanks, Neil The following changes since commit 0da90255083681a02b24528f80da9d4062ff634a: Merge branch '2019-01-25-master-imports' (2019-01-26 22:47:55 -0500) are available in the Git repository at: git://git.denx.de/u-boot-amlogic.git tags/u-boot-amlogic-20190128 for you to fetch changes up to ed7bef7336a992f1edac1106de5d0f36405faa5b: pinctrl: meson: add pinconf support (2019-01-28 14:04:58 +0100) ---------------------------------------------------------------- Adds pinconf support for the Amlogic pinctrl driver ---------------------------------------------------------------- Jerome Brunet (1): pinctrl: meson: add pinconf support drivers/pinctrl/meson/Kconfig | 1 + drivers/pinctrl/meson/pinctrl-meson-axg-pmx.c | 10 +++ drivers/pinctrl/meson/pinctrl-meson-gx-pmx.c | 10 +++ drivers/pinctrl/meson/pinctrl-meson.c | 101 ++++++++++++++++++++++++-- drivers/pinctrl/meson/pinctrl-meson.h | 8 ++ 5 files changed, 123 insertions(+), 7 deletions(-)