Message ID | e286c7a4-1f88-6e95-4c2c-0623f53410f1@redhat.com |
---|---|
State | Accepted |
Delegated to: | Tom Rini |
Headers | show |
On Fri, Jul 15, 2016 at 04:29:28PM +0200, Hans de Goede wrote: > Hi Tom, > > Here is the first sunxi pull-req for v2016.09, > the big one here is Chen-Yu's PSCI cleanup, this > also touches non sunxi specific files but it seemed > best to me merge this through the sunxi tree. > > Besides this, it contains a h3 ethernet driver, > a few misc. fixes and 1 new board. > > Note I'm going on vacation for 2 weeks starting coming > Monday, so I won't be available for any (quick) > followup in case of any problems with the PSCI > support. If there are problems, then please contact > Chen-Yu (in the Cc) directly. > > The following changes since commit 3a592a1349ac3961b0f4f2db0a8d9f128225d897: > > Revert "armv8: Enable CPUECTLR.SMPEN for coherency" (2016-07-14 17:36:18 -0400) > > are available in the git repository at: > > http://git.denx.de/u-boot-sunxi.git master > > for you to fetch changes up to b7073965a343fca2bcde4195fbba664c98f309d8: > > ARM: PSCI: Make psci_get_cpu_stack_top local to armv7/psci.S (2016-07-15 15:54:58 +0200) > Applied to u-boot/master, thanks! But please note: +(pine64_plus) himport_r(&env_htab, (char *)spl->fel_script_address, +(pine64_plus) ^ w+(pine64_plus) ../board/sunxi/board.c: In function ‘parse_spl_header’: w+(pine64_plus) ../board/sunxi/board.c:601:24: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] It's not obvious to me what's going on in what's passed over to us in this case when it is a 64bit target, so I'm just going to allow the warning for now.
Am 16.07.2016 um 15:52 schrieb Tom Rini: > +(pine64_plus) himport_r(&env_htab, (char *)spl->fel_script_address, > +(pine64_plus) ^ > w+(pine64_plus) ../board/sunxi/board.c: In function ‘parse_spl_header’: > w+(pine64_plus) ../board/sunxi/board.c:601:24: warning: cast to pointer from integer of > different size [-Wint-to-pointer-cast] > > It's not obvious to me what's going on in what's passed over to us in > this case when it is a 64bit target, so I'm just going to allow the > warning for now. Sounds like trying to cast int to char*, which requires inserting a uintptr_t cast first. Regards, Andreas
On Sat, Jul 16, 2016 at 07:54:35PM +0200, Andreas Färber wrote: > Am 16.07.2016 um 15:52 schrieb Tom Rini: > > +(pine64_plus) himport_r(&env_htab, (char *)spl->fel_script_address, > > +(pine64_plus) ^ > > w+(pine64_plus) ../board/sunxi/board.c: In function ‘parse_spl_header’: > > w+(pine64_plus) ../board/sunxi/board.c:601:24: warning: cast to pointer from integer of > > different size [-Wint-to-pointer-cast] > > > > It's not obvious to me what's going on in what's passed over to us in > > this case when it is a 64bit target, so I'm just going to allow the > > warning for now. > > Sounds like trying to cast int to char*, which requires inserting a > uintptr_t cast first. Yes, but the question I had is, can we really say that fel_script_address is a uint32_t on 64bit platforms?