Message ID | d2b05f7cd22285e0f93226c00382556d2da65c25.1478272627.git-series.maxime.ripard@free-electrons.com |
---|---|
State | Accepted |
Commit | 91f839d2d30e489c2d6bf0deafb65b01d416b715 |
Delegated to: | Jagannadha Sutradharudu Teki |
Headers | show |
Hi, On Fri, Nov 4, 2016 at 11:18 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > The SinA33 comes with an optional 7" display. Enable it in the > configuration. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > configs/Sinlinx_SinA33_defconfig | 4 ++++ > 1 file changed, 4 insertions(+), 0 deletions(-) > > diff --git a/configs/Sinlinx_SinA33_defconfig b/configs/Sinlinx_SinA33_defconfig > index f4719db2d501..26b119a9b92f 100644 > --- a/configs/Sinlinx_SinA33_defconfig > +++ b/configs/Sinlinx_SinA33_defconfig > @@ -6,6 +6,10 @@ CONFIG_DRAM_ZQ=15291 > CONFIG_MMC0_CD_PIN="PB4" > CONFIG_MMC_SUNXI_SLOT_EXTRA=2 > CONFIG_USB0_ID_DET="PH8" > +CONFIG_VIDEO_LCD_MODE="x:1024,y:600,depth:18,pclk_khz:66000,le:90,ri:160,up:3,lo:127,hs:70,vs:20,sync:3,vmode:0" > +CONFIG_VIDEO_LCD_DCLK_PHASE=0 > +CONFIG_VIDEO_LCD_BL_EN="PH6" > +CONFIG_VIDEO_LCD_BL_PWM="PH0" I'm using the exact same panel with my SinA31s. The schematics show that these 2 pins aren't actually hooked up to the panel at all. Instead of BL_EN, the corresponding pin is pull-ed up to 3.3V by a resistor just before the LCD connector on the base board. Please try it without these 2 pins set. ChenYu P.S. I've also a VGA converter board for the SinA33 which I've never tried. > CONFIG_DEFAULT_DEVICE_TREE="sun8i-a33-sinlinx-sina33" > # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set > CONFIG_SPL=y > -- > git-series 0.8.11
Hi, On 04-11-16 16:18, Maxime Ripard wrote: > The SinA33 comes with an optional 7" display. Enable it in the > configuration. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> LGTM: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > configs/Sinlinx_SinA33_defconfig | 4 ++++ > 1 file changed, 4 insertions(+), 0 deletions(-) > > diff --git a/configs/Sinlinx_SinA33_defconfig b/configs/Sinlinx_SinA33_defconfig > index f4719db2d501..26b119a9b92f 100644 > --- a/configs/Sinlinx_SinA33_defconfig > +++ b/configs/Sinlinx_SinA33_defconfig > @@ -6,6 +6,10 @@ CONFIG_DRAM_ZQ=15291 > CONFIG_MMC0_CD_PIN="PB4" > CONFIG_MMC_SUNXI_SLOT_EXTRA=2 > CONFIG_USB0_ID_DET="PH8" > +CONFIG_VIDEO_LCD_MODE="x:1024,y:600,depth:18,pclk_khz:66000,le:90,ri:160,up:3,lo:127,hs:70,vs:20,sync:3,vmode:0" > +CONFIG_VIDEO_LCD_DCLK_PHASE=0 > +CONFIG_VIDEO_LCD_BL_EN="PH6" > +CONFIG_VIDEO_LCD_BL_PWM="PH0" > CONFIG_DEFAULT_DEVICE_TREE="sun8i-a33-sinlinx-sina33" > # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set > CONFIG_SPL=y >
Hi Hans, On 11/14/2016 03:51 AM, Hans de Goede wrote: > Hi, > > On 04-11-16 16:18, Maxime Ripard wrote: >> The SinA33 comes with an optional 7" display. Enable it in the >> configuration. >> >> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > LGTM: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> This patch is not on MMC side. But i picked with other patches. If there is other issue, let me know, plz. Best Regards, Jaehoon Chung > > Regards, > > Hans > > > >> --- >> configs/Sinlinx_SinA33_defconfig | 4 ++++ >> 1 file changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/configs/Sinlinx_SinA33_defconfig b/configs/Sinlinx_SinA33_defconfig >> index f4719db2d501..26b119a9b92f 100644 >> --- a/configs/Sinlinx_SinA33_defconfig >> +++ b/configs/Sinlinx_SinA33_defconfig >> @@ -6,6 +6,10 @@ CONFIG_DRAM_ZQ=15291 >> CONFIG_MMC0_CD_PIN="PB4" >> CONFIG_MMC_SUNXI_SLOT_EXTRA=2 >> CONFIG_USB0_ID_DET="PH8" >> +CONFIG_VIDEO_LCD_MODE="x:1024,y:600,depth:18,pclk_khz:66000,le:90,ri:160,up:3,lo:127,hs:70,vs:20,sync:3,vmode:0" >> +CONFIG_VIDEO_LCD_DCLK_PHASE=0 >> +CONFIG_VIDEO_LCD_BL_EN="PH6" >> +CONFIG_VIDEO_LCD_BL_PWM="PH0" >> CONFIG_DEFAULT_DEVICE_TREE="sun8i-a33-sinlinx-sina33" >> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set >> CONFIG_SPL=y >> > > >
On 11/14/2016 03:51 AM, Hans de Goede wrote: > Hi, > > On 04-11-16 16:18, Maxime Ripard wrote: >> The SinA33 comes with an optional 7" display. Enable it in the >> configuration. >> >> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > LGTM: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> Applied on u-boot-mmc. Thanks! Best Regards, Jaehoon Chung > > Regards, > > Hans > > > >> --- >> configs/Sinlinx_SinA33_defconfig | 4 ++++ >> 1 file changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/configs/Sinlinx_SinA33_defconfig b/configs/Sinlinx_SinA33_defconfig >> index f4719db2d501..26b119a9b92f 100644 >> --- a/configs/Sinlinx_SinA33_defconfig >> +++ b/configs/Sinlinx_SinA33_defconfig >> @@ -6,6 +6,10 @@ CONFIG_DRAM_ZQ=15291 >> CONFIG_MMC0_CD_PIN="PB4" >> CONFIG_MMC_SUNXI_SLOT_EXTRA=2 >> CONFIG_USB0_ID_DET="PH8" >> +CONFIG_VIDEO_LCD_MODE="x:1024,y:600,depth:18,pclk_khz:66000,le:90,ri:160,up:3,lo:127,hs:70,vs:20,sync:3,vmode:0" >> +CONFIG_VIDEO_LCD_DCLK_PHASE=0 >> +CONFIG_VIDEO_LCD_BL_EN="PH6" >> +CONFIG_VIDEO_LCD_BL_PWM="PH0" >> CONFIG_DEFAULT_DEVICE_TREE="sun8i-a33-sinlinx-sina33" >> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set >> CONFIG_SPL=y >> > > >
diff --git a/configs/Sinlinx_SinA33_defconfig b/configs/Sinlinx_SinA33_defconfig index f4719db2d501..26b119a9b92f 100644 --- a/configs/Sinlinx_SinA33_defconfig +++ b/configs/Sinlinx_SinA33_defconfig @@ -6,6 +6,10 @@ CONFIG_DRAM_ZQ=15291 CONFIG_MMC0_CD_PIN="PB4" CONFIG_MMC_SUNXI_SLOT_EXTRA=2 CONFIG_USB0_ID_DET="PH8" +CONFIG_VIDEO_LCD_MODE="x:1024,y:600,depth:18,pclk_khz:66000,le:90,ri:160,up:3,lo:127,hs:70,vs:20,sync:3,vmode:0" +CONFIG_VIDEO_LCD_DCLK_PHASE=0 +CONFIG_VIDEO_LCD_BL_EN="PH6" +CONFIG_VIDEO_LCD_BL_PWM="PH0" CONFIG_DEFAULT_DEVICE_TREE="sun8i-a33-sinlinx-sina33" # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL=y
The SinA33 comes with an optional 7" display. Enable it in the configuration. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- configs/Sinlinx_SinA33_defconfig | 4 ++++ 1 file changed, 4 insertions(+), 0 deletions(-)