From patchwork Mon Apr 9 12:02:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Guillaume GARDET X-Patchwork-Id: 896266 X-Patchwork-Delegate: jh80.chung@samsung.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=free.fr Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 40KTTP1GRxz9s2S for ; Mon, 9 Apr 2018 22:03:05 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id D5C85C21DFA; Mon, 9 Apr 2018 12:02:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 20399C21C6A; Mon, 9 Apr 2018 12:02:50 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id EAD7DC21C6A; Mon, 9 Apr 2018 12:02:48 +0000 (UTC) Received: from smtp2-g21.free.fr (smtp2-g21.free.fr [212.27.42.2]) by lists.denx.de (Postfix) with ESMTPS id 9C134C21C27 for ; Mon, 9 Apr 2018 12:02:48 +0000 (UTC) Received: from [192.168.0.10] (unknown [82.244.147.214]) by smtp2-g21.free.fr (Postfix) with ESMTP id D384A2003A3; Mon, 9 Apr 2018 14:02:47 +0200 (CEST) To: Jaehoon Chung From: Guillaume Gardet Message-ID: Date: Mon, 9 Apr 2018 14:02:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 Content-Language: en-US Cc: u-boot Subject: [U-Boot] [BUG] snow: mmc: SD card access broken: unable to select a mode X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: guillaume.gardet@free.fr Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Hi Jaehoon, There are problems with SD card access on Samsung Chromebook (snow) with latest master (and also 2018.05-rc1 and 2018.03). eMMC is ok, but SD card access leads to 'unable to select a mode' problem. If I disable HS mode, I can access the SD card without problem: ******************************************************************************** ******************************************************************************** Once we try to select HS mode, all access to SD card result in failure, even when trying to setup a lower frequency mode, including SD legacy at 25 MHz. Any idea what is going? Maybe you have fixes pending? Guillaume diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index 23f642980bf..28f4fa0f213 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_mmc.c @@ -508,7 +508,8 @@ void dwmci_setup_cfg(struct mmc_config *cfg, struct dwmci_host *host,          cfg->host_caps |= MMC_MODE_4BIT;          cfg->host_caps &= ~MMC_MODE_8BIT;      } -    cfg->host_caps |= MMC_MODE_HS | MMC_MODE_HS_52MHz; +    /* Temp workaround for Chromebook snow to avoid the 'unable to select a mode' error */ +//     cfg->host_caps |= MMC_MODE_HS | MMC_MODE_HS_52MHz;      cfg->b_max = CONFIG_SYS_MMC_MAX_BLK_COUNT;  }