diff mbox series

[3/4] Kconfig: Add missing quotes around default string value

Message ID b8bee323b100ef1f5958e2f64e14e9776ff2bc06.1713180904.git.michal.simek@amd.com
State Superseded
Delegated to: Tom Rini
Headers show
Series Kconfig: some cleanups | expand

Commit Message

Michal Simek April 15, 2024, 11:35 a.m. UTC
All errors are generated by ./tools/qconfig.py -b -j8 -i whatever.
Error look like this:
warning: style: quotes recommended around default value for string symbol
EFI_VAR_SEED_FILE (defined at lib/efi_loader/Kconfig:130)

Signed-off-by: Michal Simek <michal.simek@amd.com>
---

 lib/efi_loader/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Heinrich Schuchardt April 15, 2024, 12:41 p.m. UTC | #1
On 15.04.24 13:35, Michal Simek wrote:
> All errors are generated by ./tools/qconfig.py -b -j8 -i whatever.
> Error look like this:
> warning: style: quotes recommended around default value for string symbol
> EFI_VAR_SEED_FILE (defined at lib/efi_loader/Kconfig:130)
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
>   lib/efi_loader/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> index e13a6f9f4c3a..a5ab7d1b262f 100644
> --- a/lib/efi_loader/Kconfig
> +++ b/lib/efi_loader/Kconfig
> @@ -129,7 +129,7 @@ if EFI_VARIABLES_PRESEED
>
>   config EFI_VAR_SEED_FILE
>   	string "File with initial values of non-volatile UEFI variables"
> -	default ubootefi.var
> +	default "ubootefi.var"
>   	help
>   	  File with initial values of non-volatile UEFI variables. The file must
>   	  be in the same format as the storage in the EFI system partition. The

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
diff mbox series

Patch

diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
index e13a6f9f4c3a..a5ab7d1b262f 100644
--- a/lib/efi_loader/Kconfig
+++ b/lib/efi_loader/Kconfig
@@ -129,7 +129,7 @@  if EFI_VARIABLES_PRESEED
 
 config EFI_VAR_SEED_FILE
 	string "File with initial values of non-volatile UEFI variables"
-	default ubootefi.var
+	default "ubootefi.var"
 	help
 	  File with initial values of non-volatile UEFI variables. The file must
 	  be in the same format as the storage in the EFI system partition. The