diff mbox

[U-Boot] post: Delete unnecessary bitmask of POST_MANUAL from POST_ALWAYS

Message ID alpine.LFD.2.20.1603271015220.13115@localhost.localdomain
State Accepted
Commit 5735bca5f677a5aeb61364a6491080c6bb2ebc0e
Delegated to: Tom Rini
Headers show

Commit Message

Robert P. J. Day March 27, 2016, 2:18 p.m. UTC 
Since POST_ALWAYS is defined as:

#define POST_ALWAYS             (POST_NORMAL    | \
                                 POST_SLOWTEST  | \
                                 POST_MANUAL    | \
                                 POST_POWERON   )

there is no need to redundantly bitmask it with POST_MANUAL.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

Comments

Tom Rini April 2, 2016, 1:58 a.m. UTC | #1 
On Sun, Mar 27, 2016 at 10:18:55AM -0400, Robert P. J. Day wrote:

> Since POST_ALWAYS is defined as:
> 
> #define POST_ALWAYS             (POST_NORMAL    | \
>                                  POST_SLOWTEST  | \
>                                  POST_MANUAL    | \
>                                  POST_POWERON   )
> 
> there is no need to redundantly bitmask it with POST_MANUAL.
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> 
> diff --git a/post/tests.c b/post/tests.c
> index a4d4165..d8ac54e 100644

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/post/tests.c b/post/tests.c
index a4d4165..d8ac54e 100644
--- a/post/tests.c
+++ b/post/tests.c
@@ -173,7 +173,7 @@  struct post_test post_list[] =
 	"ETHERNET test",
 	"ethernet",
 	"This test verifies the ETHERNET operation.",
-	POST_RAM | POST_ALWAYS | POST_MANUAL,
+	POST_RAM | POST_ALWAYS,
 	&ether_post_test,
 	NULL,
 	NULL,
@@ -185,7 +185,7 @@  struct post_test post_list[] =
 	"SPI test",
 	"spi",
 	"This test verifies the SPI operation.",
-	POST_RAM | POST_ALWAYS | POST_MANUAL,
+	POST_RAM | POST_ALWAYS,
 	&spi_post_test,
 	NULL,
 	NULL,
@@ -197,7 +197,7 @@  struct post_test post_list[] =
 	"USB test",
 	"usb",
 	"This test verifies the USB operation.",
-	POST_RAM | POST_ALWAYS | POST_MANUAL,
+	POST_RAM | POST_ALWAYS,
 	&usb_post_test,
 	NULL,
 	NULL,
@@ -233,7 +233,7 @@  struct post_test post_list[] =
 	"DSP test",
 	"dsp",
 	"This test checks any connected DSP(s).",
-	POST_RAM | POST_ALWAYS | POST_MANUAL,
+	POST_RAM | POST_ALWAYS,
 	&dsp_post_test,
 	NULL,
 	NULL,