From patchwork Sun Apr 29 16:26:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 155749 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 710B1B7014 for ; Mon, 30 Apr 2012 02:26:15 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 1231D283F5; Sun, 29 Apr 2012 18:26:10 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HugEYZGgtHMa; Sun, 29 Apr 2012 18:26:09 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6B2BD283E1; Sun, 29 Apr 2012 18:26:08 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6F62D283E1 for ; Sun, 29 Apr 2012 18:26:06 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vDwAi4Joz0lK for ; Sun, 29 Apr 2012 18:26:05 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44]) by theia.denx.de (Postfix) with ESMTPS id 4F2D9283DF for ; Sun, 29 Apr 2012 18:26:03 +0200 (CEST) Received: by eeke51 with SMTP id e51so587139eek.3 for ; Sun, 29 Apr 2012 09:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=/2WxMiEZuJYAlm+JFjlFG22BT2mmVDbudF5P0Yt7UKc=; b=H/UaZedQNSuguxeTBwYMUPRk2J8Zf+XwFmIe1sTLT6c+6FwHys84mVEqWhFVIWT13E F8xkZS7SmYxB0UjkHDjIWo14luWbW+ZQ6wOXnUGz3pveOkh8PZ2KF9cXvR/v7gnVlEUv 0CnP0yXc4V6VX28i4VsZPawqiSqRWO7A+cqGrZx1Q5fqDmaYzqMqkxRp1KYmF6JdAVJZ ewl0Oe3NiJi8e/ncPKGgBb5sAdxKdCwCNrvfssL/3hQyRU8HLeyITK3ciMiQop0yXXi8 RTSRul5ioI8ErBK/qBEeW6rIPttuAfHU8AFKP3mggBON0HqF+0vRHBPHTYo2dFQ3i11M QREQ== MIME-Version: 1.0 Received: by 10.14.97.11 with SMTP id s11mr3945098eef.60.1335716761622; Sun, 29 Apr 2012 09:26:01 -0700 (PDT) Received: by 10.213.4.131 with HTTP; Sun, 29 Apr 2012 09:26:01 -0700 (PDT) In-Reply-To: References: <1332279610-22838-1-git-send-email-fabio.estevam@freescale.com> <1332279610-22838-2-git-send-email-fabio.estevam@freescale.com> <4F98E580.6090809@de.bosch.com> Date: Sun, 29 Apr 2012 13:26:01 -0300 Message-ID: From: Fabio Estevam To: Dirk Behme Cc: Fabio Estevam , "u-boot@lists.denx.de" Subject: Re: [U-Boot] [PATCH 2/5] imx-common: Factor out get_ahb_clk() X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de Dirk, On Sun, Apr 29, 2012 at 11:54 AM, Fabio Estevam wrote: > Thanks for testing it. I found one mistake and will submit a fix shortly. Here is one issue I found: This should be fixed, but it seems it does not explain the problem you are seeing. We need to check whether get_ahb_clk() is using the weak definition of get_periph_clk() instead the one from clock.c. Regards, Fabio Estevam --- a/arch/arm/cpu/armv7/imx-common/cpu.c +++ b/arch/arm/cpu/armv7/imx-common/cpu.c @@ -147,6 +147,4 @@ u32 get_ahb_clk(void) ahb_podf = reg >> MXC_CCM_CBCDR_AHB_PODF_OFFSET; return get_periph_clk() / (ahb_podf + 1); - - return 0; }