| Message ID | CAGi-RULtH8rEqS3+45E7e_NnByTWJ-aVnP79CnyRhp7aGE6erQ@mail.gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Please pull u-boot-net/next | expand |
On Wed, Nov 10, 2021 at 07:58:42PM +0200, Ramon Fried wrote: > his PR includes the following net changes for next: > > - Various DSA additions > - bootp: fix for VCI string > - tsec: support for promiscuous mode > - macb: Fix for random MAC address not saved to the environment. > The following changes since commit e8e9c6f48400989c5fc54467576f8d535bd713e6: > > Merge https://source.denx.de/u-boot/custodians/u-boot-samsung > (2021-11-09 15:05:33 -0500) > > are available in the Git repository at: > > https://source.denx.de/u-boot/custodians/u-boot-net.git/ > > for you to fetch changes up to 23a438b2d05db54c95315094fe9ac8fe0c46213e: > > net: uclass: Save ethernet MAC address when generated (2021-11-10 > 19:55:01 +0200) As it seems we're still actively discussing the implications of: > Michal Simek (1): > net: uclass: Save ethernet MAC address when generated Can you please re-spin with that dropped? Thanks!
On Mon, Nov 15, 2021 at 7:37 PM Tom Rini <trini@konsulko.com> wrote: > > On Wed, Nov 10, 2021 at 07:58:42PM +0200, Ramon Fried wrote: > > > his PR includes the following net changes for next: > > > > - Various DSA additions > > - bootp: fix for VCI string > > - tsec: support for promiscuous mode > > - macb: Fix for random MAC address not saved to the environment. > > The following changes since commit e8e9c6f48400989c5fc54467576f8d535bd713e6: > > > > Merge https://source.denx.de/u-boot/custodians/u-boot-samsung > > (2021-11-09 15:05:33 -0500) > > > > are available in the Git repository at: > > > > https://source.denx.de/u-boot/custodians/u-boot-net.git/ > > > > for you to fetch changes up to 23a438b2d05db54c95315094fe9ac8fe0c46213e: > > > > net: uclass: Save ethernet MAC address when generated (2021-11-10 > > 19:55:01 +0200) > > As it seems we're still actively discussing the implications of: > > > Michal Simek (1): > > net: uclass: Save ethernet MAC address when generated > > Can you please re-spin with that dropped? Thanks! > > -- > Tom I sure can, but I'm against that. the patch should stay IMO. I saw the thread, it actually started in IRC, where I already gave my opinion. Thanks, Ramon.
On Tue, Nov 16, 2021 at 08:08:36AM +0200, Ramon Fried wrote: > On Mon, Nov 15, 2021 at 7:37 PM Tom Rini <trini@konsulko.com> wrote: > > > > On Wed, Nov 10, 2021 at 07:58:42PM +0200, Ramon Fried wrote: > > > > > his PR includes the following net changes for next: > > > > > > - Various DSA additions > > > - bootp: fix for VCI string > > > - tsec: support for promiscuous mode > > > - macb: Fix for random MAC address not saved to the environment. > > > The following changes since commit e8e9c6f48400989c5fc54467576f8d535bd713e6: > > > > > > Merge https://source.denx.de/u-boot/custodians/u-boot-samsung > > > (2021-11-09 15:05:33 -0500) > > > > > > are available in the Git repository at: > > > > > > https://source.denx.de/u-boot/custodians/u-boot-net.git/ > > > > > > for you to fetch changes up to 23a438b2d05db54c95315094fe9ac8fe0c46213e: > > > > > > net: uclass: Save ethernet MAC address when generated (2021-11-10 > > > 19:55:01 +0200) > > > > As it seems we're still actively discussing the implications of: > > > > > Michal Simek (1): > > > net: uclass: Save ethernet MAC address when generated > > > > Can you please re-spin with that dropped? Thanks! > > I sure can, but I'm against that. the patch should stay IMO. > I saw the thread, it actually started in IRC, where I already gave my opinion. I'm cycling back to this again because setting aside that I'm not convinced yet this is the right path, it's also an incomplete patch because the help text for NET_RANDOM_ETHADDR specifically says the environment is not updated, which is no longer true after that patch and needs to be corrected.
On Wed, Nov 17, 2021 at 4:09 PM Tom Rini <trini@konsulko.com> wrote: > > On Tue, Nov 16, 2021 at 08:08:36AM +0200, Ramon Fried wrote: > > On Mon, Nov 15, 2021 at 7:37 PM Tom Rini <trini@konsulko.com> wrote: > > > > > > On Wed, Nov 10, 2021 at 07:58:42PM +0200, Ramon Fried wrote: > > > > > > > his PR includes the following net changes for next: > > > > > > > > - Various DSA additions > > > > - bootp: fix for VCI string > > > > - tsec: support for promiscuous mode > > > > - macb: Fix for random MAC address not saved to the environment. > > > > The following changes since commit e8e9c6f48400989c5fc54467576f8d535bd713e6: > > > > > > > > Merge https://source.denx.de/u-boot/custodians/u-boot-samsung > > > > (2021-11-09 15:05:33 -0500) > > > > > > > > are available in the Git repository at: > > > > > > > > https://source.denx.de/u-boot/custodians/u-boot-net.git/ > > > > > > > > for you to fetch changes up to 23a438b2d05db54c95315094fe9ac8fe0c46213e: > > > > > > > > net: uclass: Save ethernet MAC address when generated (2021-11-10 > > > > 19:55:01 +0200) > > > > > > As it seems we're still actively discussing the implications of: > > > > > > > Michal Simek (1): > > > > net: uclass: Save ethernet MAC address when generated > > > > > > Can you please re-spin with that dropped? Thanks! > > > > I sure can, but I'm against that. the patch should stay IMO. > > I saw the thread, it actually started in IRC, where I already gave my opinion. > > I'm cycling back to this again because setting aside that I'm not > convinced yet this is the right path, it's also an incomplete patch > because the help text for NET_RANDOM_ETHADDR specifically says the > environment is not updated, which is no longer true after that patch and > needs to be corrected. > > -- > Tom Sending a new one in a new thread.
his PR includes the following net changes for next: - Various DSA additions - bootp: fix for VCI string - tsec: support for promiscuous mode - macb: Fix for random MAC address not saved to the environment. The following changes since commit e8e9c6f48400989c5fc54467576f8d535bd713e6: Merge https://source.denx.de/u-boot/custodians/u-boot-samsung (2021-11-09 15:05:33 -0500) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-net.git/ for you to fetch changes up to 23a438b2d05db54c95315094fe9ac8fe0c46213e: net: uclass: Save ethernet MAC address when generated (2021-11-10 19:55:01 +0200) ---------------------------------------------------------------- Bin Meng (3): net: dsa: Use true instead of 1 in the set_promisc() call net: fec_mxc: Declare 'promisc' as bool net: tsec: Make redundant_init() static Michal Simek (1): net: uclass: Save ethernet MAC address when generated Peter Hoyes (1): cmd: pxe_utils: Check fdtcontroladdr in label_boot Vladimir Oltean (11): net: phy: mscc: add support for VSC8502 in dual RGMII mode net: tsec: add support for promiscuous mode include: import if_vlan.h from Linux net: dsa: allow drivers to get the port OF node net: introduce a helper to determine whether to use in-band autoneg net: dsa: felix: configure the in-band autoneg property based on OF node info net: dsa: add driver for NXP SJA1105 L2 switch net: dsa: sja1105: add support for SGMII arm: dts: ls1021a-tsn: add sja1105 and eth2 bindings configs: ls1021a-tsn: enable sja1105 switch driver configs: ls1021a-tsn: enable the generation of random Ethernet MAC addresses Walter Stoll (1): net: bootp: Correct VCI string transmission arch/arm/dts/ls1021a-tsn.dts | 103 + cmd/pxe_utils.c | 8 +- configs/ls1021atsn_qspi_defconfig | 3 + configs/ls1021atsn_sdcard_defconfig | 3 + drivers/core/of_extra.c | 12 + drivers/net/Kconfig | 16 + drivers/net/Makefile | 1 + drivers/net/fec_mxc.h | 2 +- drivers/net/mscc_eswitch/felix_switch.c | 10 +- drivers/net/phy/mscc.c | 56 + drivers/net/sja1105.c | 3376 +++++++++++++++++++++++++++++++ drivers/net/tsec.c | 22 +- include/dm/of_extra.h | 14 + include/linux/if_vlan.h | 26 + include/net/dsa.h | 12 + include/tsec.h | 2 + net/bootp.c | 2 +- net/dsa-uclass.c | 22 +- net/eth-uclass.c | 2 + 19 files changed, 3677 insertions(+), 15 deletions(-) create mode 100644 drivers/net/sja1105.c create mode 100644 include/linux/if_vlan.h Thanks, Ramon.