| Message ID | BY1PR03MB72863313CCC8B4927892BFB2E18C2@BY1PR03MB7286.namprd03.prod.outlook.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [v1] dm: core: Make SPL_DM_SEQ_ALIAS select SPL_STRTO | expand |
On Mon, 19 Aug 2024 at 03:43, Gaskell, Oliver <Oliver.Gaskell@analog.com> wrote: > > Enabling CONFIG_DM_SEQ_ALIAS enables code which relies on > `trailing_strtol()` - which is only linked in SPL when CONFIG_SPL_STRTO > is enabled. > > CONFIG_SPL_STRTO is not enabled by default - to ensure this function is > available in SPL, CONFIG_SPL_DM_SEQ_ALIAS should select > CONFIG_SPL_STRTO. > > Signed-off-by: Oliver Gaskell <Oliver.Gaskell@analog.com> > --- > > drivers/core/Kconfig | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass <sjg@chromium.org> > > diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig > index 1a7be4d9b4..c39abe3bc9 100644 > --- a/drivers/core/Kconfig > +++ b/drivers/core/Kconfig > @@ -146,6 +146,7 @@ config DM_SEQ_ALIAS > config SPL_DM_SEQ_ALIAS > bool "Support numbered aliases in device tree in SPL" > depends on SPL_DM > + select SPL_STRTO > help > Most boards will have a '/aliases' node containing the path to > numbered devices (e.g. serial0 = &serial0). This feature can be > -- > 2.34.1
On Mon, 19 Aug 2024 09:43:52 +0000, Gaskell, Oliver wrote: > Enabling CONFIG_DM_SEQ_ALIAS enables code which relies on > `trailing_strtol()` - which is only linked in SPL when CONFIG_SPL_STRTO > is enabled. > > CONFIG_SPL_STRTO is not enabled by default - to ensure this function is > available in SPL, CONFIG_SPL_DM_SEQ_ALIAS should select > CONFIG_SPL_STRTO. > > [...] Applied to u-boot/next, thanks!
diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig index 1a7be4d9b4..c39abe3bc9 100644 --- a/drivers/core/Kconfig +++ b/drivers/core/Kconfig @@ -146,6 +146,7 @@ config DM_SEQ_ALIAS config SPL_DM_SEQ_ALIAS bool "Support numbered aliases in device tree in SPL" depends on SPL_DM + select SPL_STRTO help Most boards will have a '/aliases' node containing the path to numbered devices (e.g. serial0 = &serial0). This feature can be
Enabling CONFIG_DM_SEQ_ALIAS enables code which relies on `trailing_strtol()` - which is only linked in SPL when CONFIG_SPL_STRTO is enabled. CONFIG_SPL_STRTO is not enabled by default - to ensure this function is available in SPL, CONFIG_SPL_DM_SEQ_ALIAS should select CONFIG_SPL_STRTO. Signed-off-by: Oliver Gaskell <Oliver.Gaskell@analog.com> --- drivers/core/Kconfig | 1 + 1 file changed, 1 insertion(+)