From patchwork Wed Dec 1 15:58:07 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sanjeev Premi X-Patchwork-Id: 73842 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id F00AFB6F1E for ; Thu, 2 Dec 2010 02:58:23 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 81A6C280C9; Wed, 1 Dec 2010 16:58:20 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zH30uAHNdAke; Wed, 1 Dec 2010 16:58:20 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 57399280D9; Wed, 1 Dec 2010 16:58:19 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 1DBA9280C9 for ; Wed, 1 Dec 2010 16:58:18 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y3OI3VfFTg9X for ; Wed, 1 Dec 2010 16:58:16 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by theia.denx.de (Postfix) with ESMTPS id 05D18280D9 for ; Wed, 1 Dec 2010 16:58:14 +0100 (CET) Received: from dbdp20.itg.ti.com ([172.24.170.38]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id oB1Fw9n9015001 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 1 Dec 2010 09:58:12 -0600 Received: from dbde70.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id oB1Fw8nN022555 for ; Wed, 1 Dec 2010 21:28:09 +0530 (IST) Received: from dbde02.ent.ti.com ([172.24.170.145]) by dbde70.ent.ti.com ([172.24.170.148]) with mapi; Wed, 1 Dec 2010 21:28:08 +0530 From: "Premi, Sanjeev" To: "u-boot@lists.denx.de" Date: Wed, 1 Dec 2010 21:28:07 +0530 Thread-Topic: [PATCH] ARMv7: Fix linker errors across toolchain versions Thread-Index: AcuRatc0llOs6bNtQPexH1mOC7NodAABIDtQ Message-ID: References: <1291216634-7510-1-git-send-email-premi@ti.com> In-Reply-To: <1291216634-7510-1-git-send-email-premi@ti.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 Subject: Re: [U-Boot] [PATCH] ARMv7: Fix linker errors across toolchain versions X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de > -----Original Message----- > From: Premi, Sanjeev > Sent: Wednesday, December 01, 2010 8:47 PM > To: u-boot@lists.denx.de > Cc: Premi, Sanjeev > Subject: [PATCH] ARMv7: Fix linker errors across toolchain versions > > This patch fixes the linker problems noticed while > building the omap3_evm with Codesourcery toolchains > 2009q1, 2009q3 and 2010q1. > > The compilation was tested as success for both > omap3_evm and omap3_beagle with toolchain versions > 2009q1 and 2010q1. > > [1] http://marc.info/?l=u-boot&m=129104332808386&w=2 > > Signed-off-by: Sanjeev Premi > --- > The patch touches all ARMv7 architectures, will need > to be reviewed thoroughly. > > I am getting hang of relocation feature, but definitely > hands-on. Impact would have to be reviewd as well. > This is the reason for sending the patch early - before > i start testing on the evm. > > arch/arm/cpu/armv7/u-boot.lds | 26 +++++++++++++++----------- > 1 files changed, 15 insertions(+), 11 deletions(-) > [snip]...[snip] The u-boot built after this change alone gets stuck somewhere after dram_init(). However, removing the "sort" from LIBS (as suggested by Wolfgang), the u-boot comes up fine on the omap3_evm. [patch] [/patch] U-Boot 2010.12-rc2-00030-g4998cdc-dirty (Dec 01 2010 - 21:09:59) OMAP3530-GP ES3.1, CPU-OPP2, L3-165MHz, Max CPU Clock 720 mHz OMAP3 EVM board + LPDDR/NAND I2C: ready DRAM: 256 MiB NAND: 256 MiB In: serial Out: serial Err: serial Read back SMSC id 0x92200000 Die ID #609200040000000004032d460c01201a Net: smc911x-0 Hit any key to stop autoboot: 0 OMAP3_EVM # OMAP3_EVM # Here is my git-log (including the patch above): premi # g-log-10 4998cdc : ARMv7: Fix linker errors across toolchain versions 49733aa : Merge branch 'master' of /home/wd/git/u-boot/custodians f8264e0 : Merge branch 'master' of git://git.denx.de/u-boot-arm b194577 : hwconfig: Fix dummy initialization of {board, cpu}_hwconfig a55bb83 : powerpc/85xx: Introduce CONFIG_SYS_EXTRA_ENV_RELOC 52eb2c7 : Merge branch 'master' of git://git.denx.de/u-boot-samsung 83b622a : Merge branch 'master' of /home/wd/git/u-boot/custodians 3410a99 : Merge branch 'master' of git://git.denx.de/u-boot-sh a7bf3ec : Merge branch 'master' of /home/wd/git/u-boot/custodians e45c98a : mpc83xx: Make it boot again premi # diff --git a/Makefile b/Makefile index 87a383d..a530261 100644 --- a/Makefile +++ b/Makefile @@ -263,7 +263,7 @@ ifeq ($(SOC),s5pc2xx) LIBS += $(CPUDIR)/s5p-common/libs5p-common.o endif -LIBS := $(addprefix $(obj),$(sort $(LIBS))) +LIBS := $(addprefix $(obj),$(LIBS)) .PHONY : $(LIBS) $(TIMESTAMP_FILE) $(VERSION_FILE) LIBBOARD = board/$(BOARDDIR)/lib$(BOARD).o