From patchwork Fri Apr 26 08:02:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schiffer X-Patchwork-Id: 1928017 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=tq-group.com header.i=@tq-group.com header.a=rsa-sha256 header.s=key1 header.b=eLRdsyTe; dkim=fail reason="key not found in DNS" header.d=ew.tq-group.com header.i=@ew.tq-group.com header.a=rsa-sha256 header.s=dkim header.b=e8NwUZUG; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VQlbL32lkz1yb7 for ; Fri, 26 Apr 2024 18:03:26 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 25BC089140; Fri, 26 Apr 2024 10:02:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=tq-group.com header.i=@tq-group.com header.b="eLRdsyTe"; dkim=fail reason="key not found in DNS" (0-bit key; unprotected) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="e8NwUZUG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 70B2888EF8; Fri, 26 Apr 2024 10:02:57 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2859589145 for ; Fri, 26 Apr 2024 10:02:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=matthias.schiffer@ew.tq-group.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1714118574; x=1745654574; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eLMyik4jwIvxzanoiox4VPCgipj7fBmhrcMJjO4krV4=; b=eLRdsyTeVfFiL/1fAUXamzC2P+1dZMj4KMHcvhsNYD+eMP2flfqIxaco N8iVEaE9c92UCymQpS7g5Ag/4yEIB3nMfS74TYU17krxDteJUzEm7a0zv A2he3sGlqTr0U2P7OxXwmO2rKY8N5+yCWsrLrjf2ZMXmuv4S6MQvu28bv Ejc6BvlqkkGptxfAm/ur20S6SQpT9u80/x3WJVd8e98+oaIcvfABFfbI/ fze/SHWgyNlRFPTww5i02pkhwu+lZ6Moz/Nw/u0Xbxtu3i5vqxJmpjuFB MVpFbzrw/T2jUgj9mJVPkt/eYavEL1Dj3X5lr12UvPw9zM35RwBzf/Y8+ A==; X-IronPort-AV: E=Sophos;i="6.07,231,1708383600"; d="scan'208";a="36629245" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 26 Apr 2024 10:02:54 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5C3C216F00B; Fri, 26 Apr 2024 10:02:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1714118570; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=eLMyik4jwIvxzanoiox4VPCgipj7fBmhrcMJjO4krV4=; b=e8NwUZUGrEkc89Lj6c1ZzTRIyWHzOKiNytfsraFAqv7q3burGCM6Dkg0hZSuUgLoVjsNn9 WUUcOYrNX44I+/J0kCU4lhpB40FYbpMPqzIDoVsPguAKUS3J4H0VLSeRnCPlf//+WexqpZ 5w/e+puf6lKnP31Td8tvNIHRuhZp+dmIJvc0EWAaZ2zPf5VSHjUj2Uht0pg05ofmkzLhTi jWgMAfEuYW5S6/rdlr6wUFyKrGtgOR4R6jDHZdQP/N1TNiw+snnMt8SNsdAQz8+jrPHerT m3RkGhEv1/tR1IA/8uSohAbR3Dl/p80qtkXUbJZ9s2eE2OV8ToXJA14TpV/m6A== From: Matthias Schiffer To: Tom Rini , Joe Hershberger , Ramon Fried , MD Danish Anwar , Jai Luthra , Siddharth Vadapalli , Nishanth Menon , Udit Kumar , Suman Anna Cc: u-boot@lists.denx.de, u-boot@ew.tq-group.com, Matthias Schiffer Subject: [PATCH 3/5] net: ti: am65-cpsw-nuss: fix error handling for "RX dma add buf failed" Date: Fri, 26 Apr 2024 10:02:26 +0200 Message-ID: <93c1d3ea7a0f90d08d267c5acf9b59e65aaccf62.1714117337.git.matthias.schiffer@ew.tq-group.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: References: MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean The RX DMA channel has been requested at this point already, so it must be freed. Signed-off-by: Matthias Schiffer --- drivers/net/ti/am65-cpsw-nuss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ti/am65-cpsw-nuss.c b/drivers/net/ti/am65-cpsw-nuss.c index 4a57e945a3a..65ade1afd05 100644 --- a/drivers/net/ti/am65-cpsw-nuss.c +++ b/drivers/net/ti/am65-cpsw-nuss.c @@ -362,7 +362,7 @@ static int am65_cpsw_start(struct udevice *dev) UDMA_RX_BUF_SIZE); if (ret) { dev_err(dev, "RX dma add buf failed %d\n", ret); - goto err_free_tx; + goto err_free_rx; } }