diff mbox

[U-Boot,09/11] colibri_vf: Add separate defconfig for device tree support

Message ID 556C0D7D.8010009@denx.de
State Superseded
Delegated to: Stefano Babic
Headers show

Commit Message

Stefano Babic June 1, 2015, 7:45 a.m. UTC
Hi Bhuvanchandra,

On 18/05/2015 15:06, Bhuvanchandra DV wrote:
> Most of the drivers available for Vybrid are not yet converted
> to OF model to use device tree model, only few drivers
> like SPI and GPIO drivers use device trees.
> Add separate defconfig for who needs to use device tree model.
> Later this can be integrated to single defconfig.
> 
> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
> ---
>  configs/colibri_vf_dtb_defconfig | 6 ++++++
>  1 file changed, 6 insertions(+)
>  create mode 100644 configs/colibri_vf_dtb_defconfig
> 
> diff --git a/configs/colibri_vf_dtb_defconfig b/configs/colibri_vf_dtb_defconfig
> new file mode 100644
> index 0000000..28ff1e9
> --- /dev/null
> +++ b/configs/colibri_vf_dtb_defconfig
> @@ -0,0 +1,6 @@
> +CONFIG_ARM=y
> +CONFIG_TARGET_COLIBRI_VF=y
> +CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/toradex/colibri_vf/imximage.cfg,ENV_IS_IN_NAND,IMX_NAND"
> +CONFIG_DM=y
> +CONFIG_OF_CONTROL=y
> +CONFIG_DEFAULT_DEVICE_TREE="vf610-colibri"
> 

This patch is broken because NAND setup is missing and the board
colibri_vf_dtp is not built.

Indeed, it is fixed with:

+CONFIG_SYS_NAND_VF610_NFC_60_ECC_BYTES=y


Please add these to your patch and resubmit, thanks !

Best regards,
Stefano Babic

Comments

Bhuvanchandra DV June 1, 2015, 8:07 a.m. UTC | #1
Hello Stefano,

On 06/01/2015 01:15 PM, Stefano Babic wrote:
> Hi Bhuvanchandra,
>
> On 18/05/2015 15:06, Bhuvanchandra DV wrote:
>> Most of the drivers available for Vybrid are not yet converted
>> to OF model to use device tree model, only few drivers
>> like SPI and GPIO drivers use device trees.
>> Add separate defconfig for who needs to use device tree model.
>> Later this can be integrated to single defconfig.
>>
>> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
>> ---
>>   configs/colibri_vf_dtb_defconfig | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>   create mode 100644 configs/colibri_vf_dtb_defconfig
>>
>> diff --git a/configs/colibri_vf_dtb_defconfig b/configs/colibri_vf_dtb_defconfig
>> new file mode 100644
>> index 0000000..28ff1e9
>> --- /dev/null
>> +++ b/configs/colibri_vf_dtb_defconfig
>> @@ -0,0 +1,6 @@
>> +CONFIG_ARM=y
>> +CONFIG_TARGET_COLIBRI_VF=y
>> +CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/toradex/colibri_vf/imximage.cfg,ENV_IS_IN_NAND,IMX_NAND"
>> +CONFIG_DM=y
>> +CONFIG_OF_CONTROL=y
>> +CONFIG_DEFAULT_DEVICE_TREE="vf610-colibri"
>>
>
> This patch is broken because NAND setup is missing and the board
> colibri_vf_dtp is not built.
>
> Indeed, it is fixed with:
>
> diff --git a/configs/colibri_vf_dtb_defconfig
> b/configs/colibri_vf_dtb_defconfig
> index 28ff1e9..88ecbdc 100644
> --- a/configs/colibri_vf_dtb_defconfig
> +++ b/configs/colibri_vf_dtb_defconfig
> @@ -4,3 +4,5 @@
> CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/toradex/colibri_vf/imximage.cfg,ENV_I
>   CONFIG_DM=y
>   CONFIG_OF_CONTROL=y
>   CONFIG_DEFAULT_DEVICE_TREE="vf610-colibri"
> +CONFIG_NAND_VF610_NFC=y
> +CONFIG_SYS_NAND_VF610_NFC_60_ECC_BYTES=y
>
>
> Please add these to your patch and resubmit, thanks !
Will add this and resubmit the patchset.
>
> Best regards,
> Stefano Babic
>
Best regards,
Bhuvan
diff mbox

Patch

diff --git a/configs/colibri_vf_dtb_defconfig
b/configs/colibri_vf_dtb_defconfig
index 28ff1e9..88ecbdc 100644
--- a/configs/colibri_vf_dtb_defconfig
+++ b/configs/colibri_vf_dtb_defconfig
@@ -4,3 +4,5 @@ 
CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/toradex/colibri_vf/imximage.cfg,ENV_I
 CONFIG_DM=y
 CONFIG_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="vf610-colibri"
+CONFIG_NAND_VF610_NFC=y