From patchwork Sun Feb 5 06:16:40 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dirk Behme X-Patchwork-Id: 139609 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 759B3B724C for ; Sun, 5 Feb 2012 17:17:07 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id BEC0628078; Sun, 5 Feb 2012 07:17:01 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zRe-Qwzfe05b; Sun, 5 Feb 2012 07:17:01 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id E03DF2807B; Sun, 5 Feb 2012 07:16:59 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 864042807B for ; Sun, 5 Feb 2012 07:16:57 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id URIGQO9+brdh for ; Sun, 5 Feb 2012 07:16:56 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-bk0-f44.google.com (mail-bk0-f44.google.com [209.85.214.44]) by theia.denx.de (Postfix) with ESMTPS id 0DEEF28078 for ; Sun, 5 Feb 2012 07:16:54 +0100 (CET) Received: by bkbzt4 with SMTP id zt4so3862396bkb.3 for ; Sat, 04 Feb 2012 22:16:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=4uLOmpZfHycOBYmP2vRGZPDRXjPCS73wADT+1E8YbjU=; b=P/s5qQxWj7/tuhkSjfc41cIfZ/S0Z7C23hhJVD/CqCGru68SFykcaZulb19DRSI3Ph msaRtre4Hm0H5/pUOp7ZdXS2WhIq1YiCM4cpIuQxo7TrusAGbuvNyClI3xSjUbbUS8nh RJj4wiAjb/PmH6MdDjZ1xu0WkjjYnJXI3JyyI= Received: by 10.205.136.19 with SMTP id ii19mr6314986bkc.60.1328422612705; Sat, 04 Feb 2012 22:16:52 -0800 (PST) Received: from [192.168.178.32] (pD9F7C976.dip.t-dialin.net. [217.247.201.118]) by mx.google.com with ESMTPS id fg16sm32563014bkb.16.2012.02.04.22.16.50 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 04 Feb 2012 22:16:51 -0800 (PST) Message-ID: <4F2E1EC8.8010507@googlemail.com> Date: Sun, 05 Feb 2012 07:16:40 +0100 From: Dirk Behme User-Agent: Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Mike Frysinger References: <1328410966-13946-1-git-send-email-troy.kisky@boundarydevices.com> <1328410966-13946-2-git-send-email-troy.kisky@boundarydevices.com> <201202042238.42038.vapier@gentoo.org> In-Reply-To: <201202042238.42038.vapier@gentoo.org> Cc: u-boot@lists.denx.de, afleming@gmail.com Subject: Re: [U-Boot] [PATCH 2/2] RFC: Let linker create phy array X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de On 05.02.2012 04:38, Mike Frysinger wrote: > On Saturday 04 February 2012 22:02:46 Troy Kisky wrote: >> --- a/drivers/net/phy/broadcom.c >> +++ b/drivers/net/phy/broadcom.c >> >> -static struct phy_driver BCM5461S_driver = { >> +struct phy_driver BCM5461S_driver __phy_entry = { > > why do you have to remove the static ? that shouldn't affect the section name > that it gets placed into. > >> --- a/include/phy.h >> +++ b/include/phy.h >> >> +extern struct phy_driver __phy_entry_start, __phy_entry_end; > > linker symbols should be declared like: > extern char __phy_entry_start[]; > >> --- a/u-boot-common.lds >> +++ b/u-boot-common.lds > > i'm not seeing this in the u-boot tree ... u-boot-common.lds is created by patch 1/2 of this series which seems to not reached the list (due to the size?). Most probably it waits for moderator approval. I got this directly as I'm in CC. See below [1] for the essential parts. Best regards Dirk [1] [PATCH 1/2] RFC: create u-boot-common.lds This makes adding linker defined tables easier as far fewer lds files will need to be touched. Signed-off-by: Troy Kisky Series based on Stefano's u-boot-imx Close inspection of board/mousse/u-boot.lds.ram arch/blackfin/cpu/u-boot.lds is warranted. ./MAKEALL -a arm Boards compiled: 216 Boards with warnings or errors: 71 --- arch/arm/cpu/arm1136/u-boot.lds | 7 +------ arch/arm/cpu/arm1176/u-boot.lds | 5 +---- arch/arm/cpu/arm720t/u-boot.lds | 7 +------ arch/arm/cpu/arm920t/ep93xx/u-boot.lds | 5 +---- arch/arm/cpu/arm920t/u-boot.lds | 7 +------ arch/arm/cpu/arm925t/u-boot.lds | 7 +------ arch/arm/cpu/arm926ejs/mx28/u-boot-spl.lds | 5 +---- arch/arm/cpu/arm926ejs/u-boot.lds | 7 +------ arch/arm/cpu/arm946es/u-boot.lds | 7 +------ arch/arm/cpu/arm_intcm/u-boot.lds | 7 +------ arch/arm/cpu/armv7/u-boot.lds | 8 ++------ arch/arm/cpu/ixp/u-boot.lds | 7 +------ arch/arm/cpu/lh7a40x/u-boot.lds | 7 +------ arch/arm/cpu/pxa/u-boot.lds | 7 +------ arch/arm/cpu/s3c44b0/u-boot.lds | 7 +------ arch/arm/cpu/sa1100/u-boot.lds | 7 +------ arch/avr32/cpu/u-boot.lds | 8 +------- arch/blackfin/cpu/u-boot.lds | 15 ++++++--------- arch/nds32/cpu/n1213/u-boot.lds | 5 +---- arch/nios2/cpu/u-boot.lds | 8 ++------ arch/powerpc/cpu/74xx_7xx/u-boot.lds | 11 +---------- arch/powerpc/cpu/mpc512x/u-boot.lds | 11 +---------- arch/powerpc/cpu/mpc5xx/u-boot.lds | 11 +---------- arch/powerpc/cpu/mpc5xxx/u-boot-customlayout.lds | 11 +---------- arch/powerpc/cpu/mpc5xxx/u-boot.lds | 11 +---------- arch/powerpc/cpu/mpc8220/u-boot.lds | 11 +---------- arch/powerpc/cpu/mpc824x/u-boot.lds | 11 +---------- arch/powerpc/cpu/mpc8260/u-boot.lds | 11 +---------- arch/powerpc/cpu/mpc83xx/u-boot.lds | 11 +---------- arch/powerpc/cpu/mpc85xx/u-boot-nand.lds | 10 +--------- arch/powerpc/cpu/mpc85xx/u-boot.lds | 10 +--------- arch/powerpc/cpu/mpc86xx/u-boot.lds | 10 +--------- arch/powerpc/cpu/ppc4xx/u-boot.lds | 10 +--------- arch/sandbox/cpu/u-boot.lds | 4 +--- arch/sh/cpu/sh2/u-boot.lds | 9 ++------- arch/sh/cpu/sh3/u-boot.lds | 10 +++------- arch/sh/cpu/sh4/u-boot.lds | 9 ++------- arch/x86/cpu/u-boot.lds | 6 +----- board/BuS/EB+MCF-EV123/u-boot.lds | 10 +--------- board/LEOX/elpt860/u-boot.lds | 10 +--------- board/LEOX/elpt860/u-boot.lds.debug | 4 +--- board/RPXClassic/u-boot.lds | 11 +---------- board/RPXClassic/u-boot.lds.debug | 9 +-------- board/RPXlite/u-boot.lds | 11 +---------- board/RPXlite/u-boot.lds.debug | 9 +-------- board/RPXlite_dw/u-boot.lds | 11 +---------- board/RPXlite_dw/u-boot.lds.debug | 9 +-------- board/RRvision/u-boot.lds | 11 +---------- board/actux1/u-boot.lds | 8 ++------ board/actux2/u-boot.lds | 8 ++------ board/actux3/u-boot.lds | 8 ++------ board/adder/u-boot.lds | 11 +---------- board/altera/nios2-generic/u-boot.lds | 8 ++------ board/amcc/acadia/u-boot-nand.lds | 11 +---------- board/amcc/bamboo/u-boot-nand.lds | 11 +---------- board/amcc/canyonlands/u-boot-nand.lds | 11 +---------- board/amcc/kilauea/u-boot-nand.lds | 11 +---------- board/amcc/sequoia/u-boot-nand.lds | 11 +---------- board/amcc/sequoia/u-boot-ram.lds | 11 +---------- board/amirix/ap1000/u-boot.lds | 9 +-------- board/astro/mcf5373l/u-boot.lds | 11 +---------- board/c2mon/u-boot.lds | 11 +---------- board/c2mon/u-boot.lds.debug | 9 +-------- board/cobra5272/u-boot.lds | 10 +--------- board/cogent/u-boot.lds | 11 +---------- board/cogent/u-boot.lds.debug | 9 +-------- board/cray/L1/u-boot.lds.debug | 9 +-------- board/dave/PPChameleonEVB/u-boot.lds | 10 +--------- board/dbau1x00/u-boot.lds | 6 +----- board/dvlhost/u-boot.lds | 8 ++------ board/eltec/mhpc/u-boot.lds | 11 +---------- board/eltec/mhpc/u-boot.lds.debug | 9 +-------- board/emk/top860/u-boot.lds | 12 +----------- board/emk/top860/u-boot.lds.debug | 4 +--- board/ep88x/u-boot.lds | 11 +---------- board/esd/dasa_sim/u-boot.lds | 11 +---------- board/esd/pmc440/u-boot-nand.lds | 11 +---------- board/esd/tasreg/u-boot.lds | 10 +--------- board/esteem192e/u-boot.lds | 11 +---------- board/etx094/u-boot.lds | 11 +---------- board/evb64260/u-boot.lds | 11 +---------- board/fads/u-boot.lds | 11 +---------- board/flagadm/u-boot.lds | 11 +---------- board/flagadm/u-boot.lds.debug | 9 +-------- board/freescale/m5208evbe/u-boot.lds | 10 +--------- board/freescale/m52277evb/u-boot.lds | 10 +--------- board/freescale/m5235evb/u-boot.lds | 10 +--------- board/freescale/m5249evb/u-boot.lds | 10 +--------- board/freescale/m5253demo/u-boot.lds | 10 +--------- board/freescale/m5253evbe/u-boot.lds | 10 +--------- board/freescale/m5271evb/u-boot.lds | 10 +--------- board/freescale/m5272c3/u-boot.lds | 10 +--------- board/freescale/m5275evb/u-boot.lds | 10 +--------- board/freescale/m5282evb/u-boot.lds | 10 +--------- board/freescale/m53017evb/u-boot.lds | 10 +--------- board/freescale/m5329evb/u-boot.lds | 10 +--------- board/freescale/m5373evb/u-boot.lds | 10 +--------- board/freescale/m54451evb/u-boot.lds | 10 +--------- board/freescale/m54455evb/u-boot.lds | 10 +--------- board/freescale/m547xevb/u-boot.lds | 10 +--------- board/freescale/m548xevb/u-boot.lds | 10 +--------- board/freescale/mx31ads/u-boot.lds | 5 +---- board/gaisler/gr_cpci_ax2000/u-boot.lds | 6 +----- board/gaisler/gr_ep2s60/u-boot.lds | 6 +----- board/gaisler/gr_xc3s_1500/u-boot.lds | 6 +----- board/gaisler/grsim/u-boot.lds | 6 +----- board/gaisler/grsim_leon2/u-boot.lds | 6 +----- board/gen860t/u-boot-flashenv.lds | 10 +--------- board/gen860t/u-boot.lds | 11 +---------- board/genietv/u-boot.lds | 11 +---------- board/genietv/u-boot.lds.debug | 9 +-------- board/gth2/u-boot.lds | 6 +----- board/hermes/u-boot.lds | 11 +---------- board/hermes/u-boot.lds.debug | 9 +-------- board/hymod/u-boot.lds | 11 +---------- board/hymod/u-boot.lds.debug | 9 +-------- board/icu862/u-boot.lds | 11 +---------- board/icu862/u-boot.lds.debug | 9 +-------- board/idmr/u-boot.lds | 10 +--------- board/incaip/u-boot.lds | 6 +----- board/ip860/u-boot.lds | 11 +---------- board/ip860/u-boot.lds.debug | 9 +-------- board/ivm/u-boot.lds | 11 +---------- board/ivm/u-boot.lds.debug | 9 +-------- board/jornada/u-boot.lds | 6 +----- board/korat/u-boot-F7FC.lds | 11 +---------- board/kup/kup4k/u-boot.lds | 11 +---------- board/kup/kup4k/u-boot.lds.debug | 9 +-------- board/kup/kup4x/u-boot.lds | 11 +---------- board/kup/kup4x/u-boot.lds.debug | 9 +-------- board/lantec/u-boot.lds | 11 +---------- board/lantec/u-boot.lds.debug | 9 +-------- board/lwmon/u-boot.lds | 11 +---------- board/lwmon/u-boot.lds.debug | 9 +-------- board/manroland/uc100/u-boot.lds | 11 +---------- board/matrix_vision/mvsmr/u-boot.lds | 11 +---------- board/mbx8xx/u-boot.lds | 11 +---------- board/mbx8xx/u-boot.lds.debug | 9 +-------- board/micronas/vct/u-boot.lds | 7 +------ board/ml2/u-boot.lds | 11 +---------- board/ml2/u-boot.lds.debug | 9 +-------- board/mousse/u-boot.lds | 11 +---------- board/mousse/u-boot.lds.ram | 9 +-------- board/mousse/u-boot.lds.rom | 8 +------- board/mpl/pip405/u-boot.lds.debug | 9 +-------- board/mvblue/u-boot.lds | 11 +---------- board/netphone/u-boot.lds | 11 +---------- board/netphone/u-boot.lds.debug | 9 +-------- board/netta/u-boot.lds | 11 +---------- board/netta/u-boot.lds.debug | 9 +-------- board/netta2/u-boot.lds | 11 +---------- board/netta2/u-boot.lds.debug | 9 +-------- board/netvia/u-boot.lds | 11 +---------- board/netvia/u-boot.lds.debug | 9 +-------- board/nx823/u-boot.lds | 11 +---------- board/nx823/u-boot.lds.debug | 9 +-------- board/openrisc/openrisc-generic/u-boot.lds | 4 +--- board/pb1x00/u-boot.lds | 6 +----- board/qemu-mips/u-boot.lds | 7 +------ board/qi/qi_lb60/u-boot.lds | 4 +--- board/quantum/u-boot.lds | 11 +---------- board/quantum/u-boot.lds.debug | 4 +--- board/r360mpi/u-boot.lds | 11 +---------- board/rbc823/u-boot.lds | 10 +--------- board/renesas/sh7757lcr/u-boot.lds | 10 +++------- board/rsdproto/u-boot.lds | 11 +---------- board/samsung/smdk6400/u-boot-nand.lds | 4 +--- board/sandburst/karef/u-boot.lds.debug | 9 +-------- board/sandburst/metrobox/u-boot.lds.debug | 9 +-------- board/sandpoint/u-boot.lds | 11 +---------- board/siemens/IAD210/u-boot.lds | 11 +---------- board/sixnet/u-boot.lds | 11 +---------- board/snmc/qs850/u-boot.lds | 11 +---------- board/snmc/qs860t/u-boot.lds | 11 +---------- board/spc1920/u-boot.lds | 11 +---------- board/spd8xx/u-boot.lds | 11 +---------- board/spd8xx/u-boot.lds.debug | 9 +-------- board/stx/stxxtc/u-boot.lds | 11 +---------- board/stx/stxxtc/u-boot.lds.debug | 9 +-------- board/svm_sc8xx/u-boot.lds | 11 +---------- board/svm_sc8xx/u-boot.lds.debug | 4 +--- board/tqc/tqm8xx/u-boot.lds | 11 +---------- board/v37/u-boot.lds | 11 +---------- board/w7o/u-boot.lds.debug | 9 +-------- board/westel/amx860/u-boot.lds | 11 +---------- board/westel/amx860/u-boot.lds.debug | 9 +-------- board/xes/xpedite1000/u-boot.lds.debug | 9 +-------- board/xilinx/microblaze-generic/u-boot.lds | 8 +------- board/zipitz2/u-boot.lds | 5 +---- doc/README.commands | 5 +++++ nand_spl/board/freescale/mx31pdk/Makefile | 2 +- nand_spl/board/freescale/mx31pdk/u-boot.lds | 5 +---- nand_spl/board/karo/tx25/Makefile | 2 +- nand_spl/board/karo/tx25/u-boot.lds | 5 +---- nand_spl/board/samsung/smdk6400/Makefile | 2 +- nand_spl/board/samsung/smdk6400/u-boot.lds | 4 +--- spl/Makefile | 3 ++- u-boot-common.lds | 14 ++++++++++++++ 198 files changed, 234 insertions(+), 1554 deletions(-) create mode 100644 u-boot-common.lds diff --git a/arch/arm/cpu/arm1136/u-boot.lds b/arch/arm/cpu/arm1136/u-boot.lds index d1e2851..cd7927c 100644 --- a/arch/arm/cpu/arm1136/u-boot.lds +++ b/arch/arm/cpu/arm1136/u-boot.lds @@ -52,12 +52,7 @@ SECTIONS *(.data) } - . = ALIGN(4); - - . = .; - __u_boot_cmd_start = .; - .u_boot_cmd : { *(.u_boot_cmd) } - __u_boot_cmd_end = .; + INCLUDE u-boot-common.lds . = ALIGN(4); diff --git a/arch/arm/cpu/arm1176/u-boot.lds b/arch/arm/cpu/arm1176/u-boot.lds index 27d6638..9852b0a 100644 --- a/arch/arm/cpu/arm1176/u-boot.lds +++ b/arch/arm/cpu/arm1176/u-boot.lds @@ -43,10 +43,7 @@ SECTIONS *(.data) } - . = .; - __u_boot_cmd_start = .; - .u_boot_cmd : { *(.u_boot_cmd) } - __u_boot_cmd_end = .; + INCLUDE u-boot-common.lds . = ALIGN(4); ... diff --git a/u-boot-common.lds b/u-boot-common.lds new file mode 100644 index 0000000..e9a5fc9 --- /dev/null +++ b/u-boot-common.lds @@ -0,0 +1,14 @@ + . = ALIGN(4); + __u_boot_cmd_start = .; + .u_boot_cmd : { + KEEP(*(.u_boot_cmd)) + } + __u_boot_cmd_end = .; + + /* powerpc specific, but harmless for others */ + . = ALIGN(4); + __start___ex_table = .; + __ex_table : { + KEEP(*(__ex_table)) + } + __stop___ex_table = .;