From patchwork Sat Jun 25 19:28:16 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 102041 X-Patchwork-Delegate: linux@bohmer.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3AE11B6F85 for ; Sun, 26 Jun 2011 05:28:36 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 88B7F280A0; Sat, 25 Jun 2011 21:28:32 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L6NrAYgGHc-h; Sat, 25 Jun 2011 21:28:32 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 7B78828088; Sat, 25 Jun 2011 21:28:30 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 1379628088 for ; Sat, 25 Jun 2011 21:28:28 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VHBJGurIGOQ7 for ; Sat, 25 Jun 2011 21:28:27 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-gy0-f172.google.com (mail-gy0-f172.google.com [209.85.160.172]) by theia.denx.de (Postfix) with ESMTPS id 1A3B028087 for ; Sat, 25 Jun 2011 21:28:25 +0200 (CEST) Received: by gya6 with SMTP id 6so1619772gya.3 for ; Sat, 25 Jun 2011 12:28:22 -0700 (PDT) Received: by 10.101.166.33 with SMTP id t33mr2072018ano.149.1309030102002; Sat, 25 Jun 2011 12:28:22 -0700 (PDT) Received: from [192.168.5.153] (ip65-46-142-190.z142-46-65.customer.algx.net [65.46.142.190]) by mx.google.com with ESMTPS id i14sm3339406ann.8.2011.06.25.12.28.18 (version=SSLv3 cipher=OTHER); Sat, 25 Jun 2011 12:28:21 -0700 (PDT) Message-ID: <4E0636D0.9010107@gmail.com> Date: Sat, 25 Jun 2011 14:28:16 -0500 From: Joel A Fernandes User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 MIME-Version: 1.0 To: U-Boot@lists.denx.de References: In-Reply-To: Cc: "Patton, Schuyler" , Chase , beagleboard@googlegroups.com, Koen , Robert Berger , eric@eukrea.com, Joel A Fernandes , "Kridner, Jason" Subject: [U-Boot] [PATCH] ehci-hcd: Allow cleanups to happen on an EHCI timeout. X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de With this, the EHCI seems to "recover" from a timeout. This is particularly observable if you were to ping the wrong IP Address and then ping the correct one or if there was a temporary failure during tftp sessions. All it takes is one timeout to disable it. If you have a noisy network (lot of traffic), even if the traffic is not for the board, the timeouts don't occur. Signed-off-by: Joel A Fernandes --- Robert, Could you see if this patch solves the issue you're seeing without increasing the timeout? Simon, Could this be a fix for a similar issue you were seeing with asix? drivers/usb/host/ehci-hcd.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index 243bb39..9bfcbae 100644 --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c @@ -464,7 +464,6 @@ ehci_submit_async(struct usb_device *dev, unsigned long pipe, void *buffer, /* Check that the TD processing happened */ if (token & 0x80) { printf("EHCI timed out on TD - token=%#x\n", token); - goto fail; } /* Disable async schedule. */