| Message ID | 48c52f49-8882-821c-70e5-3dfa34c7722b@denx.de |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,PULL] Please pull u-boot-imx | expand |
On Fri, Aug 31, 2018 at 03:04:31PM +0200, Stefano Babic wrote: > Hi Tom, > > please pull from u-boot-imx, thanks ! > > The following changes since commit 11ed312896c5f5814064c5d45dcb2f53dc121437: > > configs: am57xx: change default board name to beagle_x15 (2018-08-26 > 12:26:16 -0400) > > are available in the Git repository at: > > git://www.denx.de/git/u-boot-imx.git master > > for you to fetch changes up to 2846e663fd62200a189bba357135e284a379a38b: > > imx: missing CONFIG_MII in mx7dsabresd_qspi_defconfig (2018-08-31 > 12:08:43 +0200) > > ---------------------------------------------------------------- > Alex Kiernan (1): > Cleanup CONFIG_BOOTDELAY on cl-som-imx7 > > Anson Huang (3): > imx: mx7: psci: improve cpu hotplug flow > imx: mx7: add gpc initialization for low power mode > imx: mx7: add system suspend/resume support > > Denis Zalevskiy (6): > board: ge: Remove EEPROM bus param from read_vpd() > board: ge: Move VPD EEPROM configuration to the defconfig > bootcount: i2c: Add bus switching to the I2C bootcount driver > bootcount: Configure length limit for I2C bootcount > board: ge: Move VPD reading to the vpd_reader > board: ge: Store bootcount in EEPROM on PPD and Bx50v3 > > Martin Kaiser (1): > watchdog: mx25: use the imx_watchdog driver for mx25 > > Stefan Agner (2): > board: toradex: common: fail gracefully on missing NAND chip > colibri_imx7_emmc: add Colibri iMX7D 1GB (eMMC) module support > > Stefano Babic (2): > Merge branch 'master' of git://git.denx.de/u-boot into master > imx: missing CONFIG_MII in mx7dsabresd_qspi_defconfig > > Sébastien Szymanski (1): > ARM: opos6ul: make the board boot again > > Ye Li (6): > imx: imx6sx-sdb: Enable DM QSPI driver > imx: imx6sx-sabreauto: convert to use DM QSPI driver > imx: imx7d-sdb: Add DM QSPI support > dts: imx6ul: Update alias to support DM > dts: imx6ul_evk: Add DTS files for 14x14 EVK and 9x9 EVK boards > imx: imx6ul_evk: Enable DM driver for iMX6UL EVK u-boot > > arch/arm/dts/Makefile | 7 +- > arch/arm/dts/imx6sx-sabreauto-u-boot.dtsi | 16 + > arch/arm/dts/imx6sx-sabreauto.dts | 40 ++ > arch/arm/dts/imx6sx-sdb-u-boot.dtsi | 16 + > arch/arm/dts/imx6sx.dtsi | 12 +- > arch/arm/dts/imx6ul-14x14-evk-u-boot.dtsi | 10 + > arch/arm/dts/imx6ul-14x14-evk.dts | 427 +++++++++++++++++++ > arch/arm/dts/imx6ul-9x9-evk-u-boot.dtsi | 10 + > arch/arm/dts/imx6ul-9x9-evk.dts | 471 > +++++++++++++++++++++ > arch/arm/dts/imx6ul-opos6ul-u-boot.dtsi | 28 ++ > arch/arm/dts/imx6ul-opos6ul.dtsi | 2 - > arch/arm/dts/imx6ul-opos6uldev-u-boot.dts | 25 ++ > arch/arm/dts/imx6ul-opos6uldev.dts | 2 - > arch/arm/dts/imx6ul.dtsi | 13 +- > arch/arm/dts/imx7d-sdb-qspi-u-boot.dtsi | 10 + > arch/arm/dts/imx7d-sdb-qspi.dts | 44 ++ > arch/arm/dts/imx7d-sdb.dts | 6 +- > arch/arm/dts/imx7d.dtsi | 12 + > arch/arm/dts/imx7s.dtsi | 22 +- > arch/arm/include/asm/arch-mx25/imx-regs.h | 1 + > arch/arm/mach-imx/mx7/Makefile | 2 +- > arch/arm/mach-imx/mx7/psci-mx7.c | 472 > +++++++++++++++++++++- > arch/arm/mach-imx/mx7/psci-suspend.S | 67 +++ > arch/arm/mach-imx/mx7/soc.c | 103 +++++ > board/freescale/mx6sxsabreauto/mx6sxsabreauto.c | 24 -- > board/freescale/mx6sxsabresd/mx6sxsabresd.c | 25 -- > board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 208 ++-------- > board/freescale/mx7dsabresd/mx7dsabresd.c | 16 - > board/ge/bx50v3/Kconfig | 2 + > board/ge/bx50v3/bx50v3.c | 57 +-- > board/ge/common/Kconfig | 14 + > board/ge/common/vpd_reader.c | 57 ++- > board/ge/common/vpd_reader.h | 16 +- > board/ge/mx53ppd/Kconfig | 2 + > board/ge/mx53ppd/mx53ppd.c | 50 +-- > board/toradex/colibri_imx7/Kconfig | 42 +- > board/toradex/colibri_imx7/MAINTAINERS | 4 + > board/toradex/colibri_imx7/colibri_imx7.c | 41 +- > board/toradex/common/tdx-cfg-block.c | 7 +- > configs/ge_bx50v3_defconfig | 27 +- > configs/mx53ppd_defconfig | 29 +- > configs/mx6sxsabreauto_defconfig | 2 + > configs/mx6sxsabresd_defconfig | 7 + > configs/mx6ul_14x14_evk_defconfig | 17 +- > configs/mx6ul_9x9_evk_defconfig | 20 +- > configs/mx7dsabresd_qspi_defconfig | 84 ++++ > configs/opos6uldev_defconfig | 2 +- > drivers/bootcount/Kconfig | 21 +- > drivers/bootcount/bootcount_i2c.c | 78 +++- > drivers/watchdog/Makefile | 2 +- > include/configs/cl-som-imx7.h | 2 - > include/configs/colibri_imx7.h | 90 ++++- > include/configs/ge_bx50v3.h | 6 +- > include/configs/mx53ppd.h | 6 +- > include/configs/mx6sxsabresd.h | 4 + > include/configs/mx6ul_14x14_evk.h | 13 +- > include/configs/mx7dsabresd.h | 4 +- > 57 files changed, 2376 insertions(+), 421 deletions(-) This is a lot. I know I should have tagged -rc3 this past Monday, but forgot (and so, yeah, I need to get back into my habit of calendar reminders), but still, the release is 10 days away. It looks like there's a lot of new stuff in here too, not just clean-ups. Are you sure this is all appropriate at this stage? Thanks!
Hello Stefano, On Fri, Aug 31, 2018 at 10:08 AM Tom Rini <trini@konsulko.com> wrote: > On Fri, Aug 31, 2018 at 03:04:31PM +0200, Stefano Babic wrote: > > please pull from u-boot-imx, thanks ! We sent few patches for PICO and we'd like to get them merged for next release if possible. Is it possible for you to review them and see if they are fine for merging or need adjustments?
Hi Otavio, On 31/08/2018 20:53, Otavio Salvador wrote: > Hello Stefano, > > On Fri, Aug 31, 2018 at 10:08 AM Tom Rini <trini@konsulko.com> wrote: >> On Fri, Aug 31, 2018 at 03:04:31PM +0200, Stefano Babic wrote: >>> please pull from u-boot-imx, thanks ! > > We sent few patches for PICO and we'd like to get them merged for next > release if possible. Is it possible for you to review them and see if > they are fine for merging or need adjustments? I saw your patches, but Tom is already complaining that I have sent a PR with more changes as he expected. You just sent your patchset yesterday and, even if they are just for pico-imx6ul, I will pick them after release. Best regards, Stefano
On Fri, Aug 31, 2018 at 4:21 PM Stefano Babic <sbabic@denx.de> wrote: > On 31/08/2018 20:53, Otavio Salvador wrote: > > On Fri, Aug 31, 2018 at 10:08 AM Tom Rini <trini@konsulko.com> wrote: > >> On Fri, Aug 31, 2018 at 03:04:31PM +0200, Stefano Babic wrote: > >>> please pull from u-boot-imx, thanks ! > > > > We sent few patches for PICO and we'd like to get them merged for next > > release if possible. Is it possible for you to review them and see if > > they are fine for merging or need adjustments? > > I saw your patches, but Tom is already complaining that I have sent a PR > with more changes as he expected. You just sent your patchset yesterday > and, even if they are just for pico-imx6ul, I will pick them after release. Being a board specific I really see no high right but postponing it, is fine for sure. If possible, provide some feedback so I can rework anything need.
On 31/08/2018 15:07, Tom Rini wrote: > On Fri, Aug 31, 2018 at 03:04:31PM +0200, Stefano Babic wrote: >> Hi Tom, >> >> please pull from u-boot-imx, thanks ! >> >> The following changes since commit 11ed312896c5f5814064c5d45dcb2f53dc121437: >> >> configs: am57xx: change default board name to beagle_x15 (2018-08-26 >> 12:26:16 -0400) >> >> are available in the Git repository at: >> >> git://www.denx.de/git/u-boot-imx.git master >> >> for you to fetch changes up to 2846e663fd62200a189bba357135e284a379a38b: >> >> imx: missing CONFIG_MII in mx7dsabresd_qspi_defconfig (2018-08-31 >> 12:08:43 +0200) >> >> ---------------------------------------------------------------- >> Alex Kiernan (1): >> Cleanup CONFIG_BOOTDELAY on cl-som-imx7 >> >> Anson Huang (3): >> imx: mx7: psci: improve cpu hotplug flow >> imx: mx7: add gpc initialization for low power mode >> imx: mx7: add system suspend/resume support >> >> Denis Zalevskiy (6): >> board: ge: Remove EEPROM bus param from read_vpd() >> board: ge: Move VPD EEPROM configuration to the defconfig >> bootcount: i2c: Add bus switching to the I2C bootcount driver >> bootcount: Configure length limit for I2C bootcount >> board: ge: Move VPD reading to the vpd_reader >> board: ge: Store bootcount in EEPROM on PPD and Bx50v3 >> >> Martin Kaiser (1): >> watchdog: mx25: use the imx_watchdog driver for mx25 >> >> Stefan Agner (2): >> board: toradex: common: fail gracefully on missing NAND chip >> colibri_imx7_emmc: add Colibri iMX7D 1GB (eMMC) module support >> >> Stefano Babic (2): >> Merge branch 'master' of git://git.denx.de/u-boot into master >> imx: missing CONFIG_MII in mx7dsabresd_qspi_defconfig >> >> Sébastien Szymanski (1): >> ARM: opos6ul: make the board boot again >> >> Ye Li (6): >> imx: imx6sx-sdb: Enable DM QSPI driver >> imx: imx6sx-sabreauto: convert to use DM QSPI driver >> imx: imx7d-sdb: Add DM QSPI support >> dts: imx6ul: Update alias to support DM >> dts: imx6ul_evk: Add DTS files for 14x14 EVK and 9x9 EVK boards >> imx: imx6ul_evk: Enable DM driver for iMX6UL EVK u-boot >> >> arch/arm/dts/Makefile | 7 +- >> arch/arm/dts/imx6sx-sabreauto-u-boot.dtsi | 16 + >> arch/arm/dts/imx6sx-sabreauto.dts | 40 ++ >> arch/arm/dts/imx6sx-sdb-u-boot.dtsi | 16 + >> arch/arm/dts/imx6sx.dtsi | 12 +- >> arch/arm/dts/imx6ul-14x14-evk-u-boot.dtsi | 10 + >> arch/arm/dts/imx6ul-14x14-evk.dts | 427 +++++++++++++++++++ >> arch/arm/dts/imx6ul-9x9-evk-u-boot.dtsi | 10 + >> arch/arm/dts/imx6ul-9x9-evk.dts | 471 >> +++++++++++++++++++++ >> arch/arm/dts/imx6ul-opos6ul-u-boot.dtsi | 28 ++ >> arch/arm/dts/imx6ul-opos6ul.dtsi | 2 - >> arch/arm/dts/imx6ul-opos6uldev-u-boot.dts | 25 ++ >> arch/arm/dts/imx6ul-opos6uldev.dts | 2 - >> arch/arm/dts/imx6ul.dtsi | 13 +- >> arch/arm/dts/imx7d-sdb-qspi-u-boot.dtsi | 10 + >> arch/arm/dts/imx7d-sdb-qspi.dts | 44 ++ >> arch/arm/dts/imx7d-sdb.dts | 6 +- >> arch/arm/dts/imx7d.dtsi | 12 + >> arch/arm/dts/imx7s.dtsi | 22 +- >> arch/arm/include/asm/arch-mx25/imx-regs.h | 1 + >> arch/arm/mach-imx/mx7/Makefile | 2 +- >> arch/arm/mach-imx/mx7/psci-mx7.c | 472 >> +++++++++++++++++++++- >> arch/arm/mach-imx/mx7/psci-suspend.S | 67 +++ >> arch/arm/mach-imx/mx7/soc.c | 103 +++++ >> board/freescale/mx6sxsabreauto/mx6sxsabreauto.c | 24 -- >> board/freescale/mx6sxsabresd/mx6sxsabresd.c | 25 -- >> board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 208 ++-------- >> board/freescale/mx7dsabresd/mx7dsabresd.c | 16 - >> board/ge/bx50v3/Kconfig | 2 + >> board/ge/bx50v3/bx50v3.c | 57 +-- >> board/ge/common/Kconfig | 14 + >> board/ge/common/vpd_reader.c | 57 ++- >> board/ge/common/vpd_reader.h | 16 +- >> board/ge/mx53ppd/Kconfig | 2 + >> board/ge/mx53ppd/mx53ppd.c | 50 +-- >> board/toradex/colibri_imx7/Kconfig | 42 +- >> board/toradex/colibri_imx7/MAINTAINERS | 4 + >> board/toradex/colibri_imx7/colibri_imx7.c | 41 +- >> board/toradex/common/tdx-cfg-block.c | 7 +- >> configs/ge_bx50v3_defconfig | 27 +- >> configs/mx53ppd_defconfig | 29 +- >> configs/mx6sxsabreauto_defconfig | 2 + >> configs/mx6sxsabresd_defconfig | 7 + >> configs/mx6ul_14x14_evk_defconfig | 17 +- >> configs/mx6ul_9x9_evk_defconfig | 20 +- >> configs/mx7dsabresd_qspi_defconfig | 84 ++++ >> configs/opos6uldev_defconfig | 2 +- >> drivers/bootcount/Kconfig | 21 +- >> drivers/bootcount/bootcount_i2c.c | 78 +++- >> drivers/watchdog/Makefile | 2 +- >> include/configs/cl-som-imx7.h | 2 - >> include/configs/colibri_imx7.h | 90 ++++- >> include/configs/ge_bx50v3.h | 6 +- >> include/configs/mx53ppd.h | 6 +- >> include/configs/mx6sxsabresd.h | 4 + >> include/configs/mx6ul_14x14_evk.h | 13 +- >> include/configs/mx7dsabresd.h | 4 +- >> 57 files changed, 2376 insertions(+), 421 deletions(-) > > This is a lot. I know I should have tagged -rc3 this past Monday, but > forgot (and so, yeah, I need to get back into my habit of calendar > reminders), but still, the release is 10 days away. It looks like > there's a lot of new stuff in here too, not just clean-ups. Are you > sure this is all appropriate at this stage? Thanks! Several of them are fixes and I got reminder for the submitter to psuh them from the releases. These are from Anson and Stefan. I merged Ye's patches sometime ago, but I have not sent any PR after that.Sebastien's partch is a fix, too, and I merge GE's board because patches are quite old, ready to be merged and related just to the GE boards. I had to fix a broken board after merging, so my is also a fix. So yes, I think they are fixes for the release. It is just that I picked modt of them quite late because I had no time to do this before. Thanks, Stefano
On Fri, Aug 31, 2018 at 03:04:31PM +0200, Stefano Babic wrote: > Hi Tom, > > please pull from u-boot-imx, thanks ! > > The following changes since commit 11ed312896c5f5814064c5d45dcb2f53dc121437: > > configs: am57xx: change default board name to beagle_x15 (2018-08-26 > 12:26:16 -0400) > > are available in the Git repository at: > > git://www.denx.de/git/u-boot-imx.git master > > for you to fetch changes up to 2846e663fd62200a189bba357135e284a379a38b: > > imx: missing CONFIG_MII in mx7dsabresd_qspi_defconfig (2018-08-31 > 12:08:43 +0200) > OK, NAK for the following problems: - Fail to build: https://travis-ci.org/trini/u-boot/jobs/423197300 The failing board is ids8313 and it's failing to configure as CONFIG_SYS_BOOTCOUNT_I2C_BUS needs to be set, and isn't - In looking into the above I see configs/ge_bx50v3_defconfig and configs/mx53ppd_defconfig and a few more have a bunch of comments added to it. These will be blown away on the next re-sync. Comments need to go into the board README or something not an auto-generated file. - So I start reading the whole diff and I see: commit 8e00d802e402d2a6734a88ebeb77a70efcfc354c Author: Sébastien Szymanski <sebastien.szymanski@armadeus.com> Date: Wed Jul 25 14:47:53 2018 +0200 ARM: opos6ul: make the board boot again Which is wrong. The -u-boot.dtsi file is automatically included and should have all of the U-Boot specific DTS changes. - And since the above big real problems exist I'm going to point out for you to fix: WARNING: no status info for 'mx7dsabresd_qspi' WARNING: no maintainers for 'mx7dsabresd_qspi' Rather than fix it myself like I was going to before I found the other issues.
Hi Tom, > On 1 Sep 2018, at 13:37, Tom Rini <trini@konsulko.com> wrote: > > - So I start reading the whole diff and I see: > commit 8e00d802e402d2a6734a88ebeb77a70efcfc354c > Author: Sébastien Szymanski <sebastien.szymanski@armadeus.com> > Date: Wed Jul 25 14:47:53 2018 +0200 > > ARM: opos6ul: make the board boot again > > Which is wrong. The -u-boot.dtsi file is automatically included and > should have all of the U-Boot specific DTS changes. > :( I don’t understand your comment. What -u-boot.dtsi file is automatically included ? I have put all the U-Boot specific DTS changes in imx6ul-opos6ul-u-boot.dtsi and imx6u-opos6uldev-u-boot.dts files. Regards, > > -- > Tom > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot -- Sébastien Szymanski Software engineer, Armadeus Systems Tel: +33 (0)9 72 29 41 44 Fax: +33 (0)9 72 28 79 26
On Sun, Sep 02, 2018 at 03:20:25PM +0200, Sébastien Szymanski wrote: > Hi Tom, > > > On 1 Sep 2018, at 13:37, Tom Rini <trini@konsulko.com> wrote: > > > > - So I start reading the whole diff and I see: > > commit 8e00d802e402d2a6734a88ebeb77a70efcfc354c > > Author: Sébastien Szymanski <sebastien.szymanski@armadeus.com> > > Date: Wed Jul 25 14:47:53 2018 +0200 > > > > ARM: opos6ul: make the board boot again > > > > Which is wrong. The -u-boot.dtsi file is automatically included and > > should have all of the U-Boot specific DTS changes. > > > > :( > > I don’t understand your comment. What -u-boot.dtsi file is > automatically included ? I have put all the U-Boot specific DTS > changes in imx6ul-opos6ul-u-boot.dtsi and imx6u-opos6uldev-u-boot.dts > files. Take a look at the u_boot_dtsi_options logic in scripts/Makefile.lib for all of the possible dtsi files that will be automatically included if found. This is so that end the end for a given board you should be able to drop in the dts file(s) from Linux, create a -u-boot.dtsi and then have things work, no changes to the upstream files required nor specifying an otherwise unusual name.
On 01/09/2018 13:37, Tom Rini wrote: > On Fri, Aug 31, 2018 at 03:04:31PM +0200, Stefano Babic wrote: > >> Hi Tom, >> >> please pull from u-boot-imx, thanks ! >> >> The following changes since commit 11ed312896c5f5814064c5d45dcb2f53dc121437: >> >> configs: am57xx: change default board name to beagle_x15 (2018-08-26 >> 12:26:16 -0400) >> >> are available in the Git repository at: >> >> git://www.denx.de/git/u-boot-imx.git master >> >> for you to fetch changes up to 2846e663fd62200a189bba357135e284a379a38b: >> >> imx: missing CONFIG_MII in mx7dsabresd_qspi_defconfig (2018-08-31 >> 12:08:43 +0200) >> > > OK, NAK for the following problems: > - Fail to build: https://travis-ci.org/trini/u-boot/jobs/423197300 > The failing board is ids8313 and it's failing to configure as > CONFIG_SYS_BOOTCOUNT_I2C_BUS needs to be set, and isn't It looks wrong how I verify the whole build. Running buildman on my host, all boards were built. I will > - In looking into the above I see configs/ge_bx50v3_defconfig and > configs/mx53ppd_defconfig and a few more have a bunch of comments > added to it. These will be blown away on the next re-sync. Comments > need to go into the board README or something not an auto-generated > file. I saw this, but if the board maintainer won't use "make savedefonfig" to generate its own defconfig, I have not blocked this if this lead to a successful build. > - So I start reading the whole diff and I see: > commit 8e00d802e402d2a6734a88ebeb77a70efcfc354c > Author: Sébastien Szymanski <sebastien.szymanski@armadeus.com> > Date: Wed Jul 25 14:47:53 2018 +0200 > > ARM: opos6ul: make the board boot again > > Which is wrong. The -u-boot.dtsi file is automatically included and > should have all of the U-Boot specific DTS changes. I have to understand why my build was successful... > > - And since the above big real problems exist I'm going to point out for > you to fix: > WARNING: no status info for 'mx7dsabresd_qspi' > WARNING: no maintainers for 'mx7dsabresd_qspi' > Note this, they will be fixed. > Rather than fix it myself like I was going to before I found the other > issues. > Regards, Stefano
On Sun, Sep 02, 2018 at 07:06:06PM +0200, Stefano Babic wrote: > > > On 01/09/2018 13:37, Tom Rini wrote: > > On Fri, Aug 31, 2018 at 03:04:31PM +0200, Stefano Babic wrote: > > > >> Hi Tom, > >> > >> please pull from u-boot-imx, thanks ! > >> > >> The following changes since commit 11ed312896c5f5814064c5d45dcb2f53dc121437: > >> > >> configs: am57xx: change default board name to beagle_x15 (2018-08-26 > >> 12:26:16 -0400) > >> > >> are available in the Git repository at: > >> > >> git://www.denx.de/git/u-boot-imx.git master > >> > >> for you to fetch changes up to 2846e663fd62200a189bba357135e284a379a38b: > >> > >> imx: missing CONFIG_MII in mx7dsabresd_qspi_defconfig (2018-08-31 > >> 12:08:43 +0200) > >> > > > > OK, NAK for the following problems: > > - Fail to build: https://travis-ci.org/trini/u-boot/jobs/423197300 > > The failing board is ids8313 and it's failing to configure as > > CONFIG_SYS_BOOTCOUNT_I2C_BUS needs to be set, and isn't > > It looks wrong how I verify the whole build. Running buildman on my > host, all boards were built. I will That's odd. Are you building the world, or just arm? I noticed this since my non-travis world build got stuck and then confirmed it just trying to build that single PowerPC board. > > - In looking into the above I see configs/ge_bx50v3_defconfig and > > configs/mx53ppd_defconfig and a few more have a bunch of comments > > added to it. These will be blown away on the next re-sync. Comments > > need to go into the board README or something not an auto-generated > > file. > > I saw this, but if the board maintainer won't use "make savedefonfig" to > generate its own defconfig, I have not blocked this if this lead to a > successful build. It needs to be a rejection error, I try and remember to re-sync all of the defconfigs at least before the final release and if I'm doing it right, before the -rcs too. > > - So I start reading the whole diff and I see: > > commit 8e00d802e402d2a6734a88ebeb77a70efcfc354c > > Author: Sébastien Szymanski <sebastien.szymanski@armadeus.com> > > Date: Wed Jul 25 14:47:53 2018 +0200 > > > > ARM: opos6ul: make the board boot again > > > > Which is wrong. The -u-boot.dtsi file is automatically included and > > should have all of the U-Boot specific DTS changes. > > I have to understand why my build was successful... It's not a fatal problem, it's just not doing things the right way. > > - And since the above big real problems exist I'm going to point out for > > you to fix: > > WARNING: no status info for 'mx7dsabresd_qspi' > > WARNING: no maintainers for 'mx7dsabresd_qspi' > > > > Note this, they will be fixed. Fabio posted a patch for this one BTW.
On 02/09/2018 19:11, Tom Rini wrote: > On Sun, Sep 02, 2018 at 07:06:06PM +0200, Stefano Babic wrote: >> >> >> On 01/09/2018 13:37, Tom Rini wrote: >>> On Fri, Aug 31, 2018 at 03:04:31PM +0200, Stefano Babic wrote: >>> >>>> Hi Tom, >>>> >>>> please pull from u-boot-imx, thanks ! >>>> >>>> The following changes since commit 11ed312896c5f5814064c5d45dcb2f53dc121437: >>>> >>>> configs: am57xx: change default board name to beagle_x15 (2018-08-26 >>>> 12:26:16 -0400) >>>> >>>> are available in the Git repository at: >>>> >>>> git://www.denx.de/git/u-boot-imx.git master >>>> >>>> for you to fetch changes up to 2846e663fd62200a189bba357135e284a379a38b: >>>> >>>> imx: missing CONFIG_MII in mx7dsabresd_qspi_defconfig (2018-08-31 >>>> 12:08:43 +0200) >>>> >>> >>> OK, NAK for the following problems: >>> - Fail to build: https://travis-ci.org/trini/u-boot/jobs/423197300 >>> The failing board is ids8313 and it's failing to configure as >>> CONFIG_SYS_BOOTCOUNT_I2C_BUS needs to be set, and isn't >> >> It looks wrong how I verify the whole build. Running buildman on my >> host, all boards were built. I will > > That's odd. Are you building the world, or just arm? I am building i.MX, that could be the cause: ./tools/buildman/buildman imx mx25 mx27 mx31 mx35 mxs mx5 mx6 mx7 vf610 > I noticed this > since my non-travis world build got stuck and then confirmed it just > trying to build that single PowerPC board. ok > >>> - In looking into the above I see configs/ge_bx50v3_defconfig and >>> configs/mx53ppd_defconfig and a few more have a bunch of comments >>> added to it. These will be blown away on the next re-sync. Comments >>> need to go into the board README or something not an auto-generated >>> file. >> >> I saw this, but if the board maintainer won't use "make savedefonfig" to >> generate its own defconfig, I have not blocked this if this lead to a >> successful build. > > It needs to be a rejection error, I try and remember to re-sync all of > the defconfigs at least before the final release and if I'm doing it > right, before the -rcs too. ok > >>> - So I start reading the whole diff and I see: >>> commit 8e00d802e402d2a6734a88ebeb77a70efcfc354c >>> Author: Sébastien Szymanski <sebastien.szymanski@armadeus.com> >>> Date: Wed Jul 25 14:47:53 2018 +0200 >>> >>> ARM: opos6ul: make the board boot again >>> >>> Which is wrong. The -u-boot.dtsi file is automatically included and >>> should have all of the U-Boot specific DTS changes. >> >> I have to understand why my build was successful... > > It's not a fatal problem, it's just not doing things the right way. > >>> - And since the above big real problems exist I'm going to point out for >>> you to fix: >>> WARNING: no status info for 'mx7dsabresd_qspi' >>> WARNING: no maintainers for 'mx7dsabresd_qspi' >>> >> >> Note this, they will be fixed. > > Fabio posted a patch for this one BTW. Thanks, I pick it up. Stefano
On 02/09/2018 16:15, Tom Rini wrote: > On Sun, Sep 02, 2018 at 03:20:25PM +0200, Sébastien Szymanski wrote: > >> Hi Tom, >> >>> On 1 Sep 2018, at 13:37, Tom Rini <trini@konsulko.com> wrote: >>> >>> - So I start reading the whole diff and I see: >>> commit 8e00d802e402d2a6734a88ebeb77a70efcfc354c >>> Author: Sébastien Szymanski <sebastien.szymanski@armadeus.com> >>> Date: Wed Jul 25 14:47:53 2018 +0200 >>> >>> ARM: opos6ul: make the board boot again >>> >>> Which is wrong. The -u-boot.dtsi file is automatically included and >>> should have all of the U-Boot specific DTS changes. >>> >> >> :( >> >> I don’t understand your comment. What -u-boot.dtsi file is >> automatically included ? I have put all the U-Boot specific DTS >> changes in imx6ul-opos6ul-u-boot.dtsi and imx6u-opos6uldev-u-boot.dts >> files. > > Take a look at the u_boot_dtsi_options logic in scripts/Makefile.lib for > all of the possible dtsi files that will be automatically included if > found. This is so that end the end for a given board you should be able > to drop in the dts file(s) from Linux, create a -u-boot.dtsi and then > have things work, no changes to the upstream files required nor > specifying an otherwise unusual name. > I revert the patch on u-boot.imx to get a clean build again that can be accepted by Tom. Regards, Stefano
Hi Tom, please pull from u-boot-imx, thanks ! The following changes since commit 11ed312896c5f5814064c5d45dcb2f53dc121437: configs: am57xx: change default board name to beagle_x15 (2018-08-26 12:26:16 -0400) are available in the Git repository at: git://www.denx.de/git/u-boot-imx.git master for you to fetch changes up to 2846e663fd62200a189bba357135e284a379a38b: imx: missing CONFIG_MII in mx7dsabresd_qspi_defconfig (2018-08-31 12:08:43 +0200) ---------------------------------------------------------------- Alex Kiernan (1): Cleanup CONFIG_BOOTDELAY on cl-som-imx7 Anson Huang (3): imx: mx7: psci: improve cpu hotplug flow imx: mx7: add gpc initialization for low power mode imx: mx7: add system suspend/resume support Denis Zalevskiy (6): board: ge: Remove EEPROM bus param from read_vpd() board: ge: Move VPD EEPROM configuration to the defconfig bootcount: i2c: Add bus switching to the I2C bootcount driver bootcount: Configure length limit for I2C bootcount board: ge: Move VPD reading to the vpd_reader board: ge: Store bootcount in EEPROM on PPD and Bx50v3 Martin Kaiser (1): watchdog: mx25: use the imx_watchdog driver for mx25 Stefan Agner (2): board: toradex: common: fail gracefully on missing NAND chip colibri_imx7_emmc: add Colibri iMX7D 1GB (eMMC) module support Stefano Babic (2): Merge branch 'master' of git://git.denx.de/u-boot into master imx: missing CONFIG_MII in mx7dsabresd_qspi_defconfig Sébastien Szymanski (1): ARM: opos6ul: make the board boot again Ye Li (6): imx: imx6sx-sdb: Enable DM QSPI driver imx: imx6sx-sabreauto: convert to use DM QSPI driver imx: imx7d-sdb: Add DM QSPI support dts: imx6ul: Update alias to support DM dts: imx6ul_evk: Add DTS files for 14x14 EVK and 9x9 EVK boards imx: imx6ul_evk: Enable DM driver for iMX6UL EVK u-boot arch/arm/dts/Makefile | 7 +- arch/arm/dts/imx6sx-sabreauto-u-boot.dtsi | 16 + arch/arm/dts/imx6sx-sabreauto.dts | 40 ++ arch/arm/dts/imx6sx-sdb-u-boot.dtsi | 16 + arch/arm/dts/imx6sx.dtsi | 12 +- arch/arm/dts/imx6ul-14x14-evk-u-boot.dtsi | 10 + arch/arm/dts/imx6ul-14x14-evk.dts | 427 +++++++++++++++++++ arch/arm/dts/imx6ul-9x9-evk-u-boot.dtsi | 10 + arch/arm/dts/imx6ul-9x9-evk.dts | 471 +++++++++++++++++++++ arch/arm/dts/imx6ul-opos6ul-u-boot.dtsi | 28 ++ arch/arm/dts/imx6ul-opos6ul.dtsi | 2 - arch/arm/dts/imx6ul-opos6uldev-u-boot.dts | 25 ++ arch/arm/dts/imx6ul-opos6uldev.dts | 2 - arch/arm/dts/imx6ul.dtsi | 13 +- arch/arm/dts/imx7d-sdb-qspi-u-boot.dtsi | 10 + arch/arm/dts/imx7d-sdb-qspi.dts | 44 ++ arch/arm/dts/imx7d-sdb.dts | 6 +- arch/arm/dts/imx7d.dtsi | 12 + arch/arm/dts/imx7s.dtsi | 22 +- arch/arm/include/asm/arch-mx25/imx-regs.h | 1 + arch/arm/mach-imx/mx7/Makefile | 2 +- arch/arm/mach-imx/mx7/psci-mx7.c | 472 +++++++++++++++++++++- arch/arm/mach-imx/mx7/psci-suspend.S | 67 +++ arch/arm/mach-imx/mx7/soc.c | 103 +++++ board/freescale/mx6sxsabreauto/mx6sxsabreauto.c | 24 -- board/freescale/mx6sxsabresd/mx6sxsabresd.c | 25 -- board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 208 ++-------- board/freescale/mx7dsabresd/mx7dsabresd.c | 16 - board/ge/bx50v3/Kconfig | 2 + board/ge/bx50v3/bx50v3.c | 57 +-- board/ge/common/Kconfig | 14 + board/ge/common/vpd_reader.c | 57 ++- board/ge/common/vpd_reader.h | 16 +- board/ge/mx53ppd/Kconfig | 2 + board/ge/mx53ppd/mx53ppd.c | 50 +-- board/toradex/colibri_imx7/Kconfig | 42 +- board/toradex/colibri_imx7/MAINTAINERS | 4 + board/toradex/colibri_imx7/colibri_imx7.c | 41 +- board/toradex/common/tdx-cfg-block.c | 7 +- configs/ge_bx50v3_defconfig | 27 +- configs/mx53ppd_defconfig | 29 +- configs/mx6sxsabreauto_defconfig | 2 + configs/mx6sxsabresd_defconfig | 7 + configs/mx6ul_14x14_evk_defconfig | 17 +- configs/mx6ul_9x9_evk_defconfig | 20 +- configs/mx7dsabresd_qspi_defconfig | 84 ++++ configs/opos6uldev_defconfig | 2 +- drivers/bootcount/Kconfig | 21 +- drivers/bootcount/bootcount_i2c.c | 78 +++- drivers/watchdog/Makefile | 2 +- include/configs/cl-som-imx7.h | 2 - include/configs/colibri_imx7.h | 90 ++++- include/configs/ge_bx50v3.h | 6 +- include/configs/mx53ppd.h | 6 +- include/configs/mx6sxsabresd.h | 4 + include/configs/mx6ul_14x14_evk.h | 13 +- include/configs/mx7dsabresd.h | 4 +- 57 files changed, 2376 insertions(+), 421 deletions(-) create mode 100644 arch/arm/dts/imx6sx-sabreauto-u-boot.dtsi create mode 100644 arch/arm/dts/imx6sx-sdb-u-boot.dtsi create mode 100644 arch/arm/dts/imx6ul-14x14-evk-u-boot.dtsi create mode 100644 arch/arm/dts/imx6ul-14x14-evk.dts create mode 100644 arch/arm/dts/imx6ul-9x9-evk-u-boot.dtsi create mode 100644 arch/arm/dts/imx6ul-9x9-evk.dts create mode 100644 arch/arm/dts/imx6ul-opos6ul-u-boot.dtsi create mode 100644 arch/arm/dts/imx6ul-opos6uldev-u-boot.dts create mode 100644 arch/arm/dts/imx7d-sdb-qspi-u-boot.dtsi create mode 100644 arch/arm/dts/imx7d-sdb-qspi.dts create mode 100644 arch/arm/mach-imx/mx7/psci-suspend.S create mode 100644 board/ge/common/Kconfig create mode 100644 configs/mx7dsabresd_qspi_defconfig