Message ID | 47f84fa8-ca1d-162c-5ad7-00af3bf73c96@denx.de |
---|---|
State | Changes Requested |
Delegated to: | Tom Rini |
Headers | show |
Series | [U-Boot,PULL] Please pull u-boot-imx: u-boot-imx-20181214 | expand |
On Fri, Dec 14, 2018 at 02:39:04PM +0100, Stefano Babic wrote: > Hi Tom, > > please pull from u-boot-imx, thanks ! > > > The following changes since commit c49aff3e66b930aa06936afee401cf5e19377958: > > Merge branch 'master' of git://git.denx.de/u-boot-sunxi (2018-12-07 > 19:02:01 -0500) > > are available in the Git repository at: > > git://www.denx.de/git/u-boot-imx.git tags/u-boot-imx-20181214 > > for you to fetch changes up to 5d0f0b567c78197db6f2f47c89a18b44ade28284: > > pico-imx7d: Increase the CONFIG_ENV_OFFSET size (2018-12-14 14:30:57 > +0100) > NAK. You're failing the "no new defconfigs without MAINTAINERS" test in Travis: https://travis-ci.org/trini/u-boot/jobs/468004873#L975 Also, Wolfgang's patch is breaking guruplug,sheevaplug,linkit-smart-7688-ram,colibri_pxa270,linkit-smart-7688,gardena-smart-gateway-mt7688-ram,gardena-smart-gateway-mt7688 in my specific Debian chroot and I need to dig in more to provide something useful there other than "it fails". So please drop that for now too. Thanks!
On 14/12/18 19:37, Tom Rini wrote: > On Fri, Dec 14, 2018 at 02:39:04PM +0100, Stefano Babic wrote: > >> Hi Tom, >> >> please pull from u-boot-imx, thanks ! >> >> >> The following changes since commit c49aff3e66b930aa06936afee401cf5e19377958: >> >> Merge branch 'master' of git://git.denx.de/u-boot-sunxi (2018-12-07 >> 19:02:01 -0500) >> >> are available in the Git repository at: >> >> git://www.denx.de/git/u-boot-imx.git tags/u-boot-imx-20181214 >> >> for you to fetch changes up to 5d0f0b567c78197db6f2f47c89a18b44ade28284: >> >> pico-imx7d: Increase the CONFIG_ENV_OFFSET size (2018-12-14 14:30:57 >> +0100) >> > > NAK. You're failing the "no new defconfigs without MAINTAINERS" test in > Travis: https://travis-ci.org/trini/u-boot/jobs/468004873#L975 > I see, I'll ix it. > Also, Wolfgang's patch is breaking > guruplug,sheevaplug,linkit-smart-7688-ram,colibri_pxa270,linkit-smart-7688,gardena-smart-gateway-mt7688-ram,gardena-smart-gateway-mt7688 > in my specific Debian chroot and I need to dig in more to provide > something useful there other than "it fails". So please drop that for > now too. I do, I put Fabio's pico-7d in wait queue as this depends on Wolfgang's Regards, Stefano
On Fri, Dec 14, 2018 at 11:03:59PM +0100, Stefano Babic wrote: > > > On 14/12/18 19:37, Tom Rini wrote: > > On Fri, Dec 14, 2018 at 02:39:04PM +0100, Stefano Babic wrote: > > > >> Hi Tom, > >> > >> please pull from u-boot-imx, thanks ! > >> > >> > >> The following changes since commit c49aff3e66b930aa06936afee401cf5e19377958: > >> > >> Merge branch 'master' of git://git.denx.de/u-boot-sunxi (2018-12-07 > >> 19:02:01 -0500) > >> > >> are available in the Git repository at: > >> > >> git://www.denx.de/git/u-boot-imx.git tags/u-boot-imx-20181214 > >> > >> for you to fetch changes up to 5d0f0b567c78197db6f2f47c89a18b44ade28284: > >> > >> pico-imx7d: Increase the CONFIG_ENV_OFFSET size (2018-12-14 14:30:57 > >> +0100) > >> > > > > NAK. You're failing the "no new defconfigs without MAINTAINERS" test in > > Travis: https://travis-ci.org/trini/u-boot/jobs/468004873#L975 > > > > I see, I'll ix it. > > > Also, Wolfgang's patch is breaking > > guruplug,sheevaplug,linkit-smart-7688-ram,colibri_pxa270,linkit-smart-7688,gardena-smart-gateway-mt7688-ram,gardena-smart-gateway-mt7688 > > in my specific Debian chroot and I need to dig in more to provide > > something useful there other than "it fails". So please drop that for > > now too. > > I do, I put Fabio's pico-7d in wait queue as this depends on Wolfgang's I replied to Wolfgang's patch with the problem and I suggest that pico-7d simply stop using >> as it's not going to work once we Kconfig migrate anyhow.
Hi Tom, On Fri, Dec 14, 2018 at 8:06 PM Tom Rini <trini@konsulko.com> wrote: > I replied to Wolfgang's patch with the problem and I suggest that > pico-7d simply stop using >> as it's not going to work once we Kconfig > migrate anyhow. pico-imx7d does not use >>. I sent 5 different versions of this patch and the initial ones do not depend on Wolfgang's patch, as I hardcoded the offset.
On Fri, Dec 14, 2018 at 08:09:18PM -0200, Fabio Estevam wrote: > Hi Tom, > > On Fri, Dec 14, 2018 at 8:06 PM Tom Rini <trini@konsulko.com> wrote: > > > I replied to Wolfgang's patch with the problem and I suggest that > > pico-7d simply stop using >> as it's not going to work once we Kconfig > > migrate anyhow. > > pico-imx7d does not use >>. > > I sent 5 different versions of this patch and the initial ones do not > depend on Wolfgang's patch, as I hardcoded the offset. OK, thanks.
Dear Stefano, > On Fri, Dec 14, 2018 at 02:39:04PM +0100, Stefano Babic wrote: > > > Hi Tom, > > > > please pull from u-boot-imx, thanks ! > > > > > > The following changes since commit > > c49aff3e66b930aa06936afee401cf5e19377958: > > > > Merge branch 'master' of git://git.denx.de/u-boot-sunxi > > (2018-12-07 19:02:01 -0500) > > > > are available in the Git repository at: > > > > git://www.denx.de/git/u-boot-imx.git tags/u-boot-imx-20181214 > > > > for you to fetch changes up to > > 5d0f0b567c78197db6f2f47c89a18b44ade28284: > > > > pico-imx7d: Increase the CONFIG_ENV_OFFSET size (2018-12-14 > > 14:30:57 +0100) > > > > NAK. You're failing the "no new defconfigs without MAINTAINERS" test > in Travis: https://travis-ci.org/trini/u-boot/jobs/468004873#L975 > > Also, Wolfgang's patch is breaking > guruplug,sheevaplug,linkit-smart-7688-ram,colibri_pxa270,linkit-smart-7688,gardena-smart-gateway-mt7688-ram,gardena-smart-gateway-mt7688 > in my specific Debian chroot and I need to dig in more to provide > something useful there other than "it fails". So please drop that for > now too. Thanks! > As this PR is not accepted; Stefano, could you also pull following changes (relevant for vybrid): http://patchwork.ozlabs.org/patch/1006731/ http://patchwork.ozlabs.org/patch/1006732/ http://patchwork.ozlabs.org/patch/1006733/ One of it: "nand: vybrid: Use calloc() instead of malloc() to allocate struct nfc" is a fix. The other two just add support for Vybrid's NFC controller in device tree. There shall be no issues with this code for in-tree boards. Thanks in advance and sorry for a late reply to this thread. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
On 16/12/18 22:12, Lukasz Majewski wrote: > Dear Stefano, > >> On Fri, Dec 14, 2018 at 02:39:04PM +0100, Stefano Babic wrote: >> >>> Hi Tom, >>> >>> please pull from u-boot-imx, thanks ! >>> >>> >>> The following changes since commit >>> c49aff3e66b930aa06936afee401cf5e19377958: >>> >>> Merge branch 'master' of git://git.denx.de/u-boot-sunxi >>> (2018-12-07 19:02:01 -0500) >>> >>> are available in the Git repository at: >>> >>> git://www.denx.de/git/u-boot-imx.git tags/u-boot-imx-20181214 >>> >>> for you to fetch changes up to >>> 5d0f0b567c78197db6f2f47c89a18b44ade28284: >>> >>> pico-imx7d: Increase the CONFIG_ENV_OFFSET size (2018-12-14 >>> 14:30:57 +0100) >>> >> >> NAK. You're failing the "no new defconfigs without MAINTAINERS" test >> in Travis: https://travis-ci.org/trini/u-boot/jobs/468004873#L975 >> >> Also, Wolfgang's patch is breaking >> guruplug,sheevaplug,linkit-smart-7688-ram,colibri_pxa270,linkit-smart-7688,gardena-smart-gateway-mt7688-ram,gardena-smart-gateway-mt7688 >> in my specific Debian chroot and I need to dig in more to provide >> something useful there other than "it fails". So please drop that for >> now too. Thanks! >> > > As this PR is not accepted; Stefano, could you also pull following > changes (relevant for vybrid): > > http://patchwork.ozlabs.org/patch/1006731/ > http://patchwork.ozlabs.org/patch/1006732/ > http://patchwork.ozlabs.org/patch/1006733/ > > One of it: > "nand: vybrid: Use calloc() instead of malloc() to allocate struct nfc" > is a fix. > > The other two just add support for Vybrid's NFC controller in device > tree. There shall be no issues with this code for in-tree boards. > > Thanks in advance and sorry for a late reply to this thread. > I have picked up the 3 patches, my build is running.. Best regards, Stefano