diff mbox series

arm64: zynqmp: Fix pwm-fan polarity

Message ID 4658ae8576882f5d28ad57ca74a7b798a546ec37.1722241096.git.michal.simek@amd.com
State Accepted
Commit e1ab56659829b92ceaf0f88457d62d15b73ec3b6
Delegated to: Michal Simek
Headers show
Series arm64: zynqmp: Fix pwm-fan polarity | expand

Commit Message

Michal Simek July 29, 2024, 8:18 a.m. UTC
From: Vishal Patel <vishal.patel@amd.com>

The correct operating mode for the fan is inversed (1). The
previous pwm driver implementation had a bug and the polarity
information was propagated incorrectly to the kernel. The normal (0)
polarity specified in the device tree was incorrectly clearing the
polarity bit in the counter control register. After the bug fix,
setting the polarity to inversed (1) in the device tree will clear
the polarity bit.

Signed-off-by: Vishal Patel <vishal.patel@amd.com>
Signed-off-by: Michal Simek <michal.simek@amd.com>
---

 arch/arm/dts/zynqmp-sm-k26-revA.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michal Simek Aug. 5, 2024, 2:11 p.m. UTC | #1
On 7/29/24 10:18, Michal Simek wrote:
> From: Vishal Patel <vishal.patel@amd.com>
> 
> The correct operating mode for the fan is inversed (1). The
> previous pwm driver implementation had a bug and the polarity
> information was propagated incorrectly to the kernel. The normal (0)
> polarity specified in the device tree was incorrectly clearing the
> polarity bit in the counter control register. After the bug fix,
> setting the polarity to inversed (1) in the device tree will clear
> the polarity bit.
> 
> Signed-off-by: Vishal Patel <vishal.patel@amd.com>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
> 
>   arch/arm/dts/zynqmp-sm-k26-revA.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/zynqmp-sm-k26-revA.dts b/arch/arm/dts/zynqmp-sm-k26-revA.dts
> index 5859e6cd8c23..d95a05e21592 100644
> --- a/arch/arm/dts/zynqmp-sm-k26-revA.dts
> +++ b/arch/arm/dts/zynqmp-sm-k26-revA.dts
> @@ -107,7 +107,7 @@
>   	pwm-fan {
>   		compatible = "pwm-fan";
>   		status = "okay";
> -		pwms = <&ttc0 2 40000 0>;
> +		pwms = <&ttc0 2 40000 1>;
>   	};
>   };
>   

Applied.
M
diff mbox series

Patch

diff --git a/arch/arm/dts/zynqmp-sm-k26-revA.dts b/arch/arm/dts/zynqmp-sm-k26-revA.dts
index 5859e6cd8c23..d95a05e21592 100644
--- a/arch/arm/dts/zynqmp-sm-k26-revA.dts
+++ b/arch/arm/dts/zynqmp-sm-k26-revA.dts
@@ -107,7 +107,7 @@ 
 	pwm-fan {
 		compatible = "pwm-fan";
 		status = "okay";
-		pwms = <&ttc0 2 40000 0>;
+		pwms = <&ttc0 2 40000 1>;
 	};
 };