diff mbox series

[1/4] imx: imxrt*: Fix binman breaking boot

Message ID 20241025020228.1686306-1-Mr.Bossman075@gmail.com
State Accepted
Commit 1ecbbdda5f1a6572ab803fadc3365369b718e74b
Delegated to: Fabio Estevam
Headers show
Series [1/4] imx: imxrt*: Fix binman breaking boot | expand

Commit Message

Jesse T Oct. 25, 2024, 2:02 a.m. UTC
The init_r parsing of U-Boot device tree to search the binman
information errors. set CONFIG_BINMAN_FDT to no to fix this.

Fixes: 7079eeb72fc ("imx: imxrt1050-evk: Add support for SPI flash booting
s")
Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
---
 configs/imxrt1020-evk_defconfig      | 1 +
 configs/imxrt1050-evk_defconfig      | 1 +
 configs/imxrt1050-evk_fspi_defconfig | 1 +
 configs/imxrt1170-evk_defconfig      | 1 +
 4 files changed, 4 insertions(+)

Comments

Simon Glass Oct. 27, 2024, 5:15 p.m. UTC | #1
On Fri, 25 Oct 2024 at 04:02, Jesse Taube <mr.bossman075@gmail.com> wrote:
>
> The init_r parsing of U-Boot device tree to search the binman
> information errors. set CONFIG_BINMAN_FDT to no to fix this.
>
> Fixes: 7079eeb72fc ("imx: imxrt1050-evk: Add support for SPI flash booting
> s")
> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> ---
>  configs/imxrt1020-evk_defconfig      | 1 +
>  configs/imxrt1050-evk_defconfig      | 1 +
>  configs/imxrt1050-evk_fspi_defconfig | 1 +
>  configs/imxrt1170-evk_defconfig      | 1 +
>  4 files changed, 4 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

Hmm, so why is the binman node missing?



>
> diff --git a/configs/imxrt1020-evk_defconfig b/configs/imxrt1020-evk_defconfig
> index 5865d41a741..58a3e92ce08 100644
> --- a/configs/imxrt1020-evk_defconfig
> +++ b/configs/imxrt1020-evk_defconfig
> @@ -67,6 +67,7 @@ CONFIG_FSL_LPUART=y
>  CONFIG_TIMER=y
>  CONFIG_SPL_TIMER=y
>  CONFIG_IMX_GPT_TIMER=y
> +# CONFIG_BINMAN_FDT is not set
>  CONFIG_SHA1=y
>  CONFIG_SHA256=y
>  CONFIG_HEXDUMP=y
> diff --git a/configs/imxrt1050-evk_defconfig b/configs/imxrt1050-evk_defconfig
> index f8b85398b79..2653efac148 100644
> --- a/configs/imxrt1050-evk_defconfig
> +++ b/configs/imxrt1050-evk_defconfig
> @@ -84,5 +84,6 @@ CONFIG_VIDEO_MXS=y
>  CONFIG_SPLASH_SCREEN=y
>  CONFIG_SPLASH_SCREEN_ALIGN=y
>  CONFIG_BMP_16BPP=y
> +# CONFIG_BINMAN_FDT is not set
>  CONFIG_SHA256=y
>  CONFIG_HEXDUMP=y
> diff --git a/configs/imxrt1050-evk_fspi_defconfig b/configs/imxrt1050-evk_fspi_defconfig
> index 73001ffe161..95b5b56ece7 100644
> --- a/configs/imxrt1050-evk_fspi_defconfig
> +++ b/configs/imxrt1050-evk_fspi_defconfig
> @@ -85,6 +85,7 @@ CONFIG_VIDEO_MXS=y
>  CONFIG_SPLASH_SCREEN=y
>  CONFIG_SPLASH_SCREEN_ALIGN=y
>  CONFIG_BMP_16BPP=y
> +# CONFIG_BINMAN_FDT is not set
>  CONFIG_SHA256=y
>  CONFIG_HEXDUMP=y
>  CONFIG_FSPI_CONF_HEADER=y
> diff --git a/configs/imxrt1170-evk_defconfig b/configs/imxrt1170-evk_defconfig
> index 5f28c22e66c..487da275c62 100644
> --- a/configs/imxrt1170-evk_defconfig
> +++ b/configs/imxrt1170-evk_defconfig
> @@ -68,3 +68,4 @@ CONFIG_FSL_LPUART=y
>  CONFIG_TIMER=y
>  CONFIG_SPL_TIMER=y
>  CONFIG_IMX_GPT_TIMER=y
> +# CONFIG_BINMAN_FDT is not set
> --
> 2.45.2
>
diff mbox series

Patch

diff --git a/configs/imxrt1020-evk_defconfig b/configs/imxrt1020-evk_defconfig
index 5865d41a741..58a3e92ce08 100644
--- a/configs/imxrt1020-evk_defconfig
+++ b/configs/imxrt1020-evk_defconfig
@@ -67,6 +67,7 @@  CONFIG_FSL_LPUART=y
 CONFIG_TIMER=y
 CONFIG_SPL_TIMER=y
 CONFIG_IMX_GPT_TIMER=y
+# CONFIG_BINMAN_FDT is not set
 CONFIG_SHA1=y
 CONFIG_SHA256=y
 CONFIG_HEXDUMP=y
diff --git a/configs/imxrt1050-evk_defconfig b/configs/imxrt1050-evk_defconfig
index f8b85398b79..2653efac148 100644
--- a/configs/imxrt1050-evk_defconfig
+++ b/configs/imxrt1050-evk_defconfig
@@ -84,5 +84,6 @@  CONFIG_VIDEO_MXS=y
 CONFIG_SPLASH_SCREEN=y
 CONFIG_SPLASH_SCREEN_ALIGN=y
 CONFIG_BMP_16BPP=y
+# CONFIG_BINMAN_FDT is not set
 CONFIG_SHA256=y
 CONFIG_HEXDUMP=y
diff --git a/configs/imxrt1050-evk_fspi_defconfig b/configs/imxrt1050-evk_fspi_defconfig
index 73001ffe161..95b5b56ece7 100644
--- a/configs/imxrt1050-evk_fspi_defconfig
+++ b/configs/imxrt1050-evk_fspi_defconfig
@@ -85,6 +85,7 @@  CONFIG_VIDEO_MXS=y
 CONFIG_SPLASH_SCREEN=y
 CONFIG_SPLASH_SCREEN_ALIGN=y
 CONFIG_BMP_16BPP=y
+# CONFIG_BINMAN_FDT is not set
 CONFIG_SHA256=y
 CONFIG_HEXDUMP=y
 CONFIG_FSPI_CONF_HEADER=y
diff --git a/configs/imxrt1170-evk_defconfig b/configs/imxrt1170-evk_defconfig
index 5f28c22e66c..487da275c62 100644
--- a/configs/imxrt1170-evk_defconfig
+++ b/configs/imxrt1170-evk_defconfig
@@ -68,3 +68,4 @@  CONFIG_FSL_LPUART=y
 CONFIG_TIMER=y
 CONFIG_SPL_TIMER=y
 CONFIG_IMX_GPT_TIMER=y
+# CONFIG_BINMAN_FDT is not set