| Message ID | 20241018145157.3918429-3-sjg@chromium.org |
|---|---|
| State | Needs Review / ACK |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | efi: Start to chip away at the EFI workaround | expand |
Hi Simon, Please mark the patches as efi_loader. I didn't notice this one up to now On Fri, 18 Oct 2024 at 17:52, Simon Glass <sjg@chromium.org> wrote: > > This function is not called from outside this file and has no entry in > the header file, so mark it static. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > lib/efi_loader/efi_bootbin.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/efi_loader/efi_bootbin.c b/lib/efi_loader/efi_bootbin.c > index a0ab677ee1a..eb9b9c4afe0 100644 > --- a/lib/efi_loader/efi_bootbin.c > +++ b/lib/efi_loader/efi_bootbin.c > @@ -141,7 +141,7 @@ void efi_set_bootdev(const char *dev, const char *devnr, const char *path, > * @source_size: size of the UEFI image > * Return: status code > */ > -efi_status_t efi_run_image(void *source_buffer, efi_uintn_t source_size) > +static efi_status_t efi_run_image(void *source_buffer, efi_uintn_t source_size) > { > efi_handle_t mem_handle = NULL, handle; > struct efi_device_path *file_path = NULL; > -- > 2.34.1 > Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
diff --git a/lib/efi_loader/efi_bootbin.c b/lib/efi_loader/efi_bootbin.c index a0ab677ee1a..eb9b9c4afe0 100644 --- a/lib/efi_loader/efi_bootbin.c +++ b/lib/efi_loader/efi_bootbin.c @@ -141,7 +141,7 @@ void efi_set_bootdev(const char *dev, const char *devnr, const char *path, * @source_size: size of the UEFI image * Return: status code */ -efi_status_t efi_run_image(void *source_buffer, efi_uintn_t source_size) +static efi_status_t efi_run_image(void *source_buffer, efi_uintn_t source_size) { efi_handle_t mem_handle = NULL, handle; struct efi_device_path *file_path = NULL;
This function is not called from outside this file and has no entry in the header file, so mark it static. Signed-off-by: Simon Glass <sjg@chromium.org> --- lib/efi_loader/efi_bootbin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)