diff mbox series

[v4,01/11] led: toggle LED on initial SW blink

Message ID 20240920225101.2008-2-ansuelsmth@gmail.com
State New
Headers show
Series led: introduce LED boot and activity function | expand

Commit Message

Christian Marangi Sept. 20, 2024, 10:49 p.m. UTC 
We currently init the LED OFF when SW blink is triggered when
on_state_change() is called. This can be problematic for very short
period as the ON/OFF blink might never trigger.

Toggle the LED (ON if OFF, OFF if ON) on initial SW blink to handle this
corner case and better display a LED blink from the user.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
 drivers/led/led_sw_blink.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/led/led_sw_blink.c b/drivers/led/led_sw_blink.c
index 9e36edbee47..9d9820720c6 100644
--- a/drivers/led/led_sw_blink.c
+++ b/drivers/led/led_sw_blink.c
@@ -103,8 +103,16 @@  bool led_sw_on_state_change(struct udevice *dev, enum led_state_t state)
 		return false;
 
 	if (state == LEDST_BLINK) {
+		struct led_ops *ops = led_get_ops(dev);
+		enum led_state_t curr_state = led_get_state(dev);
+
+		curr_state = ops->get_state(dev);
+		/* toggle led initially */
+		ops->set_state(dev, curr_state == LEDST_ON ? LEDST_OFF :
+			       LEDST_ON);
 		/* start blinking on next led_sw_blink() call */
-		sw_blink->state = LED_SW_BLINK_ST_OFF;
+		sw_blink->state = curr_state == LEDST_ON ? LED_SW_BLINK_ST_OFF :
+				  LED_SW_BLINK_ST_ON;
 		return true;
 	}