diff mbox series

dts: beagleboneai64: Add boothph in chipid node

Message ID 20240917081329.370288-1-u-kumar1@ti.com
State New
Headers show
Series dts: beagleboneai64: Add boothph in chipid node | expand

Commit Message

Kumar, Udit Sept. 17, 2024, 8:13 a.m. UTC
beagleboneai64 boot was broken after OF_UPSTREAM support for
J721E SOC.
So add bootph in chipid node similar to other boards of
this SOC.

Fixes: 46bb1405b461 ("arm: dts: k3-j721e: Move to OF_UPSTREAM")
Reported-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Udit Kumar <u-kumar1@ti.com>
---
Boot logs
https://gist.github.com/uditkumarti/32604960dec65401cde8979e51160ba7

 arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Tom Rini Sept. 17, 2024, 4:54 p.m. UTC | #1
On Tue, Sep 17, 2024 at 01:43:29PM +0530, Udit Kumar wrote:
> beagleboneai64 boot was broken after OF_UPSTREAM support for
> J721E SOC.
> So add bootph in chipid node similar to other boards of
> this SOC.
> 
> Fixes: 46bb1405b461 ("arm: dts: k3-j721e: Move to OF_UPSTREAM")
> Reported-by: Robert Nelson <robertcnelson@gmail.com>
> Signed-off-by: Udit Kumar <u-kumar1@ti.com>
> ---
> Boot logs
> https://gist.github.com/uditkumarti/32604960dec65401cde8979e51160ba7
> 
>  arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi b/arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi
> index 884f44239e..27851b7d08 100644
> --- a/arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi
> +++ b/arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi
> @@ -64,6 +64,10 @@
>  	bootph-all;
>  };
>  
> +&chipid {
> +	bootph-all;
> +};
> +

Someone is upstreaming both of these, right?
Kumar, Udit Sept. 17, 2024, 5:16 p.m. UTC | #2
On 9/17/2024 10:24 PM, Tom Rini wrote:
> On Tue, Sep 17, 2024 at 01:43:29PM +0530, Udit Kumar wrote:
>> beagleboneai64 boot was broken after OF_UPSTREAM support for
>> J721E SOC.
>> So add bootph in chipid node similar to other boards of
>> this SOC.
>>
>> Fixes: 46bb1405b461 ("arm: dts: k3-j721e: Move to OF_UPSTREAM")
>> Reported-by: Robert Nelson <robertcnelson@gmail.com>
>> Signed-off-by: Udit Kumar <u-kumar1@ti.com>
>> ---
>> Boot logs
>> https://gist.github.com/uditkumarti/32604960dec65401cde8979e51160ba7
>>
>>   arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi b/arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi
>> index 884f44239e..27851b7d08 100644
>> --- a/arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi
>> +++ b/arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi
>> @@ -64,6 +64,10 @@
>>   	bootph-all;
>>   };
>>   
>> +&chipid {
>> +	bootph-all;
>> +};
>> +
> Someone is upstreaming both of these, right?

Yes, patch posted for kernel by Manorit,

Please see

https://lore.kernel.org/all/20240814-b4-upstream-bootph-all-v4-4-f2b462000f25@ti.com/

But as of now, this node is defined as bootph-all for other J721E boards

arch/arm/dts/k3-j721e-common-proc-board-u-boot.dtsi:&chipid {
arch/arm/dts/k3-j721e-sk-u-boot.dtsi:&chipid {


>
diff mbox series

Patch

diff --git a/arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi b/arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi
index 884f44239e..27851b7d08 100644
--- a/arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi
+++ b/arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi
@@ -64,6 +64,10 @@ 
 	bootph-all;
 };
 
+&chipid {
+	bootph-all;
+};
+
 &mcu_ringacc {
 	reg = <0x0 0x2b800000 0x0 0x400000>,
 		<0x0 0x2b000000 0x0 0x400000>,