| Message ID | 20240909155315.307026-3-lehmanju@devpi.de |
|---|---|
| State | Superseded |
| Delegated to: | Caleb Connolly |
| Headers | show |
| Series | Support for Qualcomm sm8150 SoC | expand |
Hi Julius, Thanks for the patch! On 09/09/2024 17:53, Julius Lehmann wrote: > Add pinctrl and GPIO driver for SM8150. Driver code is based on the > similar U-Boot drivers. All constants are taken from the corresponding > Linux driver. This drivers differs from the similar U-Boot drivers, > because SM8150 SoC have different function IDs for the same functions > on different pins. > > Co-authored-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com> > Signed-off-by: Julius Lehmann <lehmanju@devpi.de> > --- > > drivers/pinctrl/qcom/Kconfig | 8 ++ > drivers/pinctrl/qcom/Makefile | 1 + > drivers/pinctrl/qcom/pinctrl-sm8150.c | 119 ++++++++++++++++++++++++++ > 3 files changed, 128 insertions(+) > create mode 100644 drivers/pinctrl/qcom/pinctrl-sm8150.c > > diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig > index b326fa8514..501939f783 100644 > --- a/drivers/pinctrl/qcom/Kconfig > +++ b/drivers/pinctrl/qcom/Kconfig > @@ -74,6 +74,14 @@ config PINCTRL_QCOM_SM8650 > select PINCTRL_QCOM > help > Say Y here to enable support for pinctrl on the Snapdragon SM8650 SoC, > + as well as the associated GPIO driver. > + > +config PINCTRL_QCOM_SM8150 > + bool "Qualcomm SM8150 GCC" > + select PINCTRL_QCOM > + help > + Say Y here to enable support for pinctrl on the Snapdragon SM8150 SoC, > + as well as the associated GPIO driver. > > endmenu > > diff --git a/drivers/pinctrl/qcom/Makefile b/drivers/pinctrl/qcom/Makefile > index 4f1d96787b..cc3660a576 100644 > --- a/drivers/pinctrl/qcom/Makefile > +++ b/drivers/pinctrl/qcom/Makefile > @@ -13,3 +13,4 @@ obj-$(CONFIG_PINCTRL_QCOM_SM6115) += pinctrl-sm6115.o > obj-$(CONFIG_PINCTRL_QCOM_SM8250) += pinctrl-sm8250.o > obj-$(CONFIG_PINCTRL_QCOM_SM8550) += pinctrl-sm8550.o > obj-$(CONFIG_PINCTRL_QCOM_SM8650) += pinctrl-sm8650.o > +obj-$(CONFIG_PINCTRL_QCOM_SM8150) += pinctrl-sm8150.o > diff --git a/drivers/pinctrl/qcom/pinctrl-sm8150.c b/drivers/pinctrl/qcom/pinctrl-sm8150.c > new file mode 100644 > index 0000000000..c3af3448f6 > --- /dev/null > +++ b/drivers/pinctrl/qcom/pinctrl-sm8150.c > @@ -0,0 +1,119 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Qualcomm SM8150 pinctrl and GPIO driver > + * > + * Volodymyr Babchuk <volodymyr_babchuk@epam.com> > + * Copyright (c) 2024 EPAM Systems. > + * > + * (C) Copyright 2024 Julius Lehmann <lehmanju@devpi.de> > + * > + * Based on similar U-Boot drivers. Constants were taken from the Linux driver > + */ > + > +#include <dm.h> > + > +#include "pinctrl-qcom.h" > + > +#define WEST 0x00100000 > +#define EAST 0x00500000 > +#define NORTH 0x00900000 > +#define SOUTH 0x00D00000 > + > +#define MAX_PIN_NAME_LEN 32 > +static char pin_name[MAX_PIN_NAME_LEN] __section(".data"); > + > +static const struct pinctrl_function msm_pinctrl_functions[] = { { "qup2", 1 }, > + { "gpio", 0 }, > + { "sdc4", 0 } }; > + > +static const unsigned int sm8150_pin_offsets[] = { > + [0] = SOUTH, [1] = SOUTH, [2] = SOUTH, [3] = SOUTH, > + [4] = SOUTH, [5] = SOUTH, [6] = SOUTH, [7] = SOUTH, > + [8] = NORTH, [9] = NORTH, [10] = NORTH, [11] = NORTH, > + [12] = NORTH, [13] = NORTH, [14] = NORTH, [15] = NORTH, > + [16] = NORTH, [17] = NORTH, [18] = NORTH, [19] = NORTH, > + [20] = NORTH, [21] = EAST, [22] = EAST, [23] = EAST, > + [24] = EAST, [25] = EAST, [26] = EAST, [27] = EAST, > + [28] = EAST, [29] = EAST, [30] = EAST, [31] = NORTH, > + [32] = NORTH, [33] = NORTH, [34] = NORTH, [35] = NORTH, > + [36] = NORTH, [37] = NORTH, [38] = SOUTH, [39] = NORTH, > + [40] = NORTH, [41] = NORTH, [42] = NORTH, [43] = EAST, > + [44] = EAST, [45] = EAST, [46] = EAST, [47] = EAST, > + [48] = EAST, [49] = EAST, [50] = EAST, [51] = SOUTH, > + [52] = SOUTH, [53] = SOUTH, [54] = SOUTH, [55] = SOUTH, > + [56] = SOUTH, [57] = SOUTH, [58] = SOUTH, [59] = SOUTH, > + [60] = SOUTH, [61] = SOUTH, [62] = SOUTH, [63] = SOUTH, > + [64] = SOUTH, [65] = SOUTH, [66] = SOUTH, [67] = SOUTH, > + [68] = SOUTH, [69] = SOUTH, [70] = SOUTH, [71] = SOUTH, > + [72] = SOUTH, [73] = SOUTH, [74] = SOUTH, [75] = SOUTH, > + [76] = SOUTH, [77] = SOUTH, [78] = SOUTH, [79] = SOUTH, > + [80] = SOUTH, [81] = SOUTH, [82] = SOUTH, [83] = NORTH, > + [84] = NORTH, [85] = NORTH, [86] = NORTH, [87] = EAST, > + [88] = NORTH, [89] = NORTH, [90] = NORTH, [91] = NORTH, > + [92] = NORTH, [93] = NORTH, [94] = NORTH, [95] = NORTH, > + [96] = NORTH, [97] = NORTH, [98] = SOUTH, [99] = SOUTH, > + [100] = SOUTH, [101] = SOUTH, [102] = NORTH, [103] = NORTH, > + [104] = NORTH, [105] = WEST, [106] = WEST, [107] = WEST, > + [108] = WEST, [109] = WEST, [110] = WEST, [111] = WEST, > + [112] = WEST, [113] = WEST, [114] = SOUTH, [115] = SOUTH, > + [116] = SOUTH, [117] = SOUTH, [118] = SOUTH, [119] = SOUTH, > + [120] = SOUTH, [121] = SOUTH, [122] = SOUTH, [123] = SOUTH, > + [124] = SOUTH, [125] = WEST, [126] = SOUTH, [127] = SOUTH, > + [128] = SOUTH, [129] = SOUTH, [130] = SOUTH, [131] = SOUTH, > + [132] = SOUTH, [133] = SOUTH, [134] = SOUTH, [135] = SOUTH, > + [136] = SOUTH, [137] = SOUTH, [138] = SOUTH, [139] = SOUTH, > + [140] = SOUTH, [141] = SOUTH, [142] = SOUTH, [143] = SOUTH, > + [144] = SOUTH, [145] = SOUTH, [146] = SOUTH, [147] = SOUTH, > + [148] = SOUTH, [149] = SOUTH, [150] = SOUTH, [151] = SOUTH, > + [152] = SOUTH, [153] = SOUTH, [154] = SOUTH, [155] = WEST, > + [156] = WEST, [157] = WEST, [158] = WEST, [159] = WEST, > + [160] = WEST, [161] = WEST, [162] = WEST, [163] = WEST, > + [164] = WEST, [165] = WEST, [166] = WEST, [167] = WEST, > + [168] = WEST, [169] = NORTH, [170] = NORTH, [171] = NORTH, > + [172] = NORTH, [173] = NORTH, [174] = NORTH, > + // special pins > + [175] = 0, [176] = 0, [177] = 0, [178] = 0, We have better support for special pins now, you can remove these 0 entries and set .special_pins_start = 175 in pin_data below. Kind regards, > +}; > + > +static const char *sm8150_get_function_name(struct udevice *dev, > + unsigned int selector) > +{ > + return msm_pinctrl_functions[selector].name; > +} > + > +static const char *sm8150_get_pin_name(struct udevice *dev, > + unsigned int selector) > +{ > + snprintf(pin_name, MAX_PIN_NAME_LEN, "gpio%u", selector); > + return pin_name; > +} > + > +static unsigned int sm8150_get_function_mux(__maybe_unused unsigned int pin, > + unsigned int selector) > +{ > + return msm_pinctrl_functions[selector].val; > +} > + > +static struct msm_pinctrl_data sm8150_data = { > + .pin_data = { > + .pin_offsets = sm8150_pin_offsets, > + .pin_count = ARRAY_SIZE(sm8150_pin_offsets), > + }, > + .functions_count = ARRAY_SIZE(msm_pinctrl_functions), > + .get_function_name = sm8150_get_function_name, > + .get_function_mux = sm8150_get_function_mux, > + .get_pin_name = sm8150_get_pin_name, > +}; > + > +static const struct udevice_id msm_pinctrl_ids[] = { > + { .compatible = "qcom,sm8150-pinctrl", .data = (ulong)&sm8150_data }, > + { /* Sentinel */ } > +}; > + > +U_BOOT_DRIVER(pinctrl_sm8150) = { > + .name = "pinctrl_sm8150", > + .id = UCLASS_NOP, > + .of_match = msm_pinctrl_ids, > + .ops = &msm_pinctrl_ops, > + .bind = msm_pinctrl_bind, > +};
On 10/09/2024 14:05, Caleb Connolly wrote: > Hi Julius, > > Thanks for the patch! > > On 09/09/2024 17:53, Julius Lehmann wrote: >> Add pinctrl and GPIO driver for SM8150. Driver code is based on the >> similar U-Boot drivers. All constants are taken from the corresponding >> Linux driver. This drivers differs from the similar U-Boot drivers, >> because SM8150 SoC have different function IDs for the same functions >> on different pins. >> >> Co-authored-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com> >> Signed-off-by: Julius Lehmann <lehmanju@devpi.de> >> --- >> >> drivers/pinctrl/qcom/Kconfig | 8 ++ >> drivers/pinctrl/qcom/Makefile | 1 + >> drivers/pinctrl/qcom/pinctrl-sm8150.c | 119 ++++++++++++++++++++++++++ >> 3 files changed, 128 insertions(+) >> create mode 100644 drivers/pinctrl/qcom/pinctrl-sm8150.c >> >> diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig >> index b326fa8514..501939f783 100644 >> --- a/drivers/pinctrl/qcom/Kconfig >> +++ b/drivers/pinctrl/qcom/Kconfig >> @@ -74,6 +74,14 @@ config PINCTRL_QCOM_SM8650 >> select PINCTRL_QCOM >> help >> Say Y here to enable support for pinctrl on the Snapdragon SM8650 SoC, >> + as well as the associated GPIO driver. >> + >> +config PINCTRL_QCOM_SM8150 >> + bool "Qualcomm SM8150 GCC" >> + select PINCTRL_QCOM >> + help >> + Say Y here to enable support for pinctrl on the Snapdragon SM8150 SoC, >> + as well as the associated GPIO driver. >> >> endmenu >> >> diff --git a/drivers/pinctrl/qcom/Makefile b/drivers/pinctrl/qcom/Makefile >> index 4f1d96787b..cc3660a576 100644 >> --- a/drivers/pinctrl/qcom/Makefile >> +++ b/drivers/pinctrl/qcom/Makefile >> @@ -13,3 +13,4 @@ obj-$(CONFIG_PINCTRL_QCOM_SM6115) += pinctrl-sm6115.o >> obj-$(CONFIG_PINCTRL_QCOM_SM8250) += pinctrl-sm8250.o >> obj-$(CONFIG_PINCTRL_QCOM_SM8550) += pinctrl-sm8550.o >> obj-$(CONFIG_PINCTRL_QCOM_SM8650) += pinctrl-sm8650.o >> +obj-$(CONFIG_PINCTRL_QCOM_SM8150) += pinctrl-sm8150.o >> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8150.c b/drivers/pinctrl/qcom/pinctrl-sm8150.c >> new file mode 100644 >> index 0000000000..c3af3448f6 >> --- /dev/null >> +++ b/drivers/pinctrl/qcom/pinctrl-sm8150.c >> @@ -0,0 +1,119 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +/* >> + * Qualcomm SM8150 pinctrl and GPIO driver >> + * >> + * Volodymyr Babchuk <volodymyr_babchuk@epam.com> >> + * Copyright (c) 2024 EPAM Systems. >> + * >> + * (C) Copyright 2024 Julius Lehmann <lehmanju@devpi.de> >> + * >> + * Based on similar U-Boot drivers. Constants were taken from the Linux driver >> + */ >> + >> +#include <dm.h> >> + >> +#include "pinctrl-qcom.h" >> + >> +#define WEST 0x00100000 >> +#define EAST 0x00500000 >> +#define NORTH 0x00900000 >> +#define SOUTH 0x00D00000 >> + >> +#define MAX_PIN_NAME_LEN 32 >> +static char pin_name[MAX_PIN_NAME_LEN] __section(".data"); >> + >> +static const struct pinctrl_function msm_pinctrl_functions[] = { { "qup2", 1 }, >> + { "gpio", 0 }, >> + { "sdc4", 0 } }; >> + >> +static const unsigned int sm8150_pin_offsets[] = { >> + [0] = SOUTH, [1] = SOUTH, [2] = SOUTH, [3] = SOUTH, >> + [4] = SOUTH, [5] = SOUTH, [6] = SOUTH, [7] = SOUTH, >> + [8] = NORTH, [9] = NORTH, [10] = NORTH, [11] = NORTH, >> + [12] = NORTH, [13] = NORTH, [14] = NORTH, [15] = NORTH, >> + [16] = NORTH, [17] = NORTH, [18] = NORTH, [19] = NORTH, >> + [20] = NORTH, [21] = EAST, [22] = EAST, [23] = EAST, >> + [24] = EAST, [25] = EAST, [26] = EAST, [27] = EAST, >> + [28] = EAST, [29] = EAST, [30] = EAST, [31] = NORTH, >> + [32] = NORTH, [33] = NORTH, [34] = NORTH, [35] = NORTH, >> + [36] = NORTH, [37] = NORTH, [38] = SOUTH, [39] = NORTH, >> + [40] = NORTH, [41] = NORTH, [42] = NORTH, [43] = EAST, >> + [44] = EAST, [45] = EAST, [46] = EAST, [47] = EAST, >> + [48] = EAST, [49] = EAST, [50] = EAST, [51] = SOUTH, >> + [52] = SOUTH, [53] = SOUTH, [54] = SOUTH, [55] = SOUTH, >> + [56] = SOUTH, [57] = SOUTH, [58] = SOUTH, [59] = SOUTH, >> + [60] = SOUTH, [61] = SOUTH, [62] = SOUTH, [63] = SOUTH, >> + [64] = SOUTH, [65] = SOUTH, [66] = SOUTH, [67] = SOUTH, >> + [68] = SOUTH, [69] = SOUTH, [70] = SOUTH, [71] = SOUTH, >> + [72] = SOUTH, [73] = SOUTH, [74] = SOUTH, [75] = SOUTH, >> + [76] = SOUTH, [77] = SOUTH, [78] = SOUTH, [79] = SOUTH, >> + [80] = SOUTH, [81] = SOUTH, [82] = SOUTH, [83] = NORTH, >> + [84] = NORTH, [85] = NORTH, [86] = NORTH, [87] = EAST, >> + [88] = NORTH, [89] = NORTH, [90] = NORTH, [91] = NORTH, >> + [92] = NORTH, [93] = NORTH, [94] = NORTH, [95] = NORTH, >> + [96] = NORTH, [97] = NORTH, [98] = SOUTH, [99] = SOUTH, >> + [100] = SOUTH, [101] = SOUTH, [102] = NORTH, [103] = NORTH, >> + [104] = NORTH, [105] = WEST, [106] = WEST, [107] = WEST, >> + [108] = WEST, [109] = WEST, [110] = WEST, [111] = WEST, >> + [112] = WEST, [113] = WEST, [114] = SOUTH, [115] = SOUTH, >> + [116] = SOUTH, [117] = SOUTH, [118] = SOUTH, [119] = SOUTH, >> + [120] = SOUTH, [121] = SOUTH, [122] = SOUTH, [123] = SOUTH, >> + [124] = SOUTH, [125] = WEST, [126] = SOUTH, [127] = SOUTH, >> + [128] = SOUTH, [129] = SOUTH, [130] = SOUTH, [131] = SOUTH, >> + [132] = SOUTH, [133] = SOUTH, [134] = SOUTH, [135] = SOUTH, >> + [136] = SOUTH, [137] = SOUTH, [138] = SOUTH, [139] = SOUTH, >> + [140] = SOUTH, [141] = SOUTH, [142] = SOUTH, [143] = SOUTH, >> + [144] = SOUTH, [145] = SOUTH, [146] = SOUTH, [147] = SOUTH, >> + [148] = SOUTH, [149] = SOUTH, [150] = SOUTH, [151] = SOUTH, >> + [152] = SOUTH, [153] = SOUTH, [154] = SOUTH, [155] = WEST, >> + [156] = WEST, [157] = WEST, [158] = WEST, [159] = WEST, >> + [160] = WEST, [161] = WEST, [162] = WEST, [163] = WEST, >> + [164] = WEST, [165] = WEST, [166] = WEST, [167] = WEST, >> + [168] = WEST, [169] = NORTH, [170] = NORTH, [171] = NORTH, >> + [172] = NORTH, [173] = NORTH, [174] = NORTH, >> + // special pins >> + [175] = 0, [176] = 0, [177] = 0, [178] = 0, > > We have better support for special pins now, you can remove these 0 > entries and set .special_pins_start = 175 in pin_data below. You can look at the sm8250 patch at https://lore.kernel.org/all/20240910-topic-sm8x50-msm-gpio-special-pins-sm8250-v1-2-50623a7e4931@linaro.org/ > > Kind regards, >> +}; >> + >> +static const char *sm8150_get_function_name(struct udevice *dev, >> + unsigned int selector) >> +{ >> + return msm_pinctrl_functions[selector].name; >> +} >> + >> +static const char *sm8150_get_pin_name(struct udevice *dev, >> + unsigned int selector) >> +{ >> + snprintf(pin_name, MAX_PIN_NAME_LEN, "gpio%u", selector); >> + return pin_name; >> +} >> + >> +static unsigned int sm8150_get_function_mux(__maybe_unused unsigned int pin, >> + unsigned int selector) >> +{ >> + return msm_pinctrl_functions[selector].val; >> +} >> + >> +static struct msm_pinctrl_data sm8150_data = { >> + .pin_data = { >> + .pin_offsets = sm8150_pin_offsets, >> + .pin_count = ARRAY_SIZE(sm8150_pin_offsets), >> + }, >> + .functions_count = ARRAY_SIZE(msm_pinctrl_functions), >> + .get_function_name = sm8150_get_function_name, >> + .get_function_mux = sm8150_get_function_mux, >> + .get_pin_name = sm8150_get_pin_name, >> +}; >> + >> +static const struct udevice_id msm_pinctrl_ids[] = { >> + { .compatible = "qcom,sm8150-pinctrl", .data = (ulong)&sm8150_data }, >> + { /* Sentinel */ } >> +}; >> + >> +U_BOOT_DRIVER(pinctrl_sm8150) = { >> + .name = "pinctrl_sm8150", >> + .id = UCLASS_NOP, >> + .of_match = msm_pinctrl_ids, >> + .ops = &msm_pinctrl_ops, >> + .bind = msm_pinctrl_bind, >> +}; >
Hi Neil and Caleb, thank you for taking a look at my patch. On 10.09.24 14:07, Neil Armstrong wrote: > On 10/09/2024 14:05, Caleb Connolly wrote: >> Hi Julius, >> >> Thanks for the patch! >> >> On 09/09/2024 17:53, Julius Lehmann wrote: >>> Add pinctrl and GPIO driver for SM8150. Driver code is based on the >>> similar U-Boot drivers. All constants are taken from the corresponding >>> Linux driver. This drivers differs from the similar U-Boot drivers, >>> because SM8150 SoC have different function IDs for the same functions >>> on different pins. >>> >>> Co-authored-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com> >>> Signed-off-by: Julius Lehmann <lehmanju@devpi.de> >>> --- >>> >>> drivers/pinctrl/qcom/Kconfig | 8 ++ >>> drivers/pinctrl/qcom/Makefile | 1 + >>> drivers/pinctrl/qcom/pinctrl-sm8150.c | 119 >>> ++++++++++++++++++++++++++ >>> 3 files changed, 128 insertions(+) >>> create mode 100644 drivers/pinctrl/qcom/pinctrl-sm8150.c >>> >>> diff --git a/drivers/pinctrl/qcom/Kconfig >>> b/drivers/pinctrl/qcom/Kconfig >>> index b326fa8514..501939f783 100644 >>> --- a/drivers/pinctrl/qcom/Kconfig >>> +++ b/drivers/pinctrl/qcom/Kconfig >>> @@ -74,6 +74,14 @@ config PINCTRL_QCOM_SM8650 >>> select PINCTRL_QCOM >>> help >>> Say Y here to enable support for pinctrl on the Snapdragon >>> SM8650 SoC, >>> + as well as the associated GPIO driver. >>> + >>> +config PINCTRL_QCOM_SM8150 >>> + bool "Qualcomm SM8150 GCC" >>> + select PINCTRL_QCOM >>> + help >>> + Say Y here to enable support for pinctrl on the Snapdragon >>> SM8150 SoC, >>> + as well as the associated GPIO driver. >>> endmenu >>> diff --git a/drivers/pinctrl/qcom/Makefile >>> b/drivers/pinctrl/qcom/Makefile >>> index 4f1d96787b..cc3660a576 100644 >>> --- a/drivers/pinctrl/qcom/Makefile >>> +++ b/drivers/pinctrl/qcom/Makefile >>> @@ -13,3 +13,4 @@ obj-$(CONFIG_PINCTRL_QCOM_SM6115) += pinctrl-sm6115.o >>> obj-$(CONFIG_PINCTRL_QCOM_SM8250) += pinctrl-sm8250.o >>> obj-$(CONFIG_PINCTRL_QCOM_SM8550) += pinctrl-sm8550.o >>> obj-$(CONFIG_PINCTRL_QCOM_SM8650) += pinctrl-sm8650.o >>> +obj-$(CONFIG_PINCTRL_QCOM_SM8150) += pinctrl-sm8150.o >>> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8150.c >>> b/drivers/pinctrl/qcom/pinctrl-sm8150.c >>> new file mode 100644 >>> index 0000000000..c3af3448f6 >>> --- /dev/null >>> +++ b/drivers/pinctrl/qcom/pinctrl-sm8150.c >>> @@ -0,0 +1,119 @@ >>> +// SPDX-License-Identifier: BSD-3-Clause >>> +/* >>> + * Qualcomm SM8150 pinctrl and GPIO driver >>> + * >>> + * Volodymyr Babchuk <volodymyr_babchuk@epam.com> >>> + * Copyright (c) 2024 EPAM Systems. >>> + * >>> + * (C) Copyright 2024 Julius Lehmann <lehmanju@devpi.de> >>> + * >>> + * Based on similar U-Boot drivers. Constants were taken from the >>> Linux driver >>> + */ >>> + >>> +#include <dm.h> >>> + >>> +#include "pinctrl-qcom.h" >>> + >>> +#define WEST 0x00100000 >>> +#define EAST 0x00500000 >>> +#define NORTH 0x00900000 >>> +#define SOUTH 0x00D00000 >>> + >>> +#define MAX_PIN_NAME_LEN 32 >>> +static char pin_name[MAX_PIN_NAME_LEN] __section(".data"); >>> + >>> +static const struct pinctrl_function msm_pinctrl_functions[] = { { >>> "qup2", 1 }, >>> + { "gpio", 0 }, >>> + { "sdc4", 0 } }; >>> + >>> +static const unsigned int sm8150_pin_offsets[] = { >>> + [0] = SOUTH, [1] = SOUTH, [2] = SOUTH, [3] = SOUTH, >>> + [4] = SOUTH, [5] = SOUTH, [6] = SOUTH, [7] = SOUTH, >>> + [8] = NORTH, [9] = NORTH, [10] = NORTH, [11] = NORTH, >>> + [12] = NORTH, [13] = NORTH, [14] = NORTH, [15] = NORTH, >>> + [16] = NORTH, [17] = NORTH, [18] = NORTH, [19] = NORTH, >>> + [20] = NORTH, [21] = EAST, [22] = EAST, [23] = EAST, >>> + [24] = EAST, [25] = EAST, [26] = EAST, [27] = EAST, >>> + [28] = EAST, [29] = EAST, [30] = EAST, [31] = NORTH, >>> + [32] = NORTH, [33] = NORTH, [34] = NORTH, [35] = NORTH, >>> + [36] = NORTH, [37] = NORTH, [38] = SOUTH, [39] = NORTH, >>> + [40] = NORTH, [41] = NORTH, [42] = NORTH, [43] = EAST, >>> + [44] = EAST, [45] = EAST, [46] = EAST, [47] = EAST, >>> + [48] = EAST, [49] = EAST, [50] = EAST, [51] = SOUTH, >>> + [52] = SOUTH, [53] = SOUTH, [54] = SOUTH, [55] = SOUTH, >>> + [56] = SOUTH, [57] = SOUTH, [58] = SOUTH, [59] = SOUTH, >>> + [60] = SOUTH, [61] = SOUTH, [62] = SOUTH, [63] = SOUTH, >>> + [64] = SOUTH, [65] = SOUTH, [66] = SOUTH, [67] = SOUTH, >>> + [68] = SOUTH, [69] = SOUTH, [70] = SOUTH, [71] = SOUTH, >>> + [72] = SOUTH, [73] = SOUTH, [74] = SOUTH, [75] = SOUTH, >>> + [76] = SOUTH, [77] = SOUTH, [78] = SOUTH, [79] = SOUTH, >>> + [80] = SOUTH, [81] = SOUTH, [82] = SOUTH, [83] = NORTH, >>> + [84] = NORTH, [85] = NORTH, [86] = NORTH, [87] = EAST, >>> + [88] = NORTH, [89] = NORTH, [90] = NORTH, [91] = NORTH, >>> + [92] = NORTH, [93] = NORTH, [94] = NORTH, [95] = NORTH, >>> + [96] = NORTH, [97] = NORTH, [98] = SOUTH, [99] = SOUTH, >>> + [100] = SOUTH, [101] = SOUTH, [102] = NORTH, [103] = NORTH, >>> + [104] = NORTH, [105] = WEST, [106] = WEST, [107] = WEST, >>> + [108] = WEST, [109] = WEST, [110] = WEST, [111] = WEST, >>> + [112] = WEST, [113] = WEST, [114] = SOUTH, [115] = SOUTH, >>> + [116] = SOUTH, [117] = SOUTH, [118] = SOUTH, [119] = SOUTH, >>> + [120] = SOUTH, [121] = SOUTH, [122] = SOUTH, [123] = SOUTH, >>> + [124] = SOUTH, [125] = WEST, [126] = SOUTH, [127] = SOUTH, >>> + [128] = SOUTH, [129] = SOUTH, [130] = SOUTH, [131] = SOUTH, >>> + [132] = SOUTH, [133] = SOUTH, [134] = SOUTH, [135] = SOUTH, >>> + [136] = SOUTH, [137] = SOUTH, [138] = SOUTH, [139] = SOUTH, >>> + [140] = SOUTH, [141] = SOUTH, [142] = SOUTH, [143] = SOUTH, >>> + [144] = SOUTH, [145] = SOUTH, [146] = SOUTH, [147] = SOUTH, >>> + [148] = SOUTH, [149] = SOUTH, [150] = SOUTH, [151] = SOUTH, >>> + [152] = SOUTH, [153] = SOUTH, [154] = SOUTH, [155] = WEST, >>> + [156] = WEST, [157] = WEST, [158] = WEST, [159] = WEST, >>> + [160] = WEST, [161] = WEST, [162] = WEST, [163] = WEST, >>> + [164] = WEST, [165] = WEST, [166] = WEST, [167] = WEST, >>> + [168] = WEST, [169] = NORTH, [170] = NORTH, [171] = NORTH, >>> + [172] = NORTH, [173] = NORTH, [174] = NORTH, >>> + // special pins >>> + [175] = 0, [176] = 0, [177] = 0, [178] = 0, >> >> We have better support for special pins now, you can remove these 0 >> entries and set .special_pins_start = 175 in pin_data below. > > You can look at the sm8250 patch at > https://lore.kernel.org/all/20240910-topic-sm8x50-msm-gpio-special-pins-sm8250-v1-2-50623a7e4931@linaro.org/ > I took a look at sm8550/sm8660 and noticed that the pin_offsets array is completely missing. Is it not required at all (if special_pins_start and special_pins_data are used)? For v2 I will also try to integrate UFS and SDC pin functions, just like in sm8550/sm8660. >> >> Kind regards, >>> +}; >>> + >>> +static const char *sm8150_get_function_name(struct udevice *dev, >>> + unsigned int selector) >>> +{ >>> + return msm_pinctrl_functions[selector].name; >>> +} >>> + >>> +static const char *sm8150_get_pin_name(struct udevice *dev, >>> + unsigned int selector) >>> +{ >>> + snprintf(pin_name, MAX_PIN_NAME_LEN, "gpio%u", selector); >>> + return pin_name; >>> +} >>> + >>> +static unsigned int sm8150_get_function_mux(__maybe_unused unsigned >>> int pin, >>> + unsigned int selector) >>> +{ >>> + return msm_pinctrl_functions[selector].val; >>> +} >>> + >>> +static struct msm_pinctrl_data sm8150_data = { >>> + .pin_data = { >>> + .pin_offsets = sm8150_pin_offsets, >>> + .pin_count = ARRAY_SIZE(sm8150_pin_offsets), >>> + }, >>> + .functions_count = ARRAY_SIZE(msm_pinctrl_functions), >>> + .get_function_name = sm8150_get_function_name, >>> + .get_function_mux = sm8150_get_function_mux, >>> + .get_pin_name = sm8150_get_pin_name, >>> +}; >>> + >>> +static const struct udevice_id msm_pinctrl_ids[] = { >>> + { .compatible = "qcom,sm8150-pinctrl", .data = >>> (ulong)&sm8150_data }, >>> + { /* Sentinel */ } >>> +}; >>> + >>> +U_BOOT_DRIVER(pinctrl_sm8150) = { >>> + .name = "pinctrl_sm8150", >>> + .id = UCLASS_NOP, >>> + .of_match = msm_pinctrl_ids, >>> + .ops = &msm_pinctrl_ops, >>> + .bind = msm_pinctrl_bind, >>> +}; >> >
On 10/09/2024 18:01, Julius Lehmann wrote: > Hi Neil and Caleb, > > thank you for taking a look at my patch. > > On 10.09.24 14:07, Neil Armstrong wrote: >> On 10/09/2024 14:05, Caleb Connolly wrote: >>> Hi Julius, >>> >>> Thanks for the patch! >>> >>> On 09/09/2024 17:53, Julius Lehmann wrote: >>>> Add pinctrl and GPIO driver for SM8150. Driver code is based on the >>>> similar U-Boot drivers. All constants are taken from the corresponding >>>> Linux driver. This drivers differs from the similar U-Boot drivers, >>>> because SM8150 SoC have different function IDs for the same functions >>>> on different pins. >>>> >>>> Co-authored-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com> >>>> Signed-off-by: Julius Lehmann <lehmanju@devpi.de> >>>> --- >>>> >>>> drivers/pinctrl/qcom/Kconfig | 8 ++ >>>> drivers/pinctrl/qcom/Makefile | 1 + >>>> drivers/pinctrl/qcom/pinctrl-sm8150.c | 119 ++++++++++++++++++++++++++ >>>> 3 files changed, 128 insertions(+) >>>> create mode 100644 drivers/pinctrl/qcom/pinctrl-sm8150.c >>>> >>>> diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig >>>> index b326fa8514..501939f783 100644 >>>> --- a/drivers/pinctrl/qcom/Kconfig >>>> +++ b/drivers/pinctrl/qcom/Kconfig >>>> @@ -74,6 +74,14 @@ config PINCTRL_QCOM_SM8650 >>>> select PINCTRL_QCOM >>>> help >>>> Say Y here to enable support for pinctrl on the Snapdragon SM8650 SoC, >>>> + as well as the associated GPIO driver. >>>> + >>>> +config PINCTRL_QCOM_SM8150 >>>> + bool "Qualcomm SM8150 GCC" >>>> + select PINCTRL_QCOM >>>> + help >>>> + Say Y here to enable support for pinctrl on the Snapdragon SM8150 SoC, >>>> + as well as the associated GPIO driver. >>>> endmenu >>>> diff --git a/drivers/pinctrl/qcom/Makefile b/drivers/pinctrl/qcom/Makefile >>>> index 4f1d96787b..cc3660a576 100644 >>>> --- a/drivers/pinctrl/qcom/Makefile >>>> +++ b/drivers/pinctrl/qcom/Makefile >>>> @@ -13,3 +13,4 @@ obj-$(CONFIG_PINCTRL_QCOM_SM6115) += pinctrl-sm6115.o >>>> obj-$(CONFIG_PINCTRL_QCOM_SM8250) += pinctrl-sm8250.o >>>> obj-$(CONFIG_PINCTRL_QCOM_SM8550) += pinctrl-sm8550.o >>>> obj-$(CONFIG_PINCTRL_QCOM_SM8650) += pinctrl-sm8650.o >>>> +obj-$(CONFIG_PINCTRL_QCOM_SM8150) += pinctrl-sm8150.o >>>> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8150.c b/drivers/pinctrl/qcom/pinctrl-sm8150.c >>>> new file mode 100644 >>>> index 0000000000..c3af3448f6 >>>> --- /dev/null >>>> +++ b/drivers/pinctrl/qcom/pinctrl-sm8150.c >>>> @@ -0,0 +1,119 @@ >>>> +// SPDX-License-Identifier: BSD-3-Clause >>>> +/* >>>> + * Qualcomm SM8150 pinctrl and GPIO driver >>>> + * >>>> + * Volodymyr Babchuk <volodymyr_babchuk@epam.com> >>>> + * Copyright (c) 2024 EPAM Systems. >>>> + * >>>> + * (C) Copyright 2024 Julius Lehmann <lehmanju@devpi.de> >>>> + * >>>> + * Based on similar U-Boot drivers. Constants were taken from the Linux driver >>>> + */ >>>> + >>>> +#include <dm.h> >>>> + >>>> +#include "pinctrl-qcom.h" >>>> + >>>> +#define WEST 0x00100000 >>>> +#define EAST 0x00500000 >>>> +#define NORTH 0x00900000 >>>> +#define SOUTH 0x00D00000 >>>> + >>>> +#define MAX_PIN_NAME_LEN 32 >>>> +static char pin_name[MAX_PIN_NAME_LEN] __section(".data"); >>>> + >>>> +static const struct pinctrl_function msm_pinctrl_functions[] = { { "qup2", 1 }, >>>> + { "gpio", 0 }, >>>> + { "sdc4", 0 } }; >>>> + >>>> +static const unsigned int sm8150_pin_offsets[] = { >>>> + [0] = SOUTH, [1] = SOUTH, [2] = SOUTH, [3] = SOUTH, >>>> + [4] = SOUTH, [5] = SOUTH, [6] = SOUTH, [7] = SOUTH, >>>> + [8] = NORTH, [9] = NORTH, [10] = NORTH, [11] = NORTH, >>>> + [12] = NORTH, [13] = NORTH, [14] = NORTH, [15] = NORTH, >>>> + [16] = NORTH, [17] = NORTH, [18] = NORTH, [19] = NORTH, >>>> + [20] = NORTH, [21] = EAST, [22] = EAST, [23] = EAST, >>>> + [24] = EAST, [25] = EAST, [26] = EAST, [27] = EAST, >>>> + [28] = EAST, [29] = EAST, [30] = EAST, [31] = NORTH, >>>> + [32] = NORTH, [33] = NORTH, [34] = NORTH, [35] = NORTH, >>>> + [36] = NORTH, [37] = NORTH, [38] = SOUTH, [39] = NORTH, >>>> + [40] = NORTH, [41] = NORTH, [42] = NORTH, [43] = EAST, >>>> + [44] = EAST, [45] = EAST, [46] = EAST, [47] = EAST, >>>> + [48] = EAST, [49] = EAST, [50] = EAST, [51] = SOUTH, >>>> + [52] = SOUTH, [53] = SOUTH, [54] = SOUTH, [55] = SOUTH, >>>> + [56] = SOUTH, [57] = SOUTH, [58] = SOUTH, [59] = SOUTH, >>>> + [60] = SOUTH, [61] = SOUTH, [62] = SOUTH, [63] = SOUTH, >>>> + [64] = SOUTH, [65] = SOUTH, [66] = SOUTH, [67] = SOUTH, >>>> + [68] = SOUTH, [69] = SOUTH, [70] = SOUTH, [71] = SOUTH, >>>> + [72] = SOUTH, [73] = SOUTH, [74] = SOUTH, [75] = SOUTH, >>>> + [76] = SOUTH, [77] = SOUTH, [78] = SOUTH, [79] = SOUTH, >>>> + [80] = SOUTH, [81] = SOUTH, [82] = SOUTH, [83] = NORTH, >>>> + [84] = NORTH, [85] = NORTH, [86] = NORTH, [87] = EAST, >>>> + [88] = NORTH, [89] = NORTH, [90] = NORTH, [91] = NORTH, >>>> + [92] = NORTH, [93] = NORTH, [94] = NORTH, [95] = NORTH, >>>> + [96] = NORTH, [97] = NORTH, [98] = SOUTH, [99] = SOUTH, >>>> + [100] = SOUTH, [101] = SOUTH, [102] = NORTH, [103] = NORTH, >>>> + [104] = NORTH, [105] = WEST, [106] = WEST, [107] = WEST, >>>> + [108] = WEST, [109] = WEST, [110] = WEST, [111] = WEST, >>>> + [112] = WEST, [113] = WEST, [114] = SOUTH, [115] = SOUTH, >>>> + [116] = SOUTH, [117] = SOUTH, [118] = SOUTH, [119] = SOUTH, >>>> + [120] = SOUTH, [121] = SOUTH, [122] = SOUTH, [123] = SOUTH, >>>> + [124] = SOUTH, [125] = WEST, [126] = SOUTH, [127] = SOUTH, >>>> + [128] = SOUTH, [129] = SOUTH, [130] = SOUTH, [131] = SOUTH, >>>> + [132] = SOUTH, [133] = SOUTH, [134] = SOUTH, [135] = SOUTH, >>>> + [136] = SOUTH, [137] = SOUTH, [138] = SOUTH, [139] = SOUTH, >>>> + [140] = SOUTH, [141] = SOUTH, [142] = SOUTH, [143] = SOUTH, >>>> + [144] = SOUTH, [145] = SOUTH, [146] = SOUTH, [147] = SOUTH, >>>> + [148] = SOUTH, [149] = SOUTH, [150] = SOUTH, [151] = SOUTH, >>>> + [152] = SOUTH, [153] = SOUTH, [154] = SOUTH, [155] = WEST, >>>> + [156] = WEST, [157] = WEST, [158] = WEST, [159] = WEST, >>>> + [160] = WEST, [161] = WEST, [162] = WEST, [163] = WEST, >>>> + [164] = WEST, [165] = WEST, [166] = WEST, [167] = WEST, >>>> + [168] = WEST, [169] = NORTH, [170] = NORTH, [171] = NORTH, >>>> + [172] = NORTH, [173] = NORTH, [174] = NORTH, >>>> + // special pins >>>> + [175] = 0, [176] = 0, [177] = 0, [178] = 0, >>> >>> We have better support for special pins now, you can remove these 0 >>> entries and set .special_pins_start = 175 in pin_data below. >> >> You can look at the sm8250 patch at https://lore.kernel.org/all/20240910-topic-sm8x50-msm-gpio-special-pins-sm8250-v1-2-50623a7e4931@linaro.org/ >> > I took a look at sm8550/sm8660 and noticed that the pin_offsets array is completely missing. Is it not required at all (if special_pins_start and special_pins_data are used)? Yeah for newer platforms, the offsets are not required at all. > > For v2 I will also try to integrate UFS and SDC pin functions, just like in sm8550/sm8660. > >>> >>> Kind regards, >>>> +}; >>>> + >>>> +static const char *sm8150_get_function_name(struct udevice *dev, >>>> + unsigned int selector) >>>> +{ >>>> + return msm_pinctrl_functions[selector].name; >>>> +} >>>> + >>>> +static const char *sm8150_get_pin_name(struct udevice *dev, >>>> + unsigned int selector) >>>> +{ >>>> + snprintf(pin_name, MAX_PIN_NAME_LEN, "gpio%u", selector); >>>> + return pin_name; >>>> +} >>>> + >>>> +static unsigned int sm8150_get_function_mux(__maybe_unused unsigned int pin, >>>> + unsigned int selector) >>>> +{ >>>> + return msm_pinctrl_functions[selector].val; >>>> +} >>>> + >>>> +static struct msm_pinctrl_data sm8150_data = { >>>> + .pin_data = { >>>> + .pin_offsets = sm8150_pin_offsets, >>>> + .pin_count = ARRAY_SIZE(sm8150_pin_offsets), >>>> + }, >>>> + .functions_count = ARRAY_SIZE(msm_pinctrl_functions), >>>> + .get_function_name = sm8150_get_function_name, >>>> + .get_function_mux = sm8150_get_function_mux, >>>> + .get_pin_name = sm8150_get_pin_name, >>>> +}; >>>> + >>>> +static const struct udevice_id msm_pinctrl_ids[] = { >>>> + { .compatible = "qcom,sm8150-pinctrl", .data = (ulong)&sm8150_data }, >>>> + { /* Sentinel */ } >>>> +}; >>>> + >>>> +U_BOOT_DRIVER(pinctrl_sm8150) = { >>>> + .name = "pinctrl_sm8150", >>>> + .id = UCLASS_NOP, >>>> + .of_match = msm_pinctrl_ids, >>>> + .ops = &msm_pinctrl_ops, >>>> + .bind = msm_pinctrl_bind, >>>> +}; >>> >>
diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig index b326fa8514..501939f783 100644 --- a/drivers/pinctrl/qcom/Kconfig +++ b/drivers/pinctrl/qcom/Kconfig @@ -74,6 +74,14 @@ config PINCTRL_QCOM_SM8650 select PINCTRL_QCOM help Say Y here to enable support for pinctrl on the Snapdragon SM8650 SoC, + as well as the associated GPIO driver. + +config PINCTRL_QCOM_SM8150 + bool "Qualcomm SM8150 GCC" + select PINCTRL_QCOM + help + Say Y here to enable support for pinctrl on the Snapdragon SM8150 SoC, + as well as the associated GPIO driver. endmenu diff --git a/drivers/pinctrl/qcom/Makefile b/drivers/pinctrl/qcom/Makefile index 4f1d96787b..cc3660a576 100644 --- a/drivers/pinctrl/qcom/Makefile +++ b/drivers/pinctrl/qcom/Makefile @@ -13,3 +13,4 @@ obj-$(CONFIG_PINCTRL_QCOM_SM6115) += pinctrl-sm6115.o obj-$(CONFIG_PINCTRL_QCOM_SM8250) += pinctrl-sm8250.o obj-$(CONFIG_PINCTRL_QCOM_SM8550) += pinctrl-sm8550.o obj-$(CONFIG_PINCTRL_QCOM_SM8650) += pinctrl-sm8650.o +obj-$(CONFIG_PINCTRL_QCOM_SM8150) += pinctrl-sm8150.o diff --git a/drivers/pinctrl/qcom/pinctrl-sm8150.c b/drivers/pinctrl/qcom/pinctrl-sm8150.c new file mode 100644 index 0000000000..c3af3448f6 --- /dev/null +++ b/drivers/pinctrl/qcom/pinctrl-sm8150.c @@ -0,0 +1,119 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Qualcomm SM8150 pinctrl and GPIO driver + * + * Volodymyr Babchuk <volodymyr_babchuk@epam.com> + * Copyright (c) 2024 EPAM Systems. + * + * (C) Copyright 2024 Julius Lehmann <lehmanju@devpi.de> + * + * Based on similar U-Boot drivers. Constants were taken from the Linux driver + */ + +#include <dm.h> + +#include "pinctrl-qcom.h" + +#define WEST 0x00100000 +#define EAST 0x00500000 +#define NORTH 0x00900000 +#define SOUTH 0x00D00000 + +#define MAX_PIN_NAME_LEN 32 +static char pin_name[MAX_PIN_NAME_LEN] __section(".data"); + +static const struct pinctrl_function msm_pinctrl_functions[] = { { "qup2", 1 }, + { "gpio", 0 }, + { "sdc4", 0 } }; + +static const unsigned int sm8150_pin_offsets[] = { + [0] = SOUTH, [1] = SOUTH, [2] = SOUTH, [3] = SOUTH, + [4] = SOUTH, [5] = SOUTH, [6] = SOUTH, [7] = SOUTH, + [8] = NORTH, [9] = NORTH, [10] = NORTH, [11] = NORTH, + [12] = NORTH, [13] = NORTH, [14] = NORTH, [15] = NORTH, + [16] = NORTH, [17] = NORTH, [18] = NORTH, [19] = NORTH, + [20] = NORTH, [21] = EAST, [22] = EAST, [23] = EAST, + [24] = EAST, [25] = EAST, [26] = EAST, [27] = EAST, + [28] = EAST, [29] = EAST, [30] = EAST, [31] = NORTH, + [32] = NORTH, [33] = NORTH, [34] = NORTH, [35] = NORTH, + [36] = NORTH, [37] = NORTH, [38] = SOUTH, [39] = NORTH, + [40] = NORTH, [41] = NORTH, [42] = NORTH, [43] = EAST, + [44] = EAST, [45] = EAST, [46] = EAST, [47] = EAST, + [48] = EAST, [49] = EAST, [50] = EAST, [51] = SOUTH, + [52] = SOUTH, [53] = SOUTH, [54] = SOUTH, [55] = SOUTH, + [56] = SOUTH, [57] = SOUTH, [58] = SOUTH, [59] = SOUTH, + [60] = SOUTH, [61] = SOUTH, [62] = SOUTH, [63] = SOUTH, + [64] = SOUTH, [65] = SOUTH, [66] = SOUTH, [67] = SOUTH, + [68] = SOUTH, [69] = SOUTH, [70] = SOUTH, [71] = SOUTH, + [72] = SOUTH, [73] = SOUTH, [74] = SOUTH, [75] = SOUTH, + [76] = SOUTH, [77] = SOUTH, [78] = SOUTH, [79] = SOUTH, + [80] = SOUTH, [81] = SOUTH, [82] = SOUTH, [83] = NORTH, + [84] = NORTH, [85] = NORTH, [86] = NORTH, [87] = EAST, + [88] = NORTH, [89] = NORTH, [90] = NORTH, [91] = NORTH, + [92] = NORTH, [93] = NORTH, [94] = NORTH, [95] = NORTH, + [96] = NORTH, [97] = NORTH, [98] = SOUTH, [99] = SOUTH, + [100] = SOUTH, [101] = SOUTH, [102] = NORTH, [103] = NORTH, + [104] = NORTH, [105] = WEST, [106] = WEST, [107] = WEST, + [108] = WEST, [109] = WEST, [110] = WEST, [111] = WEST, + [112] = WEST, [113] = WEST, [114] = SOUTH, [115] = SOUTH, + [116] = SOUTH, [117] = SOUTH, [118] = SOUTH, [119] = SOUTH, + [120] = SOUTH, [121] = SOUTH, [122] = SOUTH, [123] = SOUTH, + [124] = SOUTH, [125] = WEST, [126] = SOUTH, [127] = SOUTH, + [128] = SOUTH, [129] = SOUTH, [130] = SOUTH, [131] = SOUTH, + [132] = SOUTH, [133] = SOUTH, [134] = SOUTH, [135] = SOUTH, + [136] = SOUTH, [137] = SOUTH, [138] = SOUTH, [139] = SOUTH, + [140] = SOUTH, [141] = SOUTH, [142] = SOUTH, [143] = SOUTH, + [144] = SOUTH, [145] = SOUTH, [146] = SOUTH, [147] = SOUTH, + [148] = SOUTH, [149] = SOUTH, [150] = SOUTH, [151] = SOUTH, + [152] = SOUTH, [153] = SOUTH, [154] = SOUTH, [155] = WEST, + [156] = WEST, [157] = WEST, [158] = WEST, [159] = WEST, + [160] = WEST, [161] = WEST, [162] = WEST, [163] = WEST, + [164] = WEST, [165] = WEST, [166] = WEST, [167] = WEST, + [168] = WEST, [169] = NORTH, [170] = NORTH, [171] = NORTH, + [172] = NORTH, [173] = NORTH, [174] = NORTH, + // special pins + [175] = 0, [176] = 0, [177] = 0, [178] = 0, +}; + +static const char *sm8150_get_function_name(struct udevice *dev, + unsigned int selector) +{ + return msm_pinctrl_functions[selector].name; +} + +static const char *sm8150_get_pin_name(struct udevice *dev, + unsigned int selector) +{ + snprintf(pin_name, MAX_PIN_NAME_LEN, "gpio%u", selector); + return pin_name; +} + +static unsigned int sm8150_get_function_mux(__maybe_unused unsigned int pin, + unsigned int selector) +{ + return msm_pinctrl_functions[selector].val; +} + +static struct msm_pinctrl_data sm8150_data = { + .pin_data = { + .pin_offsets = sm8150_pin_offsets, + .pin_count = ARRAY_SIZE(sm8150_pin_offsets), + }, + .functions_count = ARRAY_SIZE(msm_pinctrl_functions), + .get_function_name = sm8150_get_function_name, + .get_function_mux = sm8150_get_function_mux, + .get_pin_name = sm8150_get_pin_name, +}; + +static const struct udevice_id msm_pinctrl_ids[] = { + { .compatible = "qcom,sm8150-pinctrl", .data = (ulong)&sm8150_data }, + { /* Sentinel */ } +}; + +U_BOOT_DRIVER(pinctrl_sm8150) = { + .name = "pinctrl_sm8150", + .id = UCLASS_NOP, + .of_match = msm_pinctrl_ids, + .ops = &msm_pinctrl_ops, + .bind = msm_pinctrl_bind, +};
Add pinctrl and GPIO driver for SM8150. Driver code is based on the similar U-Boot drivers. All constants are taken from the corresponding Linux driver. This drivers differs from the similar U-Boot drivers, because SM8150 SoC have different function IDs for the same functions on different pins. Co-authored-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com> Signed-off-by: Julius Lehmann <lehmanju@devpi.de> --- drivers/pinctrl/qcom/Kconfig | 8 ++ drivers/pinctrl/qcom/Makefile | 1 + drivers/pinctrl/qcom/pinctrl-sm8150.c | 119 ++++++++++++++++++++++++++ 3 files changed, 128 insertions(+) create mode 100644 drivers/pinctrl/qcom/pinctrl-sm8150.c