diff mbox series

[v2,5/5] rockchip: px30: Fix hard dependency to DEBUG_UART_BOARD_INIT

Message ID 20240903163858.1155218-6-lukasz.czechowski@thaumatec.com
State New
Delegated to: Kever Yang
Headers show
Series Rockchip: Allow to silent TPL/SPL debug console | expand

Commit Message

Łukasz Czechowski Sept. 3, 2024, 4:38 p.m. UTC 
Because DEBUG_UART_BOARD_INIT depends on DEBUG_UART, hard dependency
to DEBUG_UART_BOARD_INIT in ROCKCHIP_PX30 can cause warnings if
DEBUG_UART is disabled.
The DEBUG_UART_BOARD_INIT is already implied by ARCH_ROCKCHIP entry.
Remove hard dependency from ROCKCHIP_PX30, so that it will be
consistent with other rockchip boards.

Signed-off-by: Lukasz Czechowski <lukasz.czechowski@thaumatec.com>

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
---
 arch/arm/mach-rockchip/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Kever Yang Sept. 10, 2024, 9:51 a.m. UTC | #1 
On 2024/9/4 00:38, Lukasz Czechowski wrote:
> Because DEBUG_UART_BOARD_INIT depends on DEBUG_UART, hard dependency
> to DEBUG_UART_BOARD_INIT in ROCKCHIP_PX30 can cause warnings if
> DEBUG_UART is disabled.
> The DEBUG_UART_BOARD_INIT is already implied by ARCH_ROCKCHIP entry.
> Remove hard dependency from ROCKCHIP_PX30, so that it will be
> consistent with other rockchip boards.
>
> Signed-off-by: Lukasz Czechowski <lukasz.czechowski@thaumatec.com>
>
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   arch/arm/mach-rockchip/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
> index 47a6275d45f..c9aaf6d3476 100644
> --- a/arch/arm/mach-rockchip/Kconfig
> +++ b/arch/arm/mach-rockchip/Kconfig
> @@ -13,7 +13,6 @@ config ROCKCHIP_PX30
>   	imply SPL_SEPARATE_BSS
>   	imply SPL_SERIAL
>   	imply TPL_SERIAL
> -	select DEBUG_UART_BOARD_INIT
>   	imply ROCKCHIP_COMMON_BOARD
>   	imply SPL_ROCKCHIP_COMMON_BOARD
>   	imply ARMV8_CRYPTO
diff mbox series

Patch

diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index 47a6275d45f..c9aaf6d3476 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -13,7 +13,6 @@  config ROCKCHIP_PX30
 	imply SPL_SEPARATE_BSS
 	imply SPL_SERIAL
 	imply TPL_SERIAL
-	select DEBUG_UART_BOARD_INIT
 	imply ROCKCHIP_COMMON_BOARD
 	imply SPL_ROCKCHIP_COMMON_BOARD
 	imply ARMV8_CRYPTO