| Message ID | 20240901222634.460873-3-sjg@chromium.org |
|---|---|
| State | New |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Fix various bugs | expand |
On Sun, Sep 01, 2024 at 04:26:13PM -0600, Simon Glass wrote: > Devices should be probed when they are used, not before. Drop this > boot-time probing. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > (no changes since v1) > > drivers/mtd/nvmxip/nvmxip-uclass.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/mtd/nvmxip/nvmxip-uclass.c b/drivers/mtd/nvmxip/nvmxip-uclass.c > index 58e8c3fb74b..d18bd0e3d6b 100644 > --- a/drivers/mtd/nvmxip/nvmxip-uclass.c > +++ b/drivers/mtd/nvmxip/nvmxip-uclass.c > @@ -53,14 +53,7 @@ int nvmxip_probe(struct udevice *udev) > return 0; > } > > -static int nvmxip_post_bind(struct udevice *udev) > -{ > - dev_or_flags(udev, DM_FLAG_PROBE_AFTER_BIND); > - return 0; > -} > - > UCLASS_DRIVER(nvmxip) = { > .name = "nvmxip", > .id = UCLASS_NVMXIP, > - .post_bind = nvmxip_post_bind, > }; Once again, adding in the corstone1000 maintainers as the platform that actually uses this.
Hi Tom, On Mon, 2 Sept 2024 at 10:10, Tom Rini <trini@konsulko.com> wrote: > > On Sun, Sep 01, 2024 at 04:26:13PM -0600, Simon Glass wrote: > > > Devices should be probed when they are used, not before. Drop this > > boot-time probing. > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > --- > > > > (no changes since v1) > > > > drivers/mtd/nvmxip/nvmxip-uclass.c | 7 ------- > > 1 file changed, 7 deletions(-) > > > > diff --git a/drivers/mtd/nvmxip/nvmxip-uclass.c b/drivers/mtd/nvmxip/nvmxip-uclass.c > > index 58e8c3fb74b..d18bd0e3d6b 100644 > > --- a/drivers/mtd/nvmxip/nvmxip-uclass.c > > +++ b/drivers/mtd/nvmxip/nvmxip-uclass.c > > @@ -53,14 +53,7 @@ int nvmxip_probe(struct udevice *udev) > > return 0; > > } > > > > -static int nvmxip_post_bind(struct udevice *udev) > > -{ > > - dev_or_flags(udev, DM_FLAG_PROBE_AFTER_BIND); > > - return 0; > > -} > > - > > UCLASS_DRIVER(nvmxip) = { > > .name = "nvmxip", > > .id = UCLASS_NVMXIP, > > - .post_bind = nvmxip_post_bind, > > }; > > Once again, adding in the corstone1000 maintainers as the platform that > actually uses this. Just to mention that Abdellatif was added automatically by patman for the first version, but if there is no reply, after v2 I tend to drop it back, to avoid sending too many emails. Regards, Simon
Hi Simon, Tom, > > > Devices should be probed when they are used, not before. Drop this > > > boot-time probing. > > > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > > --- > > > > > > (no changes since v1) > > > > > > drivers/mtd/nvmxip/nvmxip-uclass.c | 7 ------- > > > 1 file changed, 7 deletions(-) > > > > > > diff --git a/drivers/mtd/nvmxip/nvmxip-uclass.c b/drivers/mtd/nvmxip/nvmxip-uclass.c > > > index 58e8c3fb74b..d18bd0e3d6b 100644 > > > --- a/drivers/mtd/nvmxip/nvmxip-uclass.c > > > +++ b/drivers/mtd/nvmxip/nvmxip-uclass.c > > > @@ -53,14 +53,7 @@ int nvmxip_probe(struct udevice *udev) > > > return 0; > > > } > > > > > > -static int nvmxip_post_bind(struct udevice *udev) > > > -{ > > > - dev_or_flags(udev, DM_FLAG_PROBE_AFTER_BIND); > > > - return 0; > > > -} > > > - > > > UCLASS_DRIVER(nvmxip) = { > > > .name = "nvmxip", > > > .id = UCLASS_NVMXIP, > > > - .post_bind = nvmxip_post_bind, > > > }; > > > > Once again, adding in the corstone1000 maintainers as the platform that > > actually uses this. > > Just to mention that Abdellatif was added automatically by patman for > the first version, but if there is no reply, after v2 I tend to drop > it back, to avoid sending too many emails. I'm happy to stay in the loop. > > Regards, > Simon Cheers Abdellatif
diff --git a/drivers/mtd/nvmxip/nvmxip-uclass.c b/drivers/mtd/nvmxip/nvmxip-uclass.c index 58e8c3fb74b..d18bd0e3d6b 100644 --- a/drivers/mtd/nvmxip/nvmxip-uclass.c +++ b/drivers/mtd/nvmxip/nvmxip-uclass.c @@ -53,14 +53,7 @@ int nvmxip_probe(struct udevice *udev) return 0; } -static int nvmxip_post_bind(struct udevice *udev) -{ - dev_or_flags(udev, DM_FLAG_PROBE_AFTER_BIND); - return 0; -} - UCLASS_DRIVER(nvmxip) = { .name = "nvmxip", .id = UCLASS_NVMXIP, - .post_bind = nvmxip_post_bind, };
Devices should be probed when they are used, not before. Drop this boot-time probing. Signed-off-by: Simon Glass <sjg@chromium.org> --- (no changes since v1) drivers/mtd/nvmxip/nvmxip-uclass.c | 7 ------- 1 file changed, 7 deletions(-)