diff mbox series

[v2,2/4] usb: ehci-mx5: Add a default for CFG_MXC_USB_PORTSC

Message ID 20240827194307.2933299-2-festevam@gmail.com
State Superseded
Delegated to: Fabio Estevam
Headers show
Series [v2,1/4] imx: Remove CFG_MXC_USB_FLAGS | expand

Commit Message

Fabio Estevam Aug. 27, 2024, 7:43 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

Just like drivers/usb/host/ehci-mx6.c, add a default for
drivers/usb/host/ehci-mx5.c.

The motivation for doing this is to remove CFG_MXC_USB_PORTSC
from board config files.

All the mx5 boards, with the exeption of mx51evk, define
CFG_MXC_USB_PORTSC as:

 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)

So move this definition as a default into ehci-mx5.c.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Change since v1:
- Improve the commit log (Marek).

 drivers/usb/host/ehci-mx5.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Peng Fan Aug. 28, 2024, 7:41 a.m. UTC | #1 
> Subject: [PATCH v2 2/4] usb: ehci-mx5: Add a default for
> CFG_MXC_USB_PORTSC
> 
> From: Fabio Estevam <festevam@denx.de>
> 
> Just like drivers/usb/host/ehci-mx6.c, add a default for
> drivers/usb/host/ehci-mx5.c.
> 
> The motivation for doing this is to remove CFG_MXC_USB_PORTSC
> from board config files.
> 
> All the mx5 boards, with the exeption of mx51evk, define
> CFG_MXC_USB_PORTSC as:
> 
>  #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
> 
> So move this definition as a default into ehci-mx5.c.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Reviewed-by: Peng Fan <peng.fan@nxp.com>
diff mbox series

Patch

diff --git a/drivers/usb/host/ehci-mx5.c b/drivers/usb/host/ehci-mx5.c
index 44912de7787..d8f521befe1 100644
--- a/drivers/usb/host/ehci-mx5.c
+++ b/drivers/usb/host/ehci-mx5.c
@@ -79,6 +79,10 @@ 
 /* USB_CTRL_1 */
 #define MXC_USB_CTRL_UH1_EXT_CLK_EN	(1 << 25)
 
+#ifndef CFG_MXC_USB_PORTSC
+#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
+#endif
+
 int mxc_set_usbcontrol(int port, unsigned int flags)
 {
 	unsigned int v;