diff mbox series

[3/4] rockchip: Kconfig: PX30: Weaken dependency TPL/SPL serial

Message ID 20240827142058.594556-4-lukasz.czechowski@thaumatec.com
State Superseded
Delegated to: Kever Yang
Headers show
Series Rockchip: Allow to silent TPL/SPL debug console | expand

Commit Message

Lukasz Czechowski Aug. 27, 2024, 2:20 p.m. UTC
Allow to disable serial console in TPL and SPL. Weak dependency
to SPL_SERIAL and TPL_SERIAL is also used in other Rockchip boards.

Signed-off-by: Lukasz Czechowski <lukasz.czechowski@thaumatec.com>
---
 arch/arm/mach-rockchip/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Quentin Schulz Aug. 29, 2024, 10:21 a.m. UTC | #1
Hi Lukasz,

On 8/27/24 4:20 PM, Lukasz Czechowski wrote:
> Allow to disable serial console in TPL and SPL. Weak dependency
> to SPL_SERIAL and TPL_SERIAL is also used in other Rockchip boards.
> 
> Signed-off-by: Lukasz Czechowski <lukasz.czechowski@thaumatec.com

FWIW, most commits in that file for px30 have the following prefix for 
the commit title:

rockchip: px30:

so following the same pattern would make sense.

The change is fine though, so:

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin
diff mbox series

Patch

diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index fc1b638ff01..47a6275d45f 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -11,8 +11,8 @@  config ROCKCHIP_PX30
 	select TPL_TINY_FRAMEWORK if TPL
 	select TPL_NEEDS_SEPARATE_STACK if TPL
 	imply SPL_SEPARATE_BSS
-	select SPL_SERIAL
-	select TPL_SERIAL
+	imply SPL_SERIAL
+	imply TPL_SERIAL
 	select DEBUG_UART_BOARD_INIT
 	imply ROCKCHIP_COMMON_BOARD
 	imply SPL_ROCKCHIP_COMMON_BOARD