diff mbox series

[2/3] usb: ehci-mx5: Add a default for CFG_MXC_USB_PORTSC

Message ID 20240827005826.2831478-2-festevam@gmail.com
State Changes Requested
Delegated to: Fabio Estevam
Headers show
Series [1/3] imx: Remove CFG_MXC_USB_FLAGS | expand

Commit Message

Fabio Estevam Aug. 27, 2024, 12:58 a.m. UTC 
From: Fabio Estevam <festevam@denx.de>

Just like drivers/usb/host/ehci-mx6.c, add a default for
drivers/usb/host/ehci-mx5.c.

The motivation for doing this is to remove CFG_MXC_USB_PORTSC
from board config files.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 drivers/usb/host/ehci-mx5.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Marek Vasut Aug. 27, 2024, 4:29 a.m. UTC | #1 
On 8/27/24 2:58 AM, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Just like drivers/usb/host/ehci-mx6.c, add a default for
> drivers/usb/host/ehci-mx5.c.
> 
> The motivation for doing this is to remove CFG_MXC_USB_PORTSC
> from board config files.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>   drivers/usb/host/ehci-mx5.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/host/ehci-mx5.c b/drivers/usb/host/ehci-mx5.c
> index 44912de7787d..d8f521befe14 100644
> --- a/drivers/usb/host/ehci-mx5.c
> +++ b/drivers/usb/host/ehci-mx5.c
> @@ -79,6 +79,10 @@
>   /* USB_CTRL_1 */
>   #define MXC_USB_CTRL_UH1_EXT_CLK_EN	(1 << 25)
>   
> +#ifndef CFG_MXC_USB_PORTSC
> +#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)

Why this specific value ? (this should be in the commit message)
diff mbox series

Patch

diff --git a/drivers/usb/host/ehci-mx5.c b/drivers/usb/host/ehci-mx5.c
index 44912de7787d..d8f521befe14 100644
--- a/drivers/usb/host/ehci-mx5.c
+++ b/drivers/usb/host/ehci-mx5.c
@@ -79,6 +79,10 @@ 
 /* USB_CTRL_1 */
 #define MXC_USB_CTRL_UH1_EXT_CLK_EN	(1 << 25)
 
+#ifndef CFG_MXC_USB_PORTSC
+#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
+#endif
+
 int mxc_set_usbcontrol(int port, unsigned int flags)
 {
 	unsigned int v;