| Message ID | 20240826170140.2791128-1-trini@konsulko.com |
|---|---|
| State | New |
| Delegated to: | Heinrich Schuchardt |
| Headers | show |
| Series | doc/develop/sending_patches.rst: Reword where our git tree is slightly | expand |
Hi Tom, On 8/26/24 7:01 PM, Tom Rini wrote: > We shouldn't have had the link to our git tree be contained within "``" > as that meant that it did not work as a link, so remove those. And > rather than make this a link plus text, keep this as a link within the > text for overall clarity. > > Suggested-by: Quentin Schulz <quentin.schulz@cherry.de> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> Thanks! Quentin
On 26/08/2024 19:01, Tom Rini wrote: > We shouldn't have had the link to our git tree be contained within "``" > as that meant that it did not work as a link, so remove those. And > rather than make this a link plus text, keep this as a link within the > text for overall clarity. > > Suggested-by: Quentin Schulz <quentin.schulz@cherry.de> > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > doc/develop/sending_patches.rst | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/doc/develop/sending_patches.rst b/doc/develop/sending_patches.rst > index 82efb717b179..990cb9912a92 100644 > --- a/doc/develop/sending_patches.rst > +++ b/doc/develop/sending_patches.rst > @@ -76,11 +76,10 @@ General Patch Submission Rules > compression, no attachments. Just plain text. The best way the generate > patches is by using the ``git format-patch`` command. For a patch that is > fixing a bug or regression of some sort, please use the ``master`` branch of > - the mainline U-Boot git repository > - (``https://source.denx.de/u-boot/u-boot.git``) as reference. For new > - features, if the ``next`` branch has been opened (which happens with the > - release of ``-rc2``) that branch should be used, otherwise ``master`` is > - acceptable. > + the mainline U-Boot git repository located at > + https://source.denx.de/u-boot/u-boot.git as reference. For new features, if > + the ``next`` branch has been opened (which happens with the release of > + ``-rc2``) that branch should be used, otherwise ``master`` is acceptable. > > * Make sure that your mailer does not mangle the patch by automatic changes > like wrapping of longer lines etc. Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/doc/develop/sending_patches.rst b/doc/develop/sending_patches.rst index 82efb717b179..990cb9912a92 100644 --- a/doc/develop/sending_patches.rst +++ b/doc/develop/sending_patches.rst @@ -76,11 +76,10 @@ General Patch Submission Rules compression, no attachments. Just plain text. The best way the generate patches is by using the ``git format-patch`` command. For a patch that is fixing a bug or regression of some sort, please use the ``master`` branch of - the mainline U-Boot git repository - (``https://source.denx.de/u-boot/u-boot.git``) as reference. For new - features, if the ``next`` branch has been opened (which happens with the - release of ``-rc2``) that branch should be used, otherwise ``master`` is - acceptable. + the mainline U-Boot git repository located at + https://source.denx.de/u-boot/u-boot.git as reference. For new features, if + the ``next`` branch has been opened (which happens with the release of + ``-rc2``) that branch should be used, otherwise ``master`` is acceptable. * Make sure that your mailer does not mangle the patch by automatic changes like wrapping of longer lines etc.
We shouldn't have had the link to our git tree be contained within "``" as that meant that it did not work as a link, so remove those. And rather than make this a link plus text, keep this as a link within the text for overall clarity. Suggested-by: Quentin Schulz <quentin.schulz@cherry.de> Signed-off-by: Tom Rini <trini@konsulko.com> --- doc/develop/sending_patches.rst | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)